<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182329] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182329">182329</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-04-03 13:43:56 -0700 (Fri, 03 Apr 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Perf dashboard sometimes fails to update zooming level
https://bugs.webkit.org/show_bug.cgi?id=143359
Reviewed by Darin Adler.
The bug was caused by various bugs that ended up in an exception.
* public/v2/app.js:
(App.Pane._handleFetchErrors): Removed superfluous console.log.
(App.Pane.computeStatus): Fixed the bug in <a href="http://trac.webkit.org/projects/webkit/changeset/182185">r182185</a> that previousPoint could be null.
(App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
* public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
to # when Ember.js fails to attach event listeners on time.
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
the containing element's size is 0.
(App.InteractiveChartComponent._updateBrush): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2interactivechartjs">trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (182328 => 182329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-04-03 20:16:53 UTC (rev 182328)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-04-03 20:43:56 UTC (rev 182329)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION: Perf dashboard sometimes fails to update zooming level
+ https://bugs.webkit.org/show_bug.cgi?id=143359
+
+ Reviewed by Darin Adler.
+
+ The bug was caused by various bugs that ended up in an exception.
+
+ * public/v2/app.js:
+ (App.Pane._handleFetchErrors): Removed superfluous console.log.
+ (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
+ (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
+ * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
+ to # when Ember.js fails to attach event listeners on time.
+ * public/v2/interactive-chart.js:
+ (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
+ the containing element's size is 0.
+ (App.InteractiveChartComponent._updateBrush): Ditto.
+
</ins><span class="cx"> 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Perf dashboard should have UI to test out anomaly detection strategies
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (182328 => 182329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-04-03 20:16:53 UTC (rev 182328)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-04-03 20:43:56 UTC (rev 182329)
</span><span class="lines">@@ -374,7 +374,6 @@
</span><span class="cx"> },
</span><span class="cx"> _handleFetchErrors: function (platformId, metricId, result)
</span><span class="cx"> {
</span><del>- console.log(platformId, metricId, result)
</del><span class="cx"> if (!result || typeof(result) === "string")
</span><span class="cx"> this.set('failure', 'Failed to fetch the JSON with an error: ' + result);
</span><span class="cx"> else if (!result.platform)
</span><span class="lines">@@ -423,13 +422,18 @@
</span><span class="cx"> } else if (diffFromTarget !== undefined)
</span><span class="cx"> label = formatter(Math.abs(diffFromTarget)) + ' until target';
</span><span class="cx">
</span><del>- var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
</del><ins>+ var valueDelta = null;
+ var relativeDelta = null;
+ if (previousPoint) {
+ valueDelta = chartData.deltaFormatter(currentPoint.value - previousPoint.value);
+ relativeDelta = d3.format('+.2p')((currentPoint.value - previousPoint.value) / previousPoint.value);
+ }
</ins><span class="cx"> return {
</span><span class="cx"> className: className,
</span><span class="cx"> label: label,
</span><span class="cx"> currentValue: chartData.formatter(currentPoint.value),
</span><span class="cx"> valueDelta: valueDelta,
</span><del>- relativeDelta: d3.format('+.2p')((currentPoint.value - previousPoint.value) / previousPoint.value),
</del><ins>+ relativeDelta: relativeDelta,
</ins><span class="cx"> };
</span><span class="cx"> },
</span><span class="cx"> _relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
</span><span class="lines">@@ -969,6 +973,8 @@
</span><span class="cx"> zoomed: function (selection)
</span><span class="cx"> {
</span><span class="cx"> this.set('mainPlotDomain', selection ? selection : this.get('overviewDomain'));
</span><ins>+ if (selection)
+ this.set('overviewSelection', selection);
</ins><span class="cx"> Ember.run.debounce(this, 'propagateZoom', 100);
</span><span class="cx"> },
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (182328 => 182329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-04-03 20:16:53 UTC (rev 182328)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-04-03 20:43:56 UTC (rev 182329)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> {{view App.NumberOfDaysControlView tagName="ul" numberOfDays=numberOfDays}}
</span><span class="cx"> <ul class="controls">
</span><span class="cx"> <li>
</span><del>- <a href="#" class="control-button" {{action toggleEditMode}}>
</del><ins>+ <a href="javascript:false" class="control-button" {{action toggleEditMode}}>
</ins><span class="cx"> {{#if controller.editMode}}
</span><span class="cx"> Finish editing
</span><span class="cx"> {{else}}
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> {{#each headerColumns}}
</span><span class="cx"> {{#if controller.editMode}}
</span><span class="cx"> <th>
</span><del>- <a href="#" title="Remove column" {{action "removeColumn" index}}>
</del><ins>+ <a href="javascript:false" title="Remove column" {{action "removeColumn" index}}>
</ins><span class="cx"> {{partial "close-button"}}
</span><span class="cx"> </a>
</span><span class="cx"> {{input value=label}}
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> <tr>
</span><span class="cx"> {{#if controller.editMode}}
</span><span class="cx"> <th>
</span><del>- <a href="#" title="Remove row" {{action "removeRow" this}}>
</del><ins>+ <a href="javascript:false" title="Remove row" {{action "removeRow" this}}>
</ins><span class="cx"> {{partial "close-button"}}
</span><span class="cx"> </a>
</span><span class="cx"> {{input value=header}}
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> {{/if}}
</span><span class="cx"> {{/if}}
</span><span class="cx"> {{#if controller.editMode}}
</span><del>- <a href="#" title="Reset pane" class="reset" {{action "resetPane" this}}>
</del><ins>+ <a href="javascript:false" title="Reset pane" class="reset" {{action "resetPane" this}}>
</ins><span class="cx"> {{partial "close-button"}}
</span><span class="cx"> </a>
</span><span class="cx"> {{/if}}
</span><span class="lines">@@ -146,17 +146,17 @@
</span><span class="cx"> <section class="chart-pane" tabindex="0">
</span><span class="cx"> <header>
</span><span class="cx"> <h1 {{action "toggleDetails"}}>{{metric.fullName}} - {{ platform.name}}</h1>
</span><del>- <a href="#" title="Close" class="close-button" {{action "close"}}>{{partial "close-button"}}</a>
</del><ins>+ <a href="javascript:false" title="Close" class="close-button" {{action "close"}}>{{partial "close-button"}}</a>
</ins><span class="cx"> {{#if movingAverageStrategies}}
</span><del>- <a href="#" title="Statistical Tools" class="stat-button" {{action "toggleStatPane"}}>{{partial "stat-button"}}</a>
</del><ins>+ <a href="javascript:false" title="Statistical Tools" class="stat-button" {{action "toggleStatPane"}}>{{partial "stat-button"}}</a>
</ins><span class="cx"> {{/if}}
</span><span class="cx"> {{#if App.Manifest.bugTrackers}}
</span><del>- <a href="#" title="Analysis" class="bugs-button" {{action "toggleBugsPane"}}>
</del><ins>+ <a href="javascript:false" title="Analysis" class="bugs-button" {{action "toggleBugsPane"}}>
</ins><span class="cx"> {{partial "analysis-button"}}
</span><span class="cx"> </a>
</span><span class="cx"> {{/if}}
</span><span class="cx"> {{#if App.Manifest.repositoriesWithReportedCommits}}
</span><del>- <a href="#" title="Search" class="search-button" {{action "toggleSearchPane"}}>{{partial "search-button"}}</a>
</del><ins>+ <a href="javascript:false" title="Search" class="search-button" {{action "toggleSearchPane"}}>{{partial "search-button"}}</a>
</ins><span class="cx"> {{/if}}
</span><span class="cx"> </header>
</span><span class="cx">
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx"> <script type="text/x-handlebars" data-template-name="components/interactive-chart">
</span><span class="cx"> {{#if interactive}}
</span><span class="cx"> <div class="selection-toolbar" style="display: none;">
</span><del>- <a href="#" class="button" {{action "zoom"}}>
</del><ins>+ <a href="javascript:false" class="button" {{action "zoom"}}>
</ins><span class="cx"> <svg class="zoom" viewBox="0 0 100 100">
</span><span class="cx"> <g stroke-width="0" stroke="none">
</span><span class="cx"> <polygon points="25,25 5,50 25,75"/>
</span><span class="lines">@@ -456,22 +456,22 @@
</span><span class="cx">
</span><span class="cx"> <script type="text/x-handlebars" data-template-name="number-of-days-controls">
</span><span class="cx"> <li class="numberOfDaysIs1">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 1}}>1D</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 1}}>1D</a>
</ins><span class="cx"> </li>
</span><span class="cx"> <li class="numberOfDaysIs7">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 7}}>1W</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 7}}>1W</a>
</ins><span class="cx"> </li>
</span><span class="cx"> <li class="numberOfDaysIs30">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 30}}>1M</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 30}}>1M</a>
</ins><span class="cx"> </li>
</span><span class="cx"> <li class="numberOfDaysIs90">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 90}}>3M</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 90}}>3M</a>
</ins><span class="cx"> </li>
</span><span class="cx"> <li class="numberOfDaysIs183">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 183}}>6M</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 183}}>6M</a>
</ins><span class="cx"> </li>
</span><span class="cx"> <li class="numberOfDaysIs365">
</span><del>- <a href="#" class="control-button" {{action "setNumberOfDays" 365}}>1Y</a>
</del><ins>+ <a href="javascript:false" class="control-button" {{action "setNumberOfDays" 365}}>1Y</a>
</ins><span class="cx"> </li>
</span><span class="cx"> </script>
</span><span class="cx">
</span><span class="lines">@@ -493,7 +493,7 @@
</span><span class="cx"> {{else}}
</span><span class="cx"> <li>
</span><span class="cx"> {{#if actionName}}
</span><del>- <a href="#" class="label" {{action actionName actionArgument}}>{{label}}</a>
</del><ins>+ <a href="javascript:false" class="label" {{action actionName actionArgument}}>{{label}}</a>
</ins><span class="cx"> {{else}}
</span><span class="cx"> <a class="label">{{label}}</a>
</span><span class="cx"> {{/if}}
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2interactivechartjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js (182328 => 182329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js 2015-04-03 20:16:53 UTC (rev 182328)
+++ trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js 2015-04-03 20:43:56 UTC (rev 182329)
</span><span class="lines">@@ -238,8 +238,8 @@
</span><span class="cx"> margin.left += 3 * rem;
</span><span class="cx">
</span><span class="cx"> this._margin = margin;
</span><del>- this._contentWidth = this._totalWidth - margin.left - margin.right;
- this._contentHeight = this._totalHeight - margin.top - margin.bottom;
</del><ins>+ this._contentWidth = Math.max(0, this._totalWidth - margin.left - margin.right);
+ this._contentHeight = Math.max(0, this._totalHeight - margin.top - margin.bottom);
</ins><span class="cx">
</span><span class="cx"> this._svg.attr("transform", "translate(" + margin.left + "," + margin.top + ")");
</span><span class="cx">
</span><span class="lines">@@ -275,7 +275,7 @@
</span><span class="cx"> .call(this._brush)
</span><span class="cx"> .selectAll("rect")
</span><span class="cx"> .attr("y", 1)
</span><del>- .attr("height", this._contentHeight - 2);
</del><ins>+ .attr("height", Math.max(0, this._contentHeight - 2));
</ins><span class="cx"> this._updateSelectionToolbar();
</span><span class="cx"> },
</span><span class="cx"> _relayoutDataAndAxes: function (selection)
</span></span></pre>
</div>
</div>
</body>
</html>