<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182199] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182199">182199</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-31 12:43:45 -0700 (Tue, 31 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Searching commits can highlight wrong data points
https://bugs.webkit.org/show_bug.cgi?id=143272
Reviewed by Antti Koivisto.
The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
return commit times with only second precision. This resulted in the frontend code to match a commit
with the data point that included the next commit when the millisecond component of commit's timestamp
wasn't identically 0.
This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
so miliseconds component was only preserved in /api/commits.
Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
it returns time in milisecond precision.
* public/api/commits.php:
(fetch_commits_between): Use Database::to_js_time for format commit times.
(format_commit): Ditto.
* public/include/db.php:
(Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
* public/v2/data.js:
(CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicapicommitsphp">trunk/Websites/perf.webkit.org/public/api/commits.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludedbphp">trunk/Websites/perf.webkit.org/public/include/db.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2datajs">trunk/Websites/perf.webkit.org/public/v2/data.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (182198 => 182199)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 19:42:56 UTC (rev 182198)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-03-31 19:43:45 UTC (rev 182199)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ REGRESSION: Searching commits can highlight wrong data points
+ https://bugs.webkit.org/show_bug.cgi?id=143272
+
+ Reviewed by Antti Koivisto.
+
+ The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
+ return commit times with only second precision. This resulted in the frontend code to match a commit
+ with the data point that included the next commit when the millisecond component of commit's timestamp
+ wasn't identically 0.
+
+ This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
+ was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
+ so miliseconds component was only preserved in /api/commits.
+
+ Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
+ it returns time in milisecond precision.
+
+ * public/api/commits.php:
+ (fetch_commits_between): Use Database::to_js_time for format commit times.
+ (format_commit): Ditto.
+ * public/include/db.php:
+ (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
+ * public/v2/data.js:
+ (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
+
+2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Perf dashboard should show relative change in values
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=143252
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicapicommitsphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/api/commits.php (182198 => 182199)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/api/commits.php 2015-03-31 19:42:56 UTC (rev 182198)
+++ trunk/Websites/perf.webkit.org/public/api/commits.php 2015-03-31 19:43:45 UTC (rev 182199)
</span><span class="lines">@@ -98,6 +98,8 @@
</span><span class="cx"> $commits = $db->query_and_fetch_all($statements . ' ORDER BY commit_time', $values);
</span><span class="cx"> if (!is_array($commits))
</span><span class="cx"> exit_with_error('FailedToFetchCommits', array('repository' => $repository_id, 'first' => $first, 'second' => $second));
</span><ins>+ foreach ($commits as &$commit)
+ $commit['time'] = Database::to_js_time($commit['time']);
</ins><span class="cx"> return $commits;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -106,7 +108,7 @@
</span><span class="cx"> 'id' => $commit_row['commit_id'],
</span><span class="cx"> 'revision' => $commit_row['commit_revision'],
</span><span class="cx"> 'parent' => $commit_row['commit_parent'],
</span><del>- 'time' => $commit_row['commit_time'],
</del><ins>+ 'time' => Database::to_js_time($commit_row['commit_time']),
</ins><span class="cx"> 'authorName' => $committer_row ? $committer_row['committer_name'] : null,
</span><span class="cx"> 'authorEmail' => $committer_row ? $committer_row['committer_account'] : null,
</span><span class="cx"> 'message' => $commit_row['commit_message']
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludedbphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/db.php (182198 => 182199)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/db.php 2015-03-31 19:42:56 UTC (rev 182198)
+++ trunk/Websites/perf.webkit.org/public/include/db.php 2015-03-31 19:43:45 UTC (rev 182199)
</span><span class="lines">@@ -65,7 +65,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static function to_js_time($time_str) {
</span><del>- return strtotime($time_str) * 1000;
</del><ins>+ $timestamp_in_s = strtotime($time_str);
+ $dot_index = strrpos($time_str, '.');
+ if ($dot_index !== FALSE)
+ $timestamp_in_s += floatval(substr($time_str, $dot_index));
+ return intval($timestamp_in_s * 1000);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function connect() {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2datajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (182198 => 182199)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/data.js 2015-03-31 19:42:56 UTC (rev 182198)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2015-03-31 19:43:45 UTC (rev 182199)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var fetchedCommits = data.commits;
</span><del>- fetchedCommits.forEach(function (commit) { commit.time = new Date(commit.time.replace(' ', 'T')); });
</del><ins>+ fetchedCommits.forEach(function (commit) { commit.time = new Date(commit.time); });
</ins><span class="cx">
</span><span class="cx"> if (useCache)
</span><span class="cx"> CommitLogs._cacheConsecutiveCommits(repository, from, to, fetchedCommits);
</span></span></pre>
</div>
</div>
</body>
</html>