<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182221] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182221">182221</a></dd>
<dt>Author</dt> <dd>nvasilyev@apple.com</dd>
<dt>Date</dt> <dd>2015-03-31 23:16:48 -0700 (Tue, 31 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: console.error(object) has double disclosure triangles
https://bugs.webkit.org/show_bug.cgi?id=142069
Use inline-block instead of "float: left" or "position: absolute" to
make layout more predictable and easier to understand.
Reviewed by Timothy Hatcher.
* UserInterface/Views/LogContentView.css:
(.outline-disclosure, .outline-disclosure ol):
(.outline-disclosure > li.parent):
(.outline-disclosure > li.parent::before):
(.outline-disclosure li.parent): Deleted.
(.outline-disclosure li.parent::before): Deleted.
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property > .titles):
(.object-tree-property > .disclosure-button):
(.object-tree-property > .icon):
* UserInterface/Views/ObjectTreeView.css:
(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementcss">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (182220 => 182221)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 06:16:48 UTC (rev 182221)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2015-03-31 Nikita Vasilyev <nvasilyev@apple.com>
+
+ Web Inspector: console.error(object) has double disclosure triangles
+ https://bugs.webkit.org/show_bug.cgi?id=142069
+
+ Use inline-block instead of "float: left" or "position: absolute" to
+ make layout more predictable and easier to understand.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/LogContentView.css:
+ (.outline-disclosure, .outline-disclosure ol):
+ (.outline-disclosure > li.parent):
+ (.outline-disclosure > li.parent::before):
+ (.outline-disclosure li.parent): Deleted.
+ (.outline-disclosure li.parent::before): Deleted.
+ * UserInterface/Views/ObjectTreePropertyTreeElement.css:
+ (.object-tree-property > .titles):
+ (.object-tree-property > .disclosure-button):
+ (.object-tree-property > .icon):
+ * UserInterface/Views/ObjectTreeView.css:
+ (.object-tree > :matches(.title, .object-preview)::before):
+ (.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
+
</ins><span class="cx"> 2015-03-31 Jono Wells <jonowells@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: REGRESSION: Filtering no longer works
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (182220 => 182221)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-04-01 06:16:48 UTC (rev 182221)
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx">
</span><span class="cx"> .outline-disclosure, .outline-disclosure ol {
</span><span class="cx"> list-style-type: none;
</span><del>- -webkit-padding-start: 12px;
</del><ins>+ -webkit-padding-start: 0;
</ins><span class="cx"> margin: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -393,7 +393,7 @@
</span><span class="cx"> margin-bottom: 2px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.outline-disclosure li.parent {
</del><ins>+.outline-disclosure > li.parent {
</ins><span class="cx"> margin-left: -12px
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -401,7 +401,7 @@
</span><span class="cx"> margin-left: -12px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.outline-disclosure li.parent::before {
</del><ins>+.outline-disclosure > li.parent::before {
</ins><span class="cx"> float: left;
</span><span class="cx">
</span><span class="cx"> content: "";
</span><span class="lines">@@ -413,7 +413,7 @@
</span><span class="cx"> width: 8px;
</span><span class="cx"> height: 8px;
</span><span class="cx">
</span><del>- margin-top: 4px;
</del><ins>+ margin-top: 3px;
</ins><span class="cx"> padding-right: 2px;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (182220 => 182221)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2015-04-01 06:16:48 UTC (rev 182221)
</span><span class="lines">@@ -35,10 +35,13 @@
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> white-space: nowrap;
</span><ins>+ display: inline-block;
+ vertical-align: top;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .object-tree-property > .disclosure-button {
</span><del>- float: left;
</del><ins>+ display: inline-block;
+ vertical-align: top;
</ins><span class="cx">
</span><span class="cx"> width: 16px;
</span><span class="cx"> height: 16px;
</span><span class="lines">@@ -61,7 +64,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .object-tree-property > .icon {
</span><del>- float: left;
</del><ins>+ display: inline-block;
+ vertical-align: top;
</ins><span class="cx"> position: relative;
</span><span class="cx">
</span><span class="cx"> width: 16px;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (182220 => 182221)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2015-04-01 06:16:48 UTC (rev 182221)
</span><span class="lines">@@ -32,10 +32,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .object-tree > :matches(.title, .object-preview)::before {
</span><del>- position: absolute;
</del><ins>+ display: inline-block;
</ins><span class="cx">
</span><del>- top: 0;
- left: -2px;
</del><ins>+ vertical-align: baseline;
+ margin-bottom: -2px;
+ margin-right: 2px;
</ins><span class="cx">
</span><span class="cx"> width: 13px;
</span><span class="cx"> height: 13px;
</span><span class="lines">@@ -49,7 +50,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .object-tree:not(.lossless-preview) > :matches(.title, .object-preview) {
</span><del>- margin-left: 13px;
</del><ins>+ margin-left: 1px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .object-tree.expanded > :matches(.title, .object-preview)::before {
</span></span></pre>
</div>
</div>
</body>
</html>