<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182134] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182134">182134</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-30 00:20:43 -0700 (Mon, 30 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Start the features.json files
https://bugs.webkit.org/show_bug.cgi?id=143207
Reviewed by Darin Adler.
Source/JavaScriptCore:
Start the features.json files to have something to experiment
with for the UI.
* features.json: Added.
Source/WebCore:
* features.json: Added.
Tools:
I kept the style checking light. We'll have to figure
what is the best format for each field.
* Scripts/webkitpy/style/checker.py:
(CheckerDispatcher._create_checker):
* Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONContributorsChecker.check):
(JSONFeaturesChecker):
(JSONFeaturesChecker.check):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerpy">trunk/Tools/Scripts/webkitpy/style/checker.py</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckersjsoncheckerpy">trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCorefeaturesjson">trunk/Source/JavaScriptCore/features.json</a></li>
<li><a href="#trunkSourceWebCorefeaturesjson">trunk/Source/WebCore/features.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (182133 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-03-30 04:17:45 UTC (rev 182133)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-03-30 Benjamin Poulain <benjamin@webkit.org>
+
+ Start the features.json files
+ https://bugs.webkit.org/show_bug.cgi?id=143207
+
+ Reviewed by Darin Adler.
+
+ Start the features.json files to have something to experiment
+ with for the UI.
+
+ * features.json: Added.
+
</ins><span class="cx"> 2015-03-29 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Addresing post-review comment after r182122
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorefeaturesjson"></a>
<div class="addfile"><h4>Added: trunk/Source/JavaScriptCore/features.json (0 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/features.json (rev 0)
+++ trunk/Source/JavaScriptCore/features.json 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -0,0 +1,50 @@
</span><ins>+{
+ "specification": [
+ {
+ "name": "ES6",
+ "url": "http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts",
+ "keywords": ["es6", "es2015", "ecmascript"]
+ },
+ {
+ "name": "ES7",
+ "keywords": ["es7", "ecmascript"]
+ }
+ ],
+
+ "features": [
+ {
+ "name": "Array.prototype.includes",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "https://github.com/tc39/Array.prototype.includes",
+ "documentation-url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes",
+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=142707",
+ "specification": "ES7"
+ },
+ {
+ "name": "Promise Objects",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true,
+ "shipped": ["ios8-safari", "osx-safari-7.1"]
+ },
+ "url": "https://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-objects",
+ "documentation-url": "https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Promise",
+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=120260",
+ "specification": "ES6"
+ },
+ {
+ "name": "Symbol Objects",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "https://people.mozilla.org/~jorendorff/es6-draft.html#sec-symbol-objects",
+ "documentation-url": "https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol",
+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=140435",
+ "specification": "ES6"
+ }
+ ]
+}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182133 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-30 04:17:45 UTC (rev 182133)
+++ trunk/Source/WebCore/ChangeLog 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-03-30 Benjamin Poulain <benjamin@webkit.org>
+
+ Start the features.json files
+ https://bugs.webkit.org/show_bug.cgi?id=143207
+
+ Reviewed by Darin Adler.
+
+ * features.json: Added.
+
</ins><span class="cx"> 2015-03-29 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Convert arguments to ScrollingCoordinator functions to references
</span></span></pre></div>
<a id="trunkSourceWebCorefeaturesjson"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/features.json (0 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/features.json (rev 0)
+++ trunk/Source/WebCore/features.json 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -0,0 +1,67 @@
</span><ins>+{
+ "specification": [
+ {
+ "name": "HTML5",
+ "url": "https://html.spec.whatwg.org",
+ "keywords": ["html", "html5", "html5.1"],
+ "category": "html"
+ },
+ {
+ "name": "DOM",
+ "url": "https://dom.spec.whatwg.org",
+ "keywords": ["dom", "dom4"],
+ "category": "html"
+ },
+ {
+ "name": "Streams",
+ "url": "https://streams.spec.whatwg.org",
+ "keywords": ["streams api"],
+ "category": "webapps"
+ },
+ {
+ "name": "CSS Selectors Level 4",
+ "url": "http://dev.w3.org/csswg/selectors-4/",
+ "keywords": ["css selectors", "selectors"],
+ "category": "css"
+ },
+ {
+ "name": "CSS Media Queries Level 4",
+ "url": "http://dev.w3.org/csswg/mediaqueries-4/",
+ "keywords": ["css media queries", "media queries"],
+ "category": "css"
+ }
+ ],
+
+ "features": [
+ {
+ "name": "Element.closest()",
+ "status": {
+ "status": "Done",
+ "enabled-by-default": true
+ },
+ "url": "https://dom.spec.whatwg.org/#dom-element-closest",
+ "documentation-url": "https://developer.mozilla.org/en-US/docs/Web/API/Element/closest",
+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=137418",
+ "specification": "DOM",
+ "description": "Find the closest ancestor matching the selector passed as argument. The element itself is returned if it matches the selector."
+ },
+ {
+ "name": "Force Click Events",
+ "status": {
+ "status": "Prototyping",
+ "enabled-by-default": true
+ },
+ "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=142836",
+ "description": "Provide the events necessary to handle force click events in the page, overriding the default behavior."
+ },
+ {
+ "name": "Readable Streams",
+ "status": {
+ "status": "In Development",
+ "enabled-by-default": true
+ },
+ "url": "https://streams.spec.whatwg.org/#rs",
+ "specification": "Streams"
+ }
+ ]
+}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (182133 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-03-30 04:17:45 UTC (rev 182133)
+++ trunk/Tools/ChangeLog 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-03-30 Benjamin Poulain <benjamin@webkit.org>
+
+ Start the features.json files
+ https://bugs.webkit.org/show_bug.cgi?id=143207
+
+ Reviewed by Darin Adler.
+
+ I kept the style checking light. We'll have to figure
+ what is the best format for each field.
+
+ * Scripts/webkitpy/style/checker.py:
+ (CheckerDispatcher._create_checker):
+ * Scripts/webkitpy/style/checkers/jsonchecker.py:
+ (JSONContributorsChecker.check):
+ (JSONFeaturesChecker):
+ (JSONFeaturesChecker.check):
+
</ins><span class="cx"> 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [buildbot] clean-build script should remove untracked files and revert local changes too
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (182133 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checker.py 2015-03-30 04:17:45 UTC (rev 182133)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -45,6 +45,7 @@
</span><span class="cx"> from checkers.js import JSChecker
</span><span class="cx"> from checkers.jsonchecker import JSONChecker
</span><span class="cx"> from checkers.jsonchecker import JSONContributorsChecker
</span><ins>+from checkers.jsonchecker import JSONFeaturesChecker
</ins><span class="cx"> from checkers.messagesin import MessagesInChecker
</span><span class="cx"> from checkers.png import PNGChecker
</span><span class="cx"> from checkers.python import PythonChecker
</span><span class="lines">@@ -619,6 +620,8 @@
</span><span class="cx"> basename = os.path.basename(file_path)
</span><span class="cx"> if commit_queue and basename == 'contributors.json':
</span><span class="cx"> checker = JSONContributorsChecker(file_path, handle_style_error)
</span><ins>+ if basename == 'features.json':
+ checker = JSONFeaturesChecker(file_path, handle_style_error)
</ins><span class="cx"> else:
</span><span class="cx"> checker = JSONChecker(file_path, handle_style_error)
</span><span class="cx"> elif file_type == FileType.PYTHON:
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckersjsoncheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py (182133 => 182134)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2015-03-30 04:17:45 UTC (rev 182133)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py 2015-03-30 07:20:43 UTC (rev 182134)
</span><span class="lines">@@ -55,3 +55,26 @@
</span><span class="cx"> def check(self, lines):
</span><span class="cx"> super(JSONContributorsChecker, self).check(lines)
</span><span class="cx"> self._handle_style_error(0, 'json/syntax', 5, 'contributors.json should not be modified through the commit queue')
</span><ins>+
+
+class JSONFeaturesChecker(JSONChecker):
+ """Processes the features.json lines"""
+
+ def check(self, lines):
+ super(JSONFeaturesChecker, self).check(lines)
+
+ try:
+ features_definition = json.loads('\n'.join(lines) + '\n')
+ if 'features' not in features_definition:
+ self._handle_style_error(0, 'json/syntax', 5, '"features" key not found, the key is mandatory.')
+ return
+
+ features_list = features_definition['features']
+ for i in xrange(len(features_list)):
+ feature = features_list[i]
+ if 'name' not in feature:
+ self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "name".' % i)
+ if 'status' not in feature:
+ self._handle_style_error(0, 'json/syntax', 5, 'The feature %d does not have the mandatory field "status".' % i)
+ except:
+ pass
</ins></span></pre>
</div>
</div>
</body>
</html>