<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[182129] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/182129">182129</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-29 20:05:48 -0700 (Sun, 29 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Enable :any-link by default
https://bugs.webkit.org/show_bug.cgi?id=143201
Reviewed by Sam Weinig.
The pseudo class :any-link has been stable for a while. This patch enables
it by default and remove the -webkit- prefix on the default style.
* css/CSSDefaultStyleSheets.cpp:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* css/html.css:
(a:any-link):
(a:any-link:active):
(:any-link img):
(a:-webkit-any-link): Deleted.
(a:-webkit-any-link:active): Deleted.
(:-webkit-any-link img): Deleted.
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSDefaultStyleSheetscpp">trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorcpp">trunk/Source/WebCore/css/CSSSelector.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorh">trunk/Source/WebCore/css/CSSSelector.h</a></li>
<li><a href="#trunkSourceWebCorecssRuleSetcpp">trunk/Source/WebCore/css/RuleSet.cpp</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckercpp">trunk/Source/WebCore/css/SelectorChecker.cpp</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckerh">trunk/Source/WebCore/css/SelectorChecker.h</a></li>
<li><a href="#trunkSourceWebCorecssSelectorPseudoClassAndCompatibilityElementMapin">trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in</a></li>
<li><a href="#trunkSourceWebCorecsshtmlcss">trunk/Source/WebCore/css/html.css</a></li>
<li><a href="#trunkSourceWebCorecssjitSelectorCompilercpp">trunk/Source/WebCore/cssjit/SelectorCompiler.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/ChangeLog 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2015-03-29 Benjamin Poulain <benjamin@webkit.org>
+
+ Enable :any-link by default
+ https://bugs.webkit.org/show_bug.cgi?id=143201
+
+ Reviewed by Sam Weinig.
+
+ The pseudo class :any-link has been stable for a while. This patch enables
+ it by default and remove the -webkit- prefix on the default style.
+
+ * css/CSSDefaultStyleSheets.cpp:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::selectorText):
+ * css/CSSSelector.h:
+ * css/RuleSet.cpp:
+ (WebCore::RuleSet::addRule):
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::checkOne):
+ * css/SelectorChecker.h:
+ (WebCore::SelectorChecker::isCommonPseudoClassSelector):
+ * css/SelectorPseudoClassAndCompatibilityElementMap.in:
+ * css/html.css:
+ (a:any-link):
+ (a:any-link:active):
+ (:any-link img):
+ (a:-webkit-any-link): Deleted.
+ (a:-webkit-any-link:active): Deleted.
+ (:-webkit-any-link img): Deleted.
+ * cssjit/SelectorCompiler.cpp:
+ (WebCore::SelectorCompiler::addPseudoClassType):
+ (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):
+
</ins><span class="cx"> 2015-03-29 Joonghun Park <jh718.park@samsung.com>
</span><span class="cx">
</span><span class="cx"> nullptr cleanup in RenderFooBox classes
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSDefaultStyleSheetscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> StyleSheetContents* CSSDefaultStyleSheets::imageControlsStyleSheet;
</span><span class="cx">
</span><span class="cx"> // FIXME: It would be nice to use some mechanism that guarantees this is in sync with the real UA stylesheet.
</span><del>-static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto 5px -webkit-focus-ring-color}a:-webkit-any-link{color:-webkit-link;text-decoration:underline}a:-webkit-any-link:active{color:-webkit-activelink}";
</del><ins>+static const char* simpleUserAgentStyleSheet = "html,body,div{display:block}head{display:none}body{margin:8px}div:focus,span:focus,a:focus{outline:auto 5px -webkit-focus-ring-color}a:any-link{color:-webkit-link;text-decoration:underline}a:any-link:active{color:-webkit-activelink}";
</ins><span class="cx">
</span><span class="cx"> static inline bool elementCanUseSimpleDefaultStyle(Element& element)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.cpp (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.cpp 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/CSSSelector.cpp 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -419,11 +419,9 @@
</span><span class="cx"> str.append(')');
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> case CSSSelector::PseudoClassAnyLink:
</span><span class="cx"> str.appendLiteral(":any-link");
</span><span class="cx"> break;
</span><del>-#endif
</del><span class="cx"> case CSSSelector::PseudoClassAnyLinkDeprecated:
</span><span class="cx"> str.appendLiteral(":-webkit-any-link");
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.h (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.h 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/CSSSelector.h 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -106,9 +106,7 @@
</span><span class="cx"> PseudoClassLink,
</span><span class="cx"> PseudoClassVisited,
</span><span class="cx"> PseudoClassAny,
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> PseudoClassAnyLink,
</span><del>-#endif
</del><span class="cx"> PseudoClassAnyLinkDeprecated,
</span><span class="cx"> PseudoClassAutofill,
</span><span class="cx"> PseudoClassHover,
</span></span></pre></div>
<a id="trunkSourceWebCorecssRuleSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/RuleSet.cpp (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/RuleSet.cpp 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/RuleSet.cpp 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -246,9 +246,7 @@
</span><span class="cx"> switch (selector->pseudoClassType()) {
</span><span class="cx"> case CSSSelector::PseudoClassLink:
</span><span class="cx"> case CSSSelector::PseudoClassVisited:
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> case CSSSelector::PseudoClassAnyLink:
</span><del>-#endif
</del><span class="cx"> case CSSSelector::PseudoClassAnyLinkDeprecated:
</span><span class="cx"> linkSelector = selector;
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.cpp 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -905,9 +905,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case CSSSelector::PseudoClassAutofill:
</span><span class="cx"> return isAutofilled(element);
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> case CSSSelector::PseudoClassAnyLink:
</span><del>-#endif
</del><span class="cx"> case CSSSelector::PseudoClassAnyLinkDeprecated:
</span><span class="cx"> case CSSSelector::PseudoClassLink:
</span><span class="cx"> // :visited and :link matches are separated later when applying the style. Here both classes match all links...
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.h (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.h 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/SelectorChecker.h 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -122,9 +122,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> CSSSelector::PseudoClassType pseudoType = selector->pseudoClassType();
</span><span class="cx"> return pseudoType == CSSSelector::PseudoClassLink
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> || pseudoType == CSSSelector::PseudoClassAnyLink
</span><del>-#endif
</del><span class="cx"> || pseudoType == CSSSelector::PseudoClassAnyLinkDeprecated
</span><span class="cx"> || pseudoType == CSSSelector::PseudoClassVisited
</span><span class="cx"> || pseudoType == CSSSelector::PseudoClassFocus;
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorPseudoClassAndCompatibilityElementMapin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -6,9 +6,7 @@
</span><span class="cx"> -webkit-full-page-media
</span><span class="cx"> active
</span><span class="cx"> after, PseudoClassUnknown, PseudoElementAfter
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> any-link
</span><del>-#endif
</del><span class="cx"> before, PseudoClassUnknown, PseudoElementBefore
</span><span class="cx"> checked
</span><span class="cx"> corner-present
</span></span></pre></div>
<a id="trunkSourceWebCorecsshtmlcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/html.css (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/html.css 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/css/html.css 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -1121,13 +1121,13 @@
</span><span class="cx"> outline-offset: 0
</span><span class="cx"> }
</span><span class="cx">
</span><del>-a:-webkit-any-link {
</del><ins>+a:any-link {
</ins><span class="cx"> color: -webkit-link;
</span><span class="cx"> text-decoration: underline;
</span><span class="cx"> cursor: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-a:-webkit-any-link:active {
</del><ins>+a:any-link:active {
</ins><span class="cx"> color: -webkit-activelink
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1203,7 +1203,7 @@
</span><span class="cx"> applet, embed, object, img {
</span><span class="cx"> -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
</span><span class="cx"> }
</span><del>-:-webkit-any-link img {
</del><ins>+:any-link img {
</ins><span class="cx"> -webkit-tap-highlight-color: inherit;
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorecssjitSelectorCompilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (182128 => 182129)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2015-03-30 02:27:23 UTC (rev 182128)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2015-03-30 03:05:48 UTC (rev 182129)
</span><span class="lines">@@ -657,15 +657,15 @@
</span><span class="cx"> return FunctionType::CannotCompile;
</span><span class="cx">
</span><span class="cx"> // Optimized pseudo selectors.
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> case CSSSelector::PseudoClassAnyLink:
</span><del>-#endif
- case CSSSelector::PseudoClassAnyLinkDeprecated:
</del><span class="cx"> case CSSSelector::PseudoClassLink:
</span><span class="cx"> case CSSSelector::PseudoClassRoot:
</span><span class="cx"> case CSSSelector::PseudoClassTarget:
</span><span class="cx"> fragment.pseudoClasses.add(type);
</span><span class="cx"> return FunctionType::SimpleSelectorChecker;
</span><ins>+ case CSSSelector::PseudoClassAnyLinkDeprecated:
+ fragment.pseudoClasses.add(CSSSelector::PseudoClassAnyLink);
+ return FunctionType::SimpleSelectorChecker;
</ins><span class="cx">
</span><span class="cx"> case CSSSelector::PseudoClassVisited:
</span><span class="cx"> // Determine this :visited cannot match anything statically.
</span><span class="lines">@@ -2592,10 +2592,8 @@
</span><span class="cx"> void SelectorCodeGenerator::generateElementLinkMatching(Assembler::JumpList& failureCases, const SelectorFragment& fragment)
</span><span class="cx"> {
</span><span class="cx"> if (fragment.pseudoClasses.contains(CSSSelector::PseudoClassLink)
</span><del>-#if ENABLE(CSS_SELECTORS_LEVEL4)
</del><span class="cx"> || fragment.pseudoClasses.contains(CSSSelector::PseudoClassAnyLink)
</span><del>-#endif
- || fragment.pseudoClasses.contains(CSSSelector::PseudoClassVisited) || fragment.pseudoClasses.contains(CSSSelector::PseudoClassAnyLinkDeprecated))
</del><ins>+ || fragment.pseudoClasses.contains(CSSSelector::PseudoClassVisited))
</ins><span class="cx"> generateElementIsLink(failureCases);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>