<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181988] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181988">181988</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2015-03-25 17:53:52 -0700 (Wed, 25 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: table cells that use display:block render the table inaccessible to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=143007
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When display:block is used on a table cell, it was being ignored because it was anonymous.
This is still a valid scenario however if it's still inside of a valid table.
Test: accessibility/table-cell-display-block.html
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
LayoutTests:
* accessibility/table-cell-display-block-expected.txt: Added.
* accessibility/table-cell-display-block.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableCellcpp">trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilitytablecelldisplayblockexpectedtxt">trunk/LayoutTests/accessibility/table-cell-display-block-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitytablecelldisplayblockhtml">trunk/LayoutTests/accessibility/table-cell-display-block.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (181987 => 181988)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-26 00:46:57 UTC (rev 181987)
+++ trunk/LayoutTests/ChangeLog 2015-03-26 00:53:52 UTC (rev 181988)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-03-25 Chris Fleizach <cfleizach@apple.com>
+
+ AX: table cells that use display:block render the table inaccessible to VoiceOver
+ https://bugs.webkit.org/show_bug.cgi?id=143007
+
+ Reviewed by Mario Sanchez Prada.
+
+ * accessibility/table-cell-display-block-expected.txt: Added.
+ * accessibility/table-cell-display-block.html: Added.
+
</ins><span class="cx"> 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a few more tests for Class names
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytablecelldisplayblockexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/table-cell-display-block-expected.txt (0 => 181988)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/table-cell-display-block-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/table-cell-display-block-expected.txt 2015-03-26 00:53:52 UTC (rev 181988)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+This tests that if a table cell uses display:block, the table cell will still be accessible
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS cell1a.isEqual(cell1b) is true
+PASS cell1a.role is 'AXRole: AXCell'
+PASS domCell1.style.display is 'block'
+PASS table2.role is 'AXRole: AXGroup'
+PASS cell2.role is 'AXRole: AXStaticText'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytablecelldisplayblockhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/table-cell-display-block.html (0 => 181988)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/table-cell-display-block.html (rev 0)
+++ trunk/LayoutTests/accessibility/table-cell-display-block.html 2015-03-26 00:53:52 UTC (rev 181988)
</span><span class="lines">@@ -0,0 +1,51 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="content">
+
+<table border=1 id="table1">
+ <tr><td id="cell1" style="display:block;">a1</td><td>b1</td><td>c1</td></tr>
+ <tr><td style="display:block;">a2</td><td>b2</td><td>c2</td></tr>
+</table>
+
+<table border=1 id="table2" role="group">
+ <tr><td id="cell2" style="display:block;">a1</td><td>b1</td><td>c1</td></tr>
+ <tr><td style="display:block;">a2</td><td>b2</td><td>c2</td></tr>
+</table>
+
+</div>
+<p id="description"></p>
+<div id="console"></div>
+<script>
+
+ description("This tests that if a table cell uses display:block, the table cell will still be accessible");
+
+ if (window.accessibilityController) {
+ var table = accessibilityController.accessibleElementById("table1");
+ var cell1a = table.cellForColumnAndRow(0, 0);
+ var cell1b = table.childAtIndex(0).childAtIndex(0);
+
+ shouldBeTrue("cell1a.isEqual(cell1b)");
+ shouldBe("cell1a.role", "'AXRole: AXCell'");
+
+ var domCell1 = document.getElementById("cell1");
+ shouldBe("domCell1.style.display", "'block'");
+
+ // Now check a table that uses a different role to make sure we don't have any cell roles.
+ var table2 = accessibilityController.accessibleElementById("table2");
+ shouldBe("table2.role", "'AXRole: AXGroup'");
+ var cell2 = table2.childAtIndex(0).childAtIndex(0);
+ shouldBe("cell2.role", "'AXRole: AXStaticText'");
+
+ document.getElementById("content").style.visibility = "hidden";
+ }
+
+</script>
+
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181987 => 181988)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-26 00:46:57 UTC (rev 181987)
+++ trunk/Source/WebCore/ChangeLog 2015-03-26 00:53:52 UTC (rev 181988)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-03-25 Chris Fleizach <cfleizach@apple.com>
+
+ AX: table cells that use display:block render the table inaccessible to VoiceOver
+ https://bugs.webkit.org/show_bug.cgi?id=143007
+
+ Reviewed by Mario Sanchez Prada.
+
+ When display:block is used on a table cell, it was being ignored because it was anonymous.
+ This is still a valid scenario however if it's still inside of a valid table.
+
+ Test: accessibility/table-cell-display-block.html
+
+ * accessibility/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
+
</ins><span class="cx"> 2015-03-25 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a preference to prevent "user-scalable=no" from having any effect
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableCellcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp (181987 => 181988)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp 2015-03-26 00:46:57 UTC (rev 181987)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp 2015-03-26 00:53:52 UTC (rev 181988)
</span><span class="lines">@@ -64,8 +64,10 @@
</span><span class="cx"> if (decision == IgnoreObject)
</span><span class="cx"> return true;
</span><span class="cx">
</span><del>- // Ignore anonymous table cells.
- if (!node())
</del><ins>+ // Ignore anonymous table cells as long as they're not in a table (ie. when display:table is used).
+ RenderObject* renderTable = is<RenderTableCell>(m_renderer) ? downcast<RenderTableCell>(*m_renderer).table() : nullptr;
+ bool inTable = renderTable && renderTable->node() && (renderTable->node()->hasTagName(tableTag) || nodeHasRole(renderTable->node(), "grid"));
+ if (!node() && !inTable)
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> if (!isTableCell())
</span></span></pre>
</div>
</div>
</body>
</html>