<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181930] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181930">181930</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-24 21:27:33 -0700 (Tue, 24 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: IndexedDB / Databases ContentViews should have refresh button
https://bugs.webkit.org/show_bug.cgi?id=142996
Reviewed by Timothy Hatcher.
* Localizations/en.lproj/localizedStrings.js:
Remove unused strings.
* UserInterface/Images/ReloadFull.svg: Added.
This is the same as Reload.svg but adjusted to fill the viewbox edge to edge.
The only change is to the viewbox.
* UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.prototype.release):
Some clients would call release not knowing if this was an object or not.
Act gracefully in the case that this was not an object that needs a
remote release.
* UserInterface/Views/DatabaseTableContentView.js:
(WebInspector.DatabaseTableContentView):
(WebInspector.DatabaseTableContentView.prototype.get navigationItems):
(WebInspector.DatabaseTableContentView.prototype._queryError):
(WebInspector.DatabaseTableContentView.prototype._refreshButtonClicked):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._refreshButtonClicked):
Give the storage content views a refresh button to reload the content.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolRemoteObjectjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDatabaseTableContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsIndexedDatabaseObjectStoreContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceImagesReloadFullsvg">trunk/Source/WebInspectorUI/UserInterface/Images/ReloadFull.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (181929 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-25 04:20:30 UTC (rev 181929)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -1,5 +1,37 @@
</span><span class="cx"> 2015-03-24 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: IndexedDB / Databases ContentViews should have refresh button
+ https://bugs.webkit.org/show_bug.cgi?id=142996
+
+ Reviewed by Timothy Hatcher.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ Remove unused strings.
+
+ * UserInterface/Images/ReloadFull.svg: Added.
+ This is the same as Reload.svg but adjusted to fill the viewbox edge to edge.
+ The only change is to the viewbox.
+
+ * UserInterface/Protocol/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.release):
+ Some clients would call release not knowing if this was an object or not.
+ Act gracefully in the case that this was not an object that needs a
+ remote release.
+
+ * UserInterface/Views/DatabaseTableContentView.js:
+ (WebInspector.DatabaseTableContentView):
+ (WebInspector.DatabaseTableContentView.prototype.get navigationItems):
+ (WebInspector.DatabaseTableContentView.prototype._queryError):
+ (WebInspector.DatabaseTableContentView.prototype._refreshButtonClicked):
+ * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
+ (WebInspector.IndexedDatabaseObjectStoreContentView):
+ (WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
+ (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
+ (WebInspector.IndexedDatabaseObjectStoreContentView.prototype._refreshButtonClicked):
+ Give the storage content views a refresh button to reload the content.
+
+2015-03-24 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Setter should have a single formal parameter, Getter no parameters
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142903
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (181929 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-03-25 04:20:30 UTC (rev 181929)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -77,7 +77,6 @@
</span><span class="cx"> localizedStrings["Begin Capturing"] = "Begin Capturing";
</span><span class="cx"> localizedStrings["Boundary"] = "Boundary";
</span><span class="cx"> localizedStrings["Box Model"] = "Box Model";
</span><del>-localizedStrings["Breakpoints"] = "Breakpoints";
</del><span class="cx"> localizedStrings["Bubbling"] = "Bubbling";
</span><span class="cx"> localizedStrings["Busy"] = "Busy";
</span><span class="cx"> localizedStrings["Cached"] = "Cached";
</span><span class="lines">@@ -193,7 +192,6 @@
</span><span class="cx"> localizedStrings["Element is masked and composited descendants"] = "Element is masked and composited descendants";
</span><span class="cx"> localizedStrings["Element is the root element"] = "Element is the root element";
</span><span class="cx"> localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
</span><del>-localizedStrings["Empty Collection"] = "Empty Collection";
</del><span class="cx"> localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
</span><span class="cx"> localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";
</span><span class="cx"> localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceImagesReloadFullsvg"></a>
<div class="addfile"><h4>Added: trunk/Source/WebInspectorUI/UserInterface/Images/ReloadFull.svg (0 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Images/ReloadFull.svg (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/ReloadFull.svg 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright © 2014 Apple Inc. All rights reserved. -->
+<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="1 1 13 13">
+ <path class="filled" d="M 12.007 8.01 L 12.007 8.488 L 12 8.488 C 12 10.974 9.985 12.988 7.5 12.988 C 5.015 12.988 3 10.974 3 8.488 C 3 6.17 4.759 4.284 7.012 4.037 L 7.012 6.549 L 11.519 3.775 L 7.012 1 L 7.012 3.013 C 4.203 3.26 2 5.615 2 8.488 C 2 11.526 4.462 13.988 7.5 13.988 C 10.509 13.988 12.95 11.571 12.996 8.572 L 13 8.572 L 13 8.01 L 12.007 8.01 Z"/>
+</svg>
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolRemoteObjectjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js (181929 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2015-03-25 04:20:30 UTC (rev 181929)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -502,7 +502,8 @@
</span><span class="cx">
</span><span class="cx"> release: function()
</span><span class="cx"> {
</span><del>- RuntimeAgent.releaseObject(this._objectId);
</del><ins>+ if (this._objectId)
+ RuntimeAgent.releaseObject(this._objectId);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> arrayLength: function()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDatabaseTableContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js (181929 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js 2015-03-25 04:20:30 UTC (rev 181929)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -29,6 +29,18 @@
</span><span class="cx">
</span><span class="cx"> this.element.classList.add(WebInspector.DatabaseTableContentView.StyleClassName);
</span><span class="cx">
</span><ins>+ var refreshSource, refreshSize;
+ if (WebInspector.Platform.isLegacyMacOS) {
+ refreshSource = "Images/Legacy/Reload.svg";
+ refreshSize = 16;
+ } else {
+ refreshSource = "Images/ReloadFull.svg";
+ refreshSize = 13;
+ }
+
+ this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("database-table-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize);
+ this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this);
+
</ins><span class="cx"> this.update();
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -36,9 +48,15 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.DatabaseTableContentView.prototype = {
</span><span class="cx"> constructor: WebInspector.DatabaseTableContentView,
</span><ins>+ __proto__: WebInspector.ContentView.prototype,
</ins><span class="cx">
</span><span class="cx"> // Public
</span><span class="cx">
</span><ins>+ get navigationItems()
+ {
+ return [this._refreshButtonNavigationItem];
+ },
+
</ins><span class="cx"> get allowedNavigationSidebarPanels()
</span><span class="cx"> {
</span><span class="cx"> return [WebInspector.resourceSidebarPanel.identifier];
</span><span class="lines">@@ -101,7 +119,10 @@
</span><span class="cx"> {
</span><span class="cx"> this.element.removeChildren();
</span><span class="cx"> this.element.appendChild(WebInspector.createMessageTextView(WebInspector.UIString("An error occured trying to\nread the “%s” table.").format(this.representedObject.name), true));
</span><ins>+ },
+
+ _refreshButtonClicked: function()
+ {
+ this.update();
</ins><span class="cx"> }
</span><span class="cx"> };
</span><del>-
-WebInspector.DatabaseTableContentView.prototype.__proto__ = WebInspector.ContentView.prototype;
</del></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsIndexedDatabaseObjectStoreContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js (181929 => 181930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js 2015-03-25 04:20:30 UTC (rev 181929)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.js 2015-03-25 04:27:33 UTC (rev 181930)
</span><span class="lines">@@ -66,13 +66,24 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._dataGrid = new WebInspector.DataGrid(columnInfo);
</span><ins>+ this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this));
</ins><span class="cx"> this.element.appendChild(this._dataGrid.element);
</span><span class="cx">
</span><del>- this._dataGrid.scrollContainer.addEventListener("scroll", this._dataGridScrolled.bind(this));
-
</del><span class="cx"> this._entries = [];
</span><span class="cx">
</span><span class="cx"> this._fetchMoreData();
</span><ins>+
+ var refreshSource, refreshSize;
+ if (WebInspector.Platform.isLegacyMacOS) {
+ refreshSource = "Images/Legacy/Reload.svg";
+ refreshSize = 16;
+ } else {
+ refreshSource = "Images/ReloadFull.svg";
+ refreshSize = 13;
+ }
+
+ this._refreshButtonNavigationItem = new WebInspector.ButtonNavigationItem("indexed-database-object-store-refresh", WebInspector.UIString("Refresh"), refreshSource, refreshSize, refreshSize);
+ this._refreshButtonNavigationItem.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, this._refreshButtonClicked, this);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WebInspector.IndexedDatabaseObjectStoreContentView.StyleClassName = "indexed-database-object-store";
</span><span class="lines">@@ -83,6 +94,11 @@
</span><span class="cx">
</span><span class="cx"> // Public
</span><span class="cx">
</span><ins>+ get navigationItems()
+ {
+ return [this._refreshButtonNavigationItem];
+ },
+
</ins><span class="cx"> closed: function()
</span><span class="cx"> {
</span><span class="cx"> this._reset();
</span><span class="lines">@@ -148,5 +164,11 @@
</span><span class="cx"> this._fetchingMoreData = true;
</span><span class="cx">
</span><span class="cx"> WebInspector.storageManager.requestIndexedDatabaseData(this._objectStore, this._objectStoreIndex, this._entries.length, 25, processEntries.bind(this));
</span><ins>+ },
+
+ _refreshButtonClicked: function()
+ {
+ this._reset();
+ this._fetchMoreData();
</ins><span class="cx"> }
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>