<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181900] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181900">181900</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-24 12:56:34 -0700 (Tue, 24 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>CSS Selectors Level 4: enable case-insensitive attribute matching by default
https://bugs.webkit.org/show_bug.cgi?id=142960
Reviewed by Andreas Kling.
Source/WebCore:
All open issues have been resolved, enable the feature by default.
Test: fast/css/attribute-selector-case-insensitive.html
* css/CSSGrammar.y.in:
LayoutTests:
This test is imported from blink. That's the only test
they have for this feature.
* fast/css/attribute-selector-case-insensitive-expected.txt: Added.
* fast/css/attribute-selector-case-insensitive.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSGrammaryin">trunk/Source/WebCore/css/CSSGrammar.y.in</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssattributeselectorcaseinsensitiveexpectedtxt">trunk/LayoutTests/fast/css/attribute-selector-case-insensitive-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssattributeselectorcaseinsensitivehtml">trunk/LayoutTests/fast/css/attribute-selector-case-insensitive.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (181899 => 181900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-24 19:53:17 UTC (rev 181899)
+++ trunk/LayoutTests/ChangeLog 2015-03-24 19:56:34 UTC (rev 181900)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-03-24 Benjamin Poulain <benjamin@webkit.org>
+
+ CSS Selectors Level 4: enable case-insensitive attribute matching by default
+ https://bugs.webkit.org/show_bug.cgi?id=142960
+
+ Reviewed by Andreas Kling.
+
+ This test is imported from blink. That's the only test
+ they have for this feature.
+
+ * fast/css/attribute-selector-case-insensitive-expected.txt: Added.
+ * fast/css/attribute-selector-case-insensitive.html: Added.
+
</ins><span class="cx"> 2015-03-24 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Stop image from displaying when src attribute is removed or emptied
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssattributeselectorcaseinsensitiveexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/attribute-selector-case-insensitive-expected.txt (0 => 181900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/attribute-selector-case-insensitive-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/attribute-selector-case-insensitive-expected.txt 2015-03-24 19:56:34 UTC (rev 181900)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+Testing exact attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+Testing list attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+Testing hyphen attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+Testing begin attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+Testing end attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+Testing contains attribute selector.
+PASS window.getComputedStyle(element).borderTopColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderRightColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderBottomColor is 'rgb(0, 128, 0)'
+PASS window.getComputedStyle(element).borderLeftColor is 'rgb(0, 128, 0)'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS if all elements borders are all green, not red.
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssattributeselectorcaseinsensitivehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/attribute-selector-case-insensitive.html (0 => 181900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/attribute-selector-case-insensitive.html (rev 0)
+++ trunk/LayoutTests/fast/css/attribute-selector-case-insensitive.html 2015-03-24 19:56:34 UTC (rev 181900)
</span><span class="lines">@@ -0,0 +1,50 @@
</span><ins>+<!DOCTYPE html>
+
+<style type="text/css">
+ div { border: 2px solid red; }
+ div[attr1="LOWER"] { border-top-color: yellow }
+ div[attr1="lower"] { border-top-color: green }
+ div[attr2="upper"] { border-right-color: yellow }
+ div[attr2="UPPER"] { border-right-color: green }
+ div[attr3="lower" i] { border-bottom-color: green }
+ div[attr4="UPPER" i] { border-left-color: green }
+
+ div[attr-list~="BaR" i] { border: 2px solid green; }
+ div[attr-hyphen|="FoO" i] { border: 2px solid green; }
+ div[attr-begin^="FoO" i] { border: 2px solid green; }
+ div[attr-end$="BaR" i] { border: 2px solid green; }
+ div[attr-contain*="OoB" i] { border: 2px solid green; }
+</style>
+
+<div id="element-exact" attr1="lower" attr2="UPPER" attr3="LOWER" attr4="upper"></div>
+<div id="element-list" attr-list="foo bar"></div>
+<div id="element-hyphen" attr-hyphen="foo-bar"></div>
+<div id="element-begin" attr-begin="foobar"></div>
+<div id="element-end" attr-end="foobar"></div>
+<div id="element-contains" attr-end="foobar"></div>
+
+<p>
+ PASS if all elements borders are all green, not red.
+</p>
+
+<script src="../../resources/js-test.js"></script>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function checkBorders(elementId) {
+ debug("Testing " + elementId.split('-')[1] + " attribute selector.");
+ element = document.getElementById(elementId);
+ shouldBe("window.getComputedStyle(element).borderTopColor", "'rgb(0, 128, 0)'");
+ shouldBe("window.getComputedStyle(element).borderRightColor", "'rgb(0, 128, 0)'");
+ shouldBe("window.getComputedStyle(element).borderBottomColor", "'rgb(0, 128, 0)'");
+ shouldBe("window.getComputedStyle(element).borderLeftColor", "'rgb(0, 128, 0)'");
+ }
+
+ checkBorders("element-exact");
+ checkBorders("element-list");
+ checkBorders("element-hyphen");
+ checkBorders("element-begin");
+ checkBorders("element-end");
+ checkBorders("element-contains");
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181899 => 181900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-24 19:53:17 UTC (rev 181899)
+++ trunk/Source/WebCore/ChangeLog 2015-03-24 19:56:34 UTC (rev 181900)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-03-24 Benjamin Poulain <benjamin@webkit.org>
+
+ CSS Selectors Level 4: enable case-insensitive attribute matching by default
+ https://bugs.webkit.org/show_bug.cgi?id=142960
+
+ Reviewed by Andreas Kling.
+
+ All open issues have been resolved, enable the feature by default.
+
+ Test: fast/css/attribute-selector-case-insensitive.html
+
+ * css/CSSGrammar.y.in:
+
</ins><span class="cx"> 2015-03-24 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> MediaControls: Scrubber and Time displays have the incorrect blending
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGrammaryin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (181899 => 181900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGrammar.y.in 2015-03-24 19:53:17 UTC (rev 181899)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2015-03-24 19:56:34 UTC (rev 181900)
</span><span class="lines">@@ -1277,14 +1277,12 @@
</span><span class="cx"> ;
</span><span class="cx">
</span><span class="cx"> attrib_flags:
</span><del>-#if ENABLE_CSS_SELECTORS_LEVEL4
</del><span class="cx"> IDENT maybe_space {
</span><span class="cx"> if (UNLIKELY($1.length() != 1 || !isASCIIAlphaCaselessEqual($1[0], 'i')))
</span><span class="cx"> YYERROR;
</span><span class="cx"> $$ = true;
</span><span class="cx"> }
</span><span class="cx"> |
</span><del>-#endif
</del><span class="cx"> /* empty */ {
</span><span class="cx"> $$ = false;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>