<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181880] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181880">181880</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2015-03-23 15:56:58 -0700 (Mon, 23 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Regression(<a href="http://trac.webkit.org/projects/webkit/changeset/181257">r181257</a>): WTF_WorkQueue.Simple is flaky
https://bugs.webkit.org/show_bug.cgi?id=142560
Remove the check that the refCount has returned to one after the
individual tasks have completed. It's too nondeterministic when
the reference count will be reduced.
Reviewed by Alexey Proskuryakov
* TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST): Remove test that refCount is back to 1.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFWorkQueuecpp">trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (181879 => 181880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-03-23 22:52:27 UTC (rev 181879)
+++ trunk/Tools/ChangeLog 2015-03-23 22:56:58 UTC (rev 181880)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-03-23 Brent Fulgham <bfulgham@apple.com>
+
+ Regression(r181257): WTF_WorkQueue.Simple is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=142560
+
+ Remove the check that the refCount has returned to one after the
+ individual tasks have completed. It's too nondeterministic when
+ the reference count will be reduced.
+
+ Reviewed by Alexey Proskuryakov
+
+ * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
+ (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
+
</ins><span class="cx"> 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> [CMake][EFL] Put failure API test excutables into failure directory
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFWorkQueuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp (181879 => 181880)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp 2015-03-23 22:52:27 UTC (rev 181879)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp 2015-03-23 22:56:58 UTC (rev 181880)
</span><span class="lines">@@ -87,7 +87,6 @@
</span><span class="cx"> EXPECT_TRUE(calledSimpleTest);
</span><span class="cx"> EXPECT_TRUE(calledLongTest);
</span><span class="cx"> EXPECT_TRUE(calledThirdTest);
</span><del>- EXPECT_EQ(1, queue->refCount());
</del><span class="cx">
</span><span class="cx"> EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
</span><span class="cx"> EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());
</span><span class="lines">@@ -108,10 +107,8 @@
</span><span class="cx"> auto queue1 = WorkQueue::create("com.apple.WebKit.Test.twoQueues1");
</span><span class="cx"> auto queue2 = WorkQueue::create("com.apple.WebKit.Test.twoQueues2");
</span><span class="cx">
</span><del>- int initialQueue1RefCount = queue1->refCount();
- int initialQueue2RefCount = queue2->refCount();
- EXPECT_EQ(1, initialQueue1RefCount);
- EXPECT_EQ(1, initialQueue2RefCount);
</del><ins>+ EXPECT_EQ(1, queue1->refCount());
+ EXPECT_EQ(1, queue2->refCount());
</ins><span class="cx">
</span><span class="cx"> MutexLocker locker(m_lock);
</span><span class="cx">
</span><span class="lines">@@ -146,14 +143,12 @@
</span><span class="cx"> EXPECT_TRUE(calledSimpleTest);
</span><span class="cx"> EXPECT_FALSE(calledLongTest);
</span><span class="cx"> EXPECT_TRUE(calledThirdTest);
</span><del>- EXPECT_EQ(1, queue1->refCount());
</del><span class="cx">
</span><span class="cx"> m_testQueue2Completed.wait(m_lock);
</span><span class="cx">
</span><span class="cx"> EXPECT_TRUE(calledSimpleTest);
</span><span class="cx"> EXPECT_TRUE(calledLongTest);
</span><span class="cx"> EXPECT_TRUE(calledThirdTest);
</span><del>- EXPECT_EQ(1, queue2->refCount());
</del><span class="cx">
</span><span class="cx"> EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
</span><span class="cx"> EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());
</span></span></pre>
</div>
</div>
</body>
</html>