<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181836] trunk/Source/WebKit2</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181836">181836</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2015-03-22 14:44:50 -0700 (Sun, 22 Mar 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS] Expose WebPageProxy::setInitialFocus as SPI
https://bugs.webkit.org/show_bug.cgi?id=142951

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]): New SPI.
Just calls through to WKWebContentView, but allows a nil completion handler.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

* UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]): Pass an empty lambda for the new callback parameter to
WebPageProxy::setInitialFocus.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setInitialFocus): Added a void callback parameter and made sure to
call it.
* UIProcess/WebPageProxy.h:

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
Added. Calls WebPageProxy::setInitialFocus, and once that completes, checks if anything was
focused and if so, becomes first responder, then calls the completion handler.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInitialFocus): Added a callbackID parameter, and made sure to send the
callback message. Added a temporary change of m_userIsInteracting to true, so that the UI
process won’t ignore any StartAssistingNode message resulting from the focus change.
* WebProcess/WebPage/WebPage.h:

* WebProcess/WebPage/WebPage.messages.in: Added a callbackID parameter to SetInitialFocus.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKWebViewmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKWebViewPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPImacWKViewmm">trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWKContentViewInteractionh">trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm">trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPageh">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagemessagesin">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/ChangeLog        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2015-03-22  Dan Bernstein  &lt;mitz@apple.com&gt;
+
+        [iOS] Expose WebPageProxy::setInitialFocus as SPI
+        https://bugs.webkit.org/show_bug.cgi?id=142951
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]): New SPI.
+        Just calls through to WKWebContentView, but allows a nil completion handler.
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView becomeFirstResponder]): Pass an empty lambda for the new callback parameter to
+        WebPageProxy::setInitialFocus.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::setInitialFocus): Added a void callback parameter and made sure to
+        call it.
+        * UIProcess/WebPageProxy.h:
+
+        * UIProcess/ios/WKContentViewInteraction.h:
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
+        Added. Calls WebPageProxy::setInitialFocus, and once that completes, checks if anything was
+        focused and if so, becomes first responder, then calls the completion handler.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setInitialFocus): Added a callbackID parameter, and made sure to send the
+        callback message. Added a temporary change of m_userIsInteracting to true, so that the UI
+        process won’t ignore any StartAssistingNode message resulting from the focus change.
+        * WebProcess/WebPage/WebPage.h:
+
+        * WebProcess/WebPage/WebPage.messages.in: Added a callbackID parameter to SetInitialFocus.
+
</ins><span class="cx"> 2015-03-21  Dean Jackson  &lt;dino@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Remove the prefix for CSS Transforms
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -90,6 +90,7 @@
</span><span class="cx"> #import &quot;RemoteLayerTreeDrawingAreaProxy.h&quot;
</span><span class="cx"> #import &quot;RemoteScrollingCoordinatorProxy.h&quot;
</span><span class="cx"> #import &quot;UIKitSPI.h&quot;
</span><ins>+#import &quot;WKContentViewInteraction.h&quot;
</ins><span class="cx"> #import &quot;WKPDFView.h&quot;
</span><span class="cx"> #import &quot;WKScrollView.h&quot;
</span><span class="cx"> #import &quot;WKWebViewContentProviderRegistry.h&quot;
</span><span class="lines">@@ -1786,6 +1787,21 @@
</span><span class="cx">     } copy] autorelease];
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler
+{
+    typeof(completionHandler) completionHandlerCopy = nil;
+    if (completionHandler)
+        completionHandlerCopy = Block_copy(completionHandler);
+
+    [_contentView _becomeFirstResponderWithSelectionMovingForward:selectingForward completionHandler:[completionHandlerCopy](BOOL didBecomeFirstResponder) {
+        if (!completionHandlerCopy)
+            return;
+
+        completionHandlerCopy(didBecomeFirstResponder);
+        Block_release(completionHandlerCopy);
+    }];
+}
+
</ins><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> - (void)_didRelaunchProcess
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKWebViewPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -155,6 +155,8 @@
</span><span class="cx"> // will not count as becoming inactive and unfocused. The returned block must be called to exit the state.
</span><span class="cx"> - (void (^)(void))_retainActiveFocusedState WK_AVAILABLE(NA, WK_IOS_TBA);
</span><span class="cx"> 
</span><ins>+- (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler WK_AVAILABLE(NA, WK_IOS_TBA);
+
</ins><span class="cx"> #else
</span><span class="cx"> @property (readonly) NSColor *_pageExtendedBackgroundColor;
</span><span class="cx"> @property (nonatomic, setter=_setDrawsTransparentBackground:) BOOL _drawsTransparentBackground;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -401,7 +401,7 @@
</span><span class="cx">         NSEvent *keyboardEvent = nil;
</span><span class="cx">         if ([event type] == NSKeyDown || [event type] == NSKeyUp)
</span><span class="cx">             keyboardEvent = event;
</span><del>-        _data-&gt;_page-&gt;setInitialFocus(direction == NSSelectingNext, keyboardEvent != nil, NativeWebKeyboardEvent(keyboardEvent, false, Vector&lt;KeypressCommand&gt;()));
</del><ins>+        _data-&gt;_page-&gt;setInitialFocus(direction == NSSelectingNext, keyboardEvent != nil, NativeWebKeyboardEvent(keyboardEvent, false, Vector&lt;KeypressCommand&gt;()), [](CallbackBase::Error) { });
</ins><span class="cx">     }
</span><span class="cx">     return YES;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -1419,11 +1419,15 @@
</span><span class="cx">     return m_pageClient.viewSize();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void WebPageProxy::setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp; keyboardEvent)
</del><ins>+void WebPageProxy::setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp; keyboardEvent, std::function&lt;void (CallbackBase::Error)&gt; callbackFunction)
</ins><span class="cx"> {
</span><del>-    if (!isValid())
</del><ins>+    if (!isValid()) {
+        callbackFunction(CallbackBase::Error::OwnerWasInvalidated);
</ins><span class="cx">         return;
</span><del>-    m_process-&gt;send(Messages::WebPage::SetInitialFocus(forward, isKeyboardEventValid, keyboardEvent), m_pageID);
</del><ins>+    }
+
+    uint64_t callbackID = m_callbacks.put(WTF::move(callbackFunction), m_process-&gt;throttler().backgroundActivityToken());
+    m_process-&gt;send(Messages::WebPage::SetInitialFocus(forward, isKeyboardEventValid, keyboardEvent, callbackID), m_pageID);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void WebPageProxy::setWindowResizerSize(const IntSize&amp; windowResizerSize)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -389,7 +389,7 @@
</span><span class="cx">     void viewWillStartLiveResize();
</span><span class="cx">     void viewWillEndLiveResize();
</span><span class="cx"> 
</span><del>-    void setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp;);
</del><ins>+    void setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp;, std::function&lt;void (CallbackBase::Error)&gt;);
</ins><span class="cx">     void setWindowResizerSize(const WebCore::IntSize&amp;);
</span><span class="cx">     
</span><span class="cx">     void clearSelection();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWKContentViewInteractionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -196,6 +196,7 @@
</span><span class="cx"> - (Vector&lt;WebKit::OptionItem&gt;&amp;) assistedNodeSelectOptions;
</span><span class="cx"> - (void)_enableInspectorNodeSearch;
</span><span class="cx"> - (void)_disableInspectorNodeSearch;
</span><ins>+- (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler;
</ins><span class="cx"> @end
</span><span class="cx"> 
</span><span class="cx"> #endif // PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -2053,6 +2053,16 @@
</span><span class="cx"> 
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler
+{
+    auto completionHandlerCopy = Block_copy(completionHandler);
+    _page-&gt;setInitialFocus(selectingForward, false, WebKit::WebKeyboardEvent(), [self, completionHandlerCopy](WebKit::CallbackBase::Error) {
+        BOOL didBecomeFirstResponder = _assistedNodeInformation.elementType != InputType::None &amp;&amp; [self becomeFirstResponder];
+        completionHandlerCopy(didBecomeFirstResponder);
+        Block_release(completionHandlerCopy);
+    });
+}
+
</ins><span class="cx"> - (void)accessoryAutoFill
</span><span class="cx"> {
</span><span class="cx">     id &lt;_WKFormDelegate&gt; formDelegate = [_webView _formDelegate];
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -167,6 +167,7 @@
</span><span class="cx"> #include &lt;runtime/JSCJSValue.h&gt;
</span><span class="cx"> #include &lt;runtime/JSLock.h&gt;
</span><span class="cx"> #include &lt;wtf/RunLoop.h&gt;
</span><ins>+#include &lt;wtf/TemporaryChange.h&gt;
</ins><span class="cx"> 
</span><span class="cx"> #if ENABLE(MHTML)
</span><span class="cx"> #include &lt;WebCore/MHTMLArchive.h&gt;
</span><span class="lines">@@ -2207,11 +2208,15 @@
</span><span class="cx">         view-&gt;willEndLiveResize();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void WebPage::setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp; event)
</del><ins>+void WebPage::setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp; event, uint64_t callbackID)
</ins><span class="cx"> {
</span><span class="cx">     if (!m_page)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><ins>+#if PLATFORM(IOS)
+    TemporaryChange&lt;bool&gt; userIsInteractingChange { m_userIsInteracting, true };
+#endif
+
</ins><span class="cx">     Frame&amp; frame = m_page-&gt;focusController().focusedOrMainFrame();
</span><span class="cx">     frame.document()-&gt;setFocusedElement(0);
</span><span class="cx"> 
</span><span class="lines">@@ -2219,10 +2224,13 @@
</span><span class="cx">         PlatformKeyboardEvent platformEvent(platform(event));
</span><span class="cx">         platformEvent.disambiguateKeyDownEvent(PlatformEvent::RawKeyDown);
</span><span class="cx">         m_page-&gt;focusController().setInitialFocus(forward ? FocusDirectionForward : FocusDirectionBackward, &amp;KeyboardEvent::create(platformEvent, frame.document()-&gt;defaultView()).get());
</span><ins>+
+        send(Messages::WebPageProxy::VoidCallback(callbackID));
</ins><span class="cx">         return;
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     m_page-&gt;focusController().setInitialFocus(forward ? FocusDirectionForward : FocusDirectionBackward, 0);
</span><ins>+    send(Messages::WebPageProxy::VoidCallback(callbackID));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void WebPage::setWindowResizerSize(const IntSize&amp; windowResizerSize)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -928,7 +928,7 @@
</span><span class="cx">     void goBack(uint64_t navigationID, uint64_t);
</span><span class="cx">     void goToBackForwardItem(uint64_t navigationID, uint64_t);
</span><span class="cx">     void tryRestoreScrollPosition();
</span><del>-    void setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp;);
</del><ins>+    void setInitialFocus(bool forward, bool isKeyboardEventValid, const WebKeyboardEvent&amp;, uint64_t callbackID);
</ins><span class="cx">     void setWindowResizerSize(const WebCore::IntSize&amp;);
</span><span class="cx">     void updateIsInWindow(bool isInitialState = false);
</span><span class="cx">     void setViewState(WebCore::ViewState::Flags, bool wantsDidUpdateViewState, const Vector&lt;uint64_t&gt;&amp; callbackIDs);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagemessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in (181835 => 181836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in        2015-03-22 19:35:26 UTC (rev 181835)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in        2015-03-22 21:44:50 UTC (rev 181836)
</span><span class="lines">@@ -21,7 +21,7 @@
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> 
</span><span class="cx"> messages -&gt; WebPage LegacyReceiver {
</span><del>-    SetInitialFocus(bool forward, bool isKeyboardEventValid, WebKit::WebKeyboardEvent event)
</del><ins>+    SetInitialFocus(bool forward, bool isKeyboardEventValid, WebKit::WebKeyboardEvent event, uint64_t callbackID)
</ins><span class="cx">     SetViewState(unsigned viewState, bool wantsDidUpdateViewState, Vector&lt;uint64_t&gt; callbackIDs)
</span><span class="cx">     SetLayerHostingMode(unsigned layerHostingMode)
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>