<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181766] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181766">181766</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-03-19 16:26:08 -0700 (Thu, 19 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of "CachePolicyCache" cache policy
https://bugs.webkit.org/show_bug.cgi?id=142881
Reviewed by Antti Koivisto.
Get rid of "CachePolicyCache" cache policy as it is unused.
* loader/cache/CachePolicy.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey): Deleted.
* page/DiagnosticLoggingKeys.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachePolicyh">trunk/Source/WebCore/loader/cache/CachePolicy.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourcecpp">trunk/Source/WebCore/loader/cache/CachedResource.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDiagnosticLoggingKeyscpp">trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDiagnosticLoggingKeysh">trunk/Source/WebCore/page/DiagnosticLoggingKeys.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181765 => 181766)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-19 23:01:14 UTC (rev 181765)
+++ trunk/Source/WebCore/ChangeLog 2015-03-19 23:26:08 UTC (rev 181766)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-03-19 Chris Dumez <cdumez@apple.com>
+
+ Get rid of "CachePolicyCache" cache policy
+ https://bugs.webkit.org/show_bug.cgi?id=142881
+
+ Reviewed by Antti Koivisto.
+
+ Get rid of "CachePolicyCache" cache policy as it is unused.
+
+ * loader/cache/CachePolicy.h:
+ * loader/cache/CachedResource.cpp:
+ (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
+ * page/DiagnosticLoggingKeys.cpp:
+ (WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey): Deleted.
+ * page/DiagnosticLoggingKeys.h:
+
</ins><span class="cx"> 2015-03-19 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> [Content Extensions] Test regular expression parse failures.
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachePolicyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachePolicy.h (181765 => 181766)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachePolicy.h 2015-03-19 23:01:14 UTC (rev 181765)
+++ trunk/Source/WebCore/loader/cache/CachePolicy.h 2015-03-19 23:26:08 UTC (rev 181766)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> enum CachePolicy {
</span><del>- CachePolicyCache,
</del><span class="cx"> CachePolicyVerify,
</span><span class="cx"> CachePolicyRevalidate,
</span><span class="cx"> CachePolicyReload,
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (181765 => 181766)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2015-03-19 23:01:14 UTC (rev 181765)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2015-03-19 23:26:08 UTC (rev 181766)
</span><span class="lines">@@ -688,7 +688,7 @@
</span><span class="cx">
</span><span class="cx"> bool CachedResource::mustRevalidateDueToCacheHeaders(const CachedResourceLoader& cachedResourceLoader, CachePolicy cachePolicy) const
</span><span class="cx"> {
</span><del>- ASSERT(cachePolicy == CachePolicyRevalidate || cachePolicy == CachePolicyCache || cachePolicy == CachePolicyVerify);
</del><ins>+ ASSERT(cachePolicy == CachePolicyRevalidate || cachePolicy == CachePolicyVerify);
</ins><span class="cx">
</span><span class="cx"> if (cachePolicy == CachePolicyRevalidate) {
</span><span class="cx"> logResourceRevalidationReason(cachedResourceLoader.frame(), DiagnosticLoggingKeys::reloadKey());
</span><span class="lines">@@ -705,15 +705,6 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (cachePolicy == CachePolicyCache) {
- if (m_response.cacheControlContainsMustRevalidate() && isExpired()) {
- LOG(ResourceLoading, "CachedResource %p mustRevalidate because of cachePolicy == CachePolicyCache and m_response.cacheControlContainsMustRevalidate() && isExpired()\n", this);
- logResourceRevalidationReason(cachedResourceLoader.frame(), DiagnosticLoggingKeys::mustRevalidateIsExpiredKey());
- return true;
- }
- return false;
- }
-
</del><span class="cx"> // CachePolicyVerify
</span><span class="cx"> if (isExpired()) {
</span><span class="cx"> LOG(ResourceLoading, "CachedResource %p mustRevalidate because of isExpired()\n", this);
</span></span></pre></div>
<a id="trunkSourceWebCorepageDiagnosticLoggingKeyscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp (181765 => 181766)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-03-19 23:01:14 UTC (rev 181765)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2015-03-19 23:26:08 UTC (rev 181766)
</span><span class="lines">@@ -43,11 +43,6 @@
</span><span class="cx"> return ASCIILiteral("missingValidatorFields");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-String DiagnosticLoggingKeys::mustRevalidateIsExpiredKey()
-{
- return ASCIILiteral("mustRevalidateIsExpired");
-}
-
</del><span class="cx"> String DiagnosticLoggingKeys::pluginLoadedKey()
</span><span class="cx"> {
</span><span class="cx"> return ASCIILiteral("pluginLoaded");
</span></span></pre></div>
<a id="trunkSourceWebCorepageDiagnosticLoggingKeysh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DiagnosticLoggingKeys.h (181765 => 181766)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-03-19 23:01:14 UTC (rev 181765)
+++ trunk/Source/WebCore/page/DiagnosticLoggingKeys.h 2015-03-19 23:26:08 UTC (rev 181766)
</span><span class="lines">@@ -65,7 +65,6 @@
</span><span class="cx"> static String mediaLoadedKey();
</span><span class="cx"> static String mediaLoadingFailedKey();
</span><span class="cx"> WEBCORE_EXPORT static String missingValidatorFieldsKey();
</span><del>- static String mustRevalidateIsExpiredKey();
</del><span class="cx"> static String navigationKey();
</span><span class="cx"> WEBCORE_EXPORT static String networkCacheKey();
</span><span class="cx"> static String networkKey();
</span></span></pre>
</div>
</div>
</body>
</html>