<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181768] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181768">181768</a></dd>
<dt>Author</dt> <dd>jonowells@apple.com</dd>
<dt>Date</dt> <dd>2015-03-19 16:52:13 -0700 (Thu, 19 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause
https://bugs.webkit.org/show_bug.cgi?id=142847
Reviewed by Timothy Hatcher.
Add a `paused` class on the debugger sidebar panel. Use that class to adjust the sidebar styles so that, when
the debugger is not paused: there is no header for the scripts section, there is no border beneath the scripts
section, and the scripts section cannot be collapsed (which could be done while the debugger is paused). The
header has changed to say "Scripts" instead of "Breakpoints" when it is showing.
* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger .details-section.scripts):
(.sidebar > .panel.navigation.debugger .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content):
Adjust styles to hide header and border.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
Add a `paused` class to the debugger sidebar when it is paused.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDebuggerSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDebuggerSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (181767 => 181768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-19 23:52:13 UTC (rev 181768)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2015-03-19 Jono Wells <jonowells@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause
+ https://bugs.webkit.org/show_bug.cgi?id=142847
+
+ Reviewed by Timothy Hatcher.
+
+ Add a `paused` class on the debugger sidebar panel. Use that class to adjust the sidebar styles so that, when
+ the debugger is not paused: there is no header for the scripts section, there is no border beneath the scripts
+ section, and the scripts section cannot be collapsed (which could be done while the debugger is paused). The
+ header has changed to say "Scripts" instead of "Breakpoints" when it is showing.
+
+ * UserInterface/Views/DebuggerSidebarPanel.css:
+ (.sidebar > .panel.navigation.debugger .details-section.scripts):
+ (.sidebar > .panel.navigation.debugger .details-section.scripts .header):
+ (.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content):
+ Adjust styles to hide header and border.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WebInspector.DebuggerSidebarPanel):
+ (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
+ (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
+ Add a `paused` class to the debugger sidebar when it is paused.
+
+2015-03-19 Jono Wells <jonowells@apple.com>
+
</ins><span class="cx"> Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142777
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDebuggerSidebarPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css (181767 => 181768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2015-03-19 23:52:13 UTC (rev 181768)
</span><span class="lines">@@ -41,3 +41,27 @@
</span><span class="cx"> .sidebar > .panel.navigation.debugger .details-section {
</span><span class="cx"> font-size: 11px;
</span><span class="cx"> }
</span><ins>+
+.sidebar > .panel.navigation.debugger .details-section.scripts {
+ border-bottom: none;
+}
+
+.sidebar > .panel.navigation.debugger .details-section.scripts .header {
+ display: none;
+}
+
+.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content {
+ display: block;
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts {
+ border-bottom: 1px solid rgb(179, 179, 179);
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header {
+ display: block;
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content {
+ display: none;
+}
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDebuggerSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (181767 => 181768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2015-03-19 23:52:13 UTC (rev 181768)
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> breakpointsRow.element.appendChild(this._breakpointsContentTreeOutline.element);
</span><span class="cx">
</span><span class="cx"> var breakpointsGroup = new WebInspector.DetailsSectionGroup([breakpointsRow]);
</span><del>- var breakpointsSection = new WebInspector.DetailsSection("breakpoints", WebInspector.UIString("Breakpoints"), [breakpointsGroup]);
</del><ins>+ var breakpointsSection = new WebInspector.DetailsSection("scripts", WebInspector.UIString("Scripts"), [breakpointsGroup]);
</ins><span class="cx"> this.contentElement.appendChild(breakpointsSection.element);
</span><span class="cx">
</span><span class="cx"> this._callStackContentTreeOutline = this.createContentTreeOutline(true);
</span><span class="lines">@@ -148,6 +148,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WebInspector.DebuggerSidebarPanel.OffsetSectionsStyleClassName = "offset-sections";
</span><ins>+WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName = "paused";
</ins><span class="cx"> WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName = "breakpoint-exception-icon";
</span><span class="cx"> WebInspector.DebuggerSidebarPanel.PausedBreakpointIconStyleClassName = "breakpoint-paused-icon";
</span><span class="cx"> WebInspector.DebuggerSidebarPanel.GlobalIconStyleClassName = "global-breakpoints-icon";
</span><span class="lines">@@ -253,6 +254,8 @@
</span><span class="cx"> this._debuggerPauseResumeButtonItem.toggled = true;
</span><span class="cx"> this._debuggerStepOverButtonItem.enabled = true;
</span><span class="cx"> this._debuggerStepIntoButtonItem.enabled = true;
</span><ins>+
+ this.element.classList.add(WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _debuggerDidResume: function(event)
</span><span class="lines">@@ -265,6 +268,8 @@
</span><span class="cx"> this._debuggerStepOverButtonItem.enabled = false;
</span><span class="cx"> this._debuggerStepIntoButtonItem.enabled = false;
</span><span class="cx"> this._debuggerStepOutButtonItem.enabled = false;
</span><ins>+
+ this.element.classList.remove(WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _breakpointsEnabledDidChange: function(event)
</span></span></pre>
</div>
</div>
</body>
</html>