<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181761] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181761">181761</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-19 15:36:43 -0700 (Thu, 19 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed build fixes.
* public/include/manifest.php:
(Manifest::generate): These should be {} instead of [] when they're empty.
* public/v2/data.js:
(Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
* public/v2/manifest.js:
(App.Metric.fullName): Fixed the typo.
* tests/admin-regenerate-manifest.js: Fixed the test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicincludemanifestphp">trunk/Websites/perf.webkit.org/public/include/manifest.php</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2datajs">trunk/Websites/perf.webkit.org/public/v2/data.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtestsadminregeneratemanifestjs">trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (181760 => 181761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog        2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/ChangeLog        2015-03-19 22:36:43 UTC (rev 181761)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Unreviewed build fixes.
+
+ * public/include/manifest.php:
+ (Manifest::generate): These should be {} instead of [] when they're empty.
+ * public/v2/data.js:
+ (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
+ * public/v2/manifest.js:
+ (App.Metric.fullName): Fixed the typo.
+ * tests/admin-regenerate-manifest.js: Fixed the test.
+
</ins><span class="cx"> 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Commit the erroneously reverted change.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicincludemanifestphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/include/manifest.php (181760 => 181761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/include/manifest.php        2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/include/manifest.php        2015-03-19 22:36:43 UTC (rev 181761)
</span><span class="lines">@@ -27,14 +27,14 @@
</span><span class="cx"> $row = $row['commit_repository'];
</span><span class="cx">
</span><span class="cx"> $this->manifest = array(
</span><del>- 'tests' => $this->tests(),
- 'metrics' => $this->metrics(),
- 'all' => $this->platforms($config_table, $platform_table, false),
- 'dashboard' => $this->platforms($config_table, $platform_table, true),
- 'repositories' => $this->repositories($repositories_table, $repositories_with_commit),
- 'builders' => $this->builders(),
- 'bugTrackers' => $this->bug_trackers($repositories_table),
- 'dashboards' => config('dashboards'),
</del><ins>+ 'tests' => (object)$this->tests(),
+ 'metrics' => (object)$this->metrics(),
+ 'all' => (object)$this->platforms($config_table, $platform_table, false),
+ 'dashboard' => (object)$this->platforms($config_table, $platform_table, true),
+ 'repositories' => (object)$this->repositories($repositories_table, $repositories_with_commit),
+ 'builders' => (object)$this->builders(),
+ 'bugTrackers' => (object)$this->bug_trackers($repositories_table),
+ 'dashboards' => (object)config('dashboards'),
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $this->manifest['elapsedTime'] = (microtime(true) - $start_time) * 1000;
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2datajs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (181760 => 181761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/data.js        2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js        2015-03-19 22:36:43 UTC (rev 181761)
</span><span class="lines">@@ -173,7 +173,7 @@
</span><span class="cx"> var formattedRevisions = {};
</span><span class="cx"> for (var repositoryId in revisions) {
</span><span class="cx"> var currentRevision = revisions[repositoryId][0];
</span><del>- var previousRevision = previousRevisions ? previousRevisions[repositoryId][0] : null;
</del><ins>+ var previousRevision = previousRevisions && previousRevisions[repositoryId] ? previousRevisions[repositoryId][0] : null;
</ins><span class="cx"> var formatttedRevision = Measurement.formatRevisionRange(currentRevision, previousRevision);
</span><span class="cx"> formattedRevisions[repositoryId] = formatttedRevision;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (181760 => 181761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js        2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js        2015-03-19 22:36:43 UTC (rev 181761)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> }.property('name', 'test'),
</span><span class="cx"> fullName: function ()
</span><span class="cx"> {
</span><del>- return this.get('path').join(' \u220b ') /* &in; */
</del><ins>+ return this.get('path').join(' \u220b ') /* &ni; */
</ins><span class="cx"> + ' : ' + this.get('label');
</span><span class="cx"> }.property('path', 'label'),
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtestsadminregeneratemanifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js (181760 => 181761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js        2015-03-19 21:59:23 UTC (rev 181760)
+++ trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js        2015-03-19 22:36:43 UTC (rev 181761)
</span><span class="lines">@@ -8,14 +8,15 @@
</span><span class="cx"> var manifest = JSON.parse(response.responseText);
</span><span class="cx"> delete manifest.defaultDashboard;
</span><span class="cx"> delete manifest.dashboards;
</span><ins>+ delete manifest.elapsedTime;
</ins><span class="cx"> assert.deepEqual(manifest, {
</span><del>- all: [],
- bugTrackers: [],
- builders: [],
- dashboard: [],
- metrics: [],
- repositories: [],
- tests: []});
</del><ins>+ all: {},
+ bugTrackers: {},
+ builders: {},
+ dashboard: {},
+ metrics: {},
+ repositories: {},
+ tests: {}});
</ins><span class="cx"> notifyDone();
</span><span class="cx"> });
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>