<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181773] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181773">181773</a></dd>
<dt>Author</dt> <dd>enrica@apple.com</dd>
<dt>Date</dt> <dd>2015-03-19 17:47:32 -0700 (Thu, 19 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>
Source/WebCore:
REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/109593">r109593</a>): Clicking after last inline element could cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=142880
rdar://problem/17222294
Reviewed by Ryosuke Niwa.
Test: editing/selection/click-after-last-inline-crash.html
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):
LayoutTests:
Web Inspector: Adopt ES6 Class Syntax for all Model Objects
https://bugs.webkit.org/show_bug.cgi?id=142858
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-19
Reviewed by Timothy Hatcher.
* inspector/model/parse-script-syntax-tree.html:
This test was calling a constructor without "new". Class
syntax enforces "new" and threw an exception.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRootInlineBoxcpp">trunk/Source/WebCore/rendering/RootInlineBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingselectionclickafterlastinlinecrashexpectedtxt">trunk/LayoutTests/editing/selection/click-after-last-inline-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingselectionclickafterlastinlinecrashhtml">trunk/LayoutTests/editing/selection/click-after-last-inline-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (181772 => 181773)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-20 00:44:12 UTC (rev 181772)
+++ trunk/LayoutTests/ChangeLog 2015-03-20 00:47:32 UTC (rev 181773)
</span><span class="lines">@@ -11,6 +11,17 @@
</span><span class="cx">
</span><span class="cx"> 2015-03-19 Enrica Casucci <enrica@apple.com>
</span><span class="cx">
</span><ins>+ REGRESSION (r109593): Clicking after last inline element could cause a crash.
+ https://bugs.webkit.org/show_bug.cgi?id=142880
+ rdar://problem/17222294
+
+ Reviewed by Ryosuke Niwa.
+
+ * editing/selection/click-after-last-inline-crash-expected.txt: Added.
+ * editing/selection/click-after-last-inline-crash.html: Added.
+
+2015-03-19 Enrica Casucci <enrica@apple.com>
+
</ins><span class="cx"> <attachment> should put URLs on the pasteboard so that Finder can accept drops.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142801
</span><span class="cx"> rdar://problem/19982527
</span></span></pre></div>
<a id="trunkLayoutTestseditingselectionclickafterlastinlinecrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/selection/click-after-last-inline-crash-expected.txt (0 => 181773)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/selection/click-after-last-inline-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/click-after-last-inline-crash-expected.txt 2015-03-20 00:47:32 UTC (rev 181773)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+Click after the end of the line with link.
+
+This is a link
+
+It should NOT crash!
+
+PASS
</ins></span></pre></div>
<a id="trunkLayoutTestseditingselectionclickafterlastinlinecrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/selection/click-after-last-inline-crash.html (0 => 181773)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/selection/click-after-last-inline-crash.html (rev 0)
+++ trunk/LayoutTests/editing/selection/click-after-last-inline-crash.html 2015-03-20 00:47:32 UTC (rev 181773)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<html>
+<body>
+<div style="border: solid red 2px;">
+Click after the end of the line with link.<br><br><a id='test' href="http://aftershock.su/?q=node/259078">This is a link</a><wbr><br><br>It should NOT crash!<br><br>
+</div>
+</body>
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+
+ if (!window.eventSender)
+ document.writeln('This test requires eventSender');
+ else {
+ var testElement = document.getElementById('test');
+ eventSender.mouseMoveTo(testElement.offsetLeft + testElement.offsetWidth + 50, testElement.offsetTop + 5);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+ document.writeln('PASS');
+ }
+}
+
+</script>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181772 => 181773)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-20 00:44:12 UTC (rev 181772)
+++ trunk/Source/WebCore/ChangeLog 2015-03-20 00:47:32 UTC (rev 181773)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2015-03-19 Enrica Casucci <enrica@apple.com>
</span><span class="cx">
</span><ins>+ REGRESSION (r109593): Clicking after last inline element could cause a crash.
+ https://bugs.webkit.org/show_bug.cgi?id=142880
+ rdar://problem/17222294
+
+ Reviewed by Ryosuke Niwa.
+
+ Test: editing/selection/click-after-last-inline-crash.html
+
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):
+
+2015-03-19 Enrica Casucci <enrica@apple.com>
+
</ins><span class="cx"> One more build fix after r181760.
</span><span class="cx">
</span><span class="cx"> * page/EventHandler.cpp:
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRootInlineBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RootInlineBox.cpp (181772 => 181773)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RootInlineBox.cpp 2015-03-20 00:44:12 UTC (rev 181772)
+++ trunk/Source/WebCore/rendering/RootInlineBox.cpp 2015-03-20 00:47:32 UTC (rev 181773)
</span><span class="lines">@@ -763,12 +763,12 @@
</span><span class="cx"> return firstLeaf;
</span><span class="cx">
</span><span class="cx"> // Avoid returning a list marker when possible.
</span><del>- if (leftPosition <= firstLeaf->logicalLeft() && !firstLeaf->renderer().isListMarker() && (!onlyEditableLeaves || isEditableLeaf(firstLeaf)))
</del><ins>+ if (firstLeaf && leftPosition <= firstLeaf->logicalLeft() && !firstLeaf->renderer().isListMarker() && (!onlyEditableLeaves || isEditableLeaf(firstLeaf)))
</ins><span class="cx"> // The leftPosition coordinate is less or equal to left edge of the firstLeaf.
</span><span class="cx"> // Return it.
</span><span class="cx"> return firstLeaf;
</span><span class="cx">
</span><del>- if (leftPosition >= lastLeaf->logicalRight() && !lastLeaf->renderer().isListMarker() && (!onlyEditableLeaves || isEditableLeaf(lastLeaf)))
</del><ins>+ if (lastLeaf && leftPosition >= lastLeaf->logicalRight() && !lastLeaf->renderer().isListMarker() && (!onlyEditableLeaves || isEditableLeaf(lastLeaf)))
</ins><span class="cx"> // The leftPosition coordinate is greater or equal to right edge of the lastLeaf.
</span><span class="cx"> // Return it.
</span><span class="cx"> return lastLeaf;
</span></span></pre>
</div>
</div>
</body>
</html>