<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181619] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181619">181619</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-17 00:15:26 -0700 (Tue, 17 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove never used "useLayerOnTop" bindings generator argument
https://bugs.webkit.org/show_bug.cgi?id=142773
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-17
Reviewed by Darin Adler.
Source/WebCore:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/generate-bindings.pl:
Tools:
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(new):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsgeneratebindingspl">trunk/Source/WebCore/bindings/scripts/generate-bindings.pl</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleBindingsCodeGeneratorTestRunnerpm">trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/ChangeLog 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
+
+ Remove never used "useLayerOnTop" bindings generator argument
+ https://bugs.webkit.org/show_bug.cgi?id=142773
+
+ Reviewed by Darin Adler.
+
+ * bindings/scripts/CodeGenerator.pm:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * bindings/scripts/generate-bindings.pl:
+
</ins><span class="cx"> 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Enable ES6 classes by default
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -35,7 +35,6 @@
</span><span class="cx"> my $useOutputDir = "";
</span><span class="cx"> my $useOutputHeadersDir = "";
</span><span class="cx"> my $useDirectories = "";
</span><del>-my $useLayerOnTop = 0;
</del><span class="cx"> my $preprocessor;
</span><span class="cx"> my $writeDependencies = 0;
</span><span class="cx"> my $defines = "";
</span><span class="lines">@@ -110,7 +109,6 @@
</span><span class="cx"> $useGenerator = shift;
</span><span class="cx"> $useOutputDir = shift;
</span><span class="cx"> $useOutputHeadersDir = shift;
</span><del>- $useLayerOnTop = shift;
</del><span class="cx"> $preprocessor = shift;
</span><span class="cx"> $writeDependencies = shift;
</span><span class="cx"> $verbose = shift;
</span><span class="lines">@@ -132,7 +130,7 @@
</span><span class="cx"> %enumTypeHash = map { $_->name => $_->values } @{$useDocument->enumerations};
</span><span class="cx">
</span><span class="cx"> # Dynamically load external code generation perl module
</span><del>- $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
</del><ins>+ $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
</ins><span class="cx"> unless (defined($codeGenerator)) {
</span><span class="cx"> my $interfaces = $useDocument->interfaces;
</span><span class="cx"> foreach my $interface (@$interfaces) {
</span><span class="lines">@@ -157,7 +155,7 @@
</span><span class="cx"> require $ifaceName . ".pm";
</span><span class="cx">
</span><span class="cx"> # Dynamically load external code generation perl module
</span><del>- $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose);
</del><ins>+ $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose);
</ins><span class="cx"> return $codeGenerator->FileNamePrefix();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -36,8 +36,6 @@
</span><span class="cx">
</span><span class="cx"> my $codeGenerator;
</span><span class="cx">
</span><del>-my $writeDependencies = 0;
-
</del><span class="cx"> my @headerContentHeader = ();
</span><span class="cx"> my @headerContent = ();
</span><span class="cx"> my %headerIncludes = ();
</span><span class="lines">@@ -114,9 +112,6 @@
</span><span class="cx"> my $reference = { };
</span><span class="cx">
</span><span class="cx"> $codeGenerator = shift;
</span><del>- shift; # $useLayerOnTop
- shift; # $preprocessor
- $writeDependencies = shift;
</del><span class="cx">
</span><span class="cx"> bless($reference, $object);
</span><span class="cx"> return $reference;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -224,7 +224,6 @@
</span><span class="cx"> my $reference = { };
</span><span class="cx">
</span><span class="cx"> $codeGenerator = shift;
</span><del>- shift; # $useLayerOnTop
</del><span class="cx"> shift; # $preprocessor
</span><span class="cx"> $writeDependencies = shift;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsgeneratebindingspl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/generate-bindings.pl (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/generate-bindings.pl 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Source/WebCore/bindings/scripts/generate-bindings.pl 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!$idlFound) {
</span><del>- my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose);
</del><ins>+ my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose);
</ins><span class="cx">
</span><span class="cx"> # We generate empty .h and .cpp files just to tell build scripts that .h and .cpp files are created.
</span><span class="cx"> generateEmptyHeaderAndCpp($codeGen->FileNamePrefix(), $targetInterfaceName, $outputHeadersDirectory, $outputDirectory);
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> # Generate desired output for the target IDL file.
</span><del>-my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
</del><ins>+my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
</ins><span class="cx"> $codeGen->ProcessDocument($targetDocument, $defines);
</span><span class="cx">
</span><span class="cx"> sub generateEmptyHeaderAndCpp
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Tools/ChangeLog 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
+
+ Remove never used "useLayerOnTop" bindings generator argument
+ https://bugs.webkit.org/show_bug.cgi?id=142773
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
+ (new):
+
</ins><span class="cx"> 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Enable ES6 classes by default
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleBindingsCodeGeneratorTestRunnerpm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm (181618 => 181619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm 2015-03-17 05:55:46 UTC (rev 181618)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm 2015-03-17 07:15:26 UTC (rev 181619)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx">
</span><span class="cx"> sub new
</span><span class="cx"> {
</span><del>- my ($class, $codeGenerator, $layerOnTop, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
</del><ins>+ my ($class, $codeGenerator, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
</ins><span class="cx">
</span><span class="cx"> my $reference = {
</span><span class="cx"> codeGenerator => $codeGenerator,
</span></span></pre>
</div>
</div>
</body>
</html>