<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181669] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181669">181669</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2015-03-17 15:57:40 -0700 (Tue, 17 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>check-webkit-style should allow "bool a : 1"
https://bugs.webkit.org/show_bug.cgi?id=142794
Reviewed by Brent Fulgham.
We should allow member bitfields of the form:
bool m_var : 1;
It seems that Visual Studio 8 was the last compiler that
wasn't happy about not using unsigned here. We already have
about 500 cases (in WebCore) where people were ignoring this rule.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Allow "bool".
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
(CppStyleTest.test_enum_bitfields):
(CppStyleTest.test_plain_integral_bitfields):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpppy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpp_unittestpy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (181668 => 181669)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-03-17 22:48:07 UTC (rev 181668)
+++ trunk/Tools/ChangeLog 2015-03-17 22:57:40 UTC (rev 181669)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-03-17 Dean Jackson <dino@apple.com>
+
+ check-webkit-style should allow "bool a : 1"
+ https://bugs.webkit.org/show_bug.cgi?id=142794
+
+ Reviewed by Brent Fulgham.
+
+ We should allow member bitfields of the form:
+
+ bool m_var : 1;
+
+ It seems that Visual Studio 8 was the last compiler that
+ wasn't happy about not using unsigned here. We already have
+ about 500 cases (in WebCore) where people were ignoring this rule.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_language): Allow "bool".
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
+ (CppStyleTest.test_enum_bitfields):
+ (CppStyleTest.test_plain_integral_bitfields):
+
</ins><span class="cx"> 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> Compile character ranges targeting the same state as range check in the bytecode
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpppy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (181668 => 181669)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2015-03-17 22:48:07 UTC (rev 181668)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2015-03-17 22:57:40 UTC (rev 181669)
</span><span class="lines">@@ -3273,7 +3273,7 @@
</span><span class="cx"> matched = re.match(r'\s*((const|mutable)\s+)?([a-zA-Z_][a-zA-Z0-9_]*)\s+[a-zA-Z_][a-zA-Z0-9_]*\s*:\s*\d+\s*;', line)
</span><span class="cx"> if matched:
</span><span class="cx"> # Make sure the type is an enum and not an integral type
</span><del>- if not match(r'char|(short(\s+int)?)|int|long(\s+(long|int))|(signed|unsigned)(\s+int)?', matched.group(3)):
</del><ins>+ if not match(r'bool|char|(short(\s+int)?)|int|long(\s+(long|int))|(signed|unsigned)(\s+int)?', matched.group(3)):
</ins><span class="cx"> error(line_number, 'runtime/enum_bitfields', 5,
</span><span class="cx"> 'Please declare enum bitfields as unsigned integral types.')
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpp_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (181668 => 181669)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-03-17 22:48:07 UTC (rev 181668)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-03-17 22:57:40 UTC (rev 181669)
</span><span class="lines">@@ -2552,6 +2552,7 @@
</span><span class="cx"> self.assert_lint('AnEnum a : 30;', errmsg)
</span><span class="cx"> self.assert_lint('mutable AnEnum a : 14;', errmsg)
</span><span class="cx"> self.assert_lint('const AnEnum a : 6;', errmsg)
</span><ins>+ self.assert_lint('bool a : 1;', '')
</ins><span class="cx">
</span><span class="cx"> # Integral bitfields must be declared with either signed or unsigned keyword.
</span><span class="cx"> def test_plain_integral_bitfields(self):
</span><span class="lines">@@ -2562,8 +2563,8 @@
</span><span class="cx"> self.assert_lint('const char a : 6;', errmsg)
</span><span class="cx"> self.assert_lint('long int a : 30;', errmsg)
</span><span class="cx"> self.assert_lint('int a = 1 ? 0 : 30;', '')
</span><ins>+ self.assert_lint('bool a : 1;', '')
</ins><span class="cx">
</span><del>-
</del><span class="cx"> class CleansedLinesTest(unittest.TestCase):
</span><span class="cx"> def test_init(self):
</span><span class="cx"> lines = ['Line 1',
</span></span></pre>
</div>
</div>
</body>
</html>