<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181383] releases/WebKitGTK/webkit-2.8/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181383">181383</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-11 03:49:16 -0700 (Wed, 11 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/181326">r181326</a> - GCC: CRASH() should be annotated with NORETURN
https://bugs.webkit.org/show_bug.cgi?id=142524
Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2015-03-10
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
Don't return from a NORETURN function. This used to avoid a warning from GCC, but now it
causes one.
* jsc.cpp:
Source/WTF:
Add COMPILER(GCC) to #ifdefs that already exist for Clang.
* wtf/Assertions.cpp:
* wtf/Assertions.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28SourceJavaScriptCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceJavaScriptCorejsccpp">releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/jsc.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWTFChangeLog">releases/WebKitGTK/webkit-2.8/Source/WTF/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWTFwtfAssertionscpp">releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWTFwtfAssertionsh">releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28SourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog (181382 => 181383)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog 2015-03-11 10:23:37 UTC (rev 181382)
+++ releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/ChangeLog 2015-03-11 10:49:16 UTC (rev 181383)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-03-10 Michael Catanzaro <mcatanzaro@igalia.com>
+
+ GCC: CRASH() should be annotated with NORETURN
+ https://bugs.webkit.org/show_bug.cgi?id=142524
+
+ Reviewed by Anders Carlsson.
+
+ Don't return from a NORETURN function. This used to avoid a warning from GCC, but now it
+ causes one.
+
+ * jsc.cpp:
+
</ins><span class="cx"> 2015-03-09 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> 8-bit version of weakCompareAndSwap() can cause an infinite loop.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceJavaScriptCorejsccpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/jsc.cpp (181382 => 181383)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/jsc.cpp 2015-03-11 10:23:37 UTC (rev 181382)
+++ releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore/jsc.cpp 2015-03-11 10:49:16 UTC (rev 181383)
</span><span class="lines">@@ -363,9 +363,6 @@
</span><span class="cx"> static NO_RETURN_DUE_TO_CRASH bool deleteProperty(JSCell*, ExecState*, PropertyName)
</span><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT_NOT_REACHED();
</span><del>-#if COMPILER_QUIRK(CONSIDERS_UNREACHABLE_CODE)
- return true;
-#endif
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned getLength() const { return m_vector.size(); }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WTF/ChangeLog (181382 => 181383)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WTF/ChangeLog 2015-03-11 10:23:37 UTC (rev 181382)
+++ releases/WebKitGTK/webkit-2.8/Source/WTF/ChangeLog 2015-03-11 10:49:16 UTC (rev 181383)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2015-03-10 Michael Catanzaro <mcatanzaro@igalia.com>
+
+ GCC: CRASH() should be annotated with NORETURN
+ https://bugs.webkit.org/show_bug.cgi?id=142524
+
+ Reviewed by Anders Carlsson.
+
+ Add COMPILER(GCC) to #ifdefs that already exist for Clang.
+
+ * wtf/Assertions.cpp:
+ * wtf/Assertions.h:
+
</ins><span class="cx"> 2015-03-10 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> bmalloc: tryFastMalloc shouldn't crash
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWTFwtfAssertionscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.cpp (181382 => 181383)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.cpp 2015-03-11 10:23:37 UTC (rev 181382)
+++ releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.cpp 2015-03-11 10:49:16 UTC (rev 181383)
</span><span class="lines">@@ -320,7 +320,7 @@
</span><span class="cx"> WTFReportBacktrace();
</span><span class="cx"> *(int *)(uintptr_t)0xbbadbeef = 0;
</span><span class="cx"> // More reliable, but doesn't say BBADBEEF.
</span><del>-#if COMPILER(CLANG)
</del><ins>+#if COMPILER(CLANG) || COMPILER(GCC)
</ins><span class="cx"> __builtin_trap();
</span><span class="cx"> #else
</span><span class="cx"> ((void(*)())0)();
</span><span class="lines">@@ -334,7 +334,7 @@
</span><span class="cx"> WTFReportBacktrace();
</span><span class="cx"> *(int *)(uintptr_t)0xfbadbeef = 0;
</span><span class="cx"> // More reliable, but doesn't say fbadbeef.
</span><del>-#if COMPILER(CLANG)
</del><ins>+#if COMPILER(CLANG) || COMPILER(GCC)
</ins><span class="cx"> __builtin_trap();
</span><span class="cx"> #else
</span><span class="cx"> ((void(*)())0)();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWTFwtfAssertionsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.h (181382 => 181383)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.h 2015-03-11 10:23:37 UTC (rev 181382)
+++ releases/WebKitGTK/webkit-2.8/Source/WTF/wtf/Assertions.h 2015-03-11 10:49:16 UTC (rev 181383)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx">
</span><span class="cx"> Signals are ignored by the crash reporter on OS X so we must do better.
</span><span class="cx"> */
</span><del>-#if COMPILER(CLANG) || COMPILER(MSVC)
</del><ins>+#if COMPILER(CLANG) || COMPILER(GCC) || COMPILER(MSVC)
</ins><span class="cx"> #define NO_RETURN_DUE_TO_CRASH NO_RETURN
</span><span class="cx"> #else
</span><span class="cx"> #define NO_RETURN_DUE_TO_CRASH
</span></span></pre>
</div>
</div>
</body>
</html>