<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181285] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181285">181285</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2015-03-09 15:09:34 -0700 (Mon, 09 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
https://bugs.webkit.org/show_bug.cgi?id=142470
Reviewed by Anders Carlsson.
Source/WebCore:
After each test, reset all internal settings.
Covered by svg/custom/svg-fonts-without-missing-glyph.xhtml
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
LayoutTests:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingscpp">trunk/Source/WebCore/testing/InternalSettings.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingsh">trunk/Source/WebCore/testing/InternalSettings.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (181284 => 181285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-09 22:08:36 UTC (rev 181284)
+++ trunk/LayoutTests/ChangeLog 2015-03-09 22:09:34 UTC (rev 181285)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-03-09 Myles C. Maxfield <mmaxfield@apple.com>
+
+ svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
+ https://bugs.webkit.org/show_bug.cgi?id=142470
+
+ Reviewed by Anders Carlsson.
+
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2015-03-09 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> CSS JIT: add aliases between :nth-child()/:nth-last-child() and :first-child/:last-child
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (181284 => 181285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-03-09 22:08:36 UTC (rev 181284)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-03-09 22:09:34 UTC (rev 181285)
</span><span class="lines">@@ -1237,7 +1237,6 @@
</span><span class="cx"> webkit.org/b/140589 svg/text/text-text-06-t.svg [ Failure ]
</span><span class="cx"> webkit.org/b/137098 svg/text/text-hkern.svg [ Failure ]
</span><span class="cx"> webkit.org/b/137100 svg/text/text-vkern.svg [ Failure ]
</span><del>-webkit.org/b/142470 svg/custom/svg-fonts-without-missing-glyph.xhtml [ Pass Failure ]
</del><span class="cx">
</span><span class="cx"> # Sometimes has an extra space at the end
</span><span class="cx"> fast/forms/focus-selection-textarea.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181284 => 181285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-09 22:08:36 UTC (rev 181284)
+++ trunk/Source/WebCore/ChangeLog 2015-03-09 22:09:34 UTC (rev 181285)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-03-09 Myles C. Maxfield <mmaxfield@apple.com>
+
+ svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
+ https://bugs.webkit.org/show_bug.cgi?id=142470
+
+ Reviewed by Anders Carlsson.
+
+ After each test, reset all internal settings.
+
+ Covered by svg/custom/svg-fonts-without-missing-glyph.xhtml
+
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo):
+ * testing/InternalSettings.h:
+
</ins><span class="cx"> 2015-03-09 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r181268.
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (181284 => 181285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.cpp 2015-03-09 22:08:36 UTC (rev 181284)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2015-03-09 22:09:34 UTC (rev 181285)
</span><span class="lines">@@ -90,6 +90,13 @@
</span><span class="cx"> , m_autoscrollForDragAndDropEnabled(settings.autoscrollForDragAndDropEnabled())
</span><span class="cx"> , m_pluginReplacementEnabled(RuntimeEnabledFeatures::sharedFeatures().pluginReplacementEnabled())
</span><span class="cx"> , m_shouldConvertPositionStyleOnCopy(settings.shouldConvertPositionStyleOnCopy())
</span><ins>+ , m_fontFallbackPrefersPictographs(settings.fontFallbackPrefersPictographs())
+ , m_backgroundShouldExtendBeyondPage(settings.backgroundShouldExtendBeyondPage())
+ , m_storageBlockingPolicy(settings.storageBlockingPolicy())
+ , m_scrollingTreeIncludesFrames(settings.scrollingTreeIncludesFrames())
+#if ENABLE(TOUCH_EVENTS)
+ , m_touchEventEmulationEnabled(settings.isTouchEventEmulationEnabled())
+#endif
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -146,6 +153,13 @@
</span><span class="cx"> settings.setUseLegacyBackgroundSizeShorthandBehavior(m_useLegacyBackgroundSizeShorthandBehavior);
</span><span class="cx"> settings.setAutoscrollForDragAndDropEnabled(m_autoscrollForDragAndDropEnabled);
</span><span class="cx"> settings.setShouldConvertPositionStyleOnCopy(m_shouldConvertPositionStyleOnCopy);
</span><ins>+ settings.setFontFallbackPrefersPictographs(m_fontFallbackPrefersPictographs);
+ settings.setBackgroundShouldExtendBeyondPage(m_backgroundShouldExtendBeyondPage);
+ settings.setStorageBlockingPolicy(m_storageBlockingPolicy);
+ settings.setScrollingTreeIncludesFrames(m_scrollingTreeIncludesFrames);
+#if ENABLE(TOUCH_EVENTS)
+ settings.setTouchEventEmulationEnabled(m_touchEventEmulationEnabled);
+#endif
</ins><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setPluginReplacementEnabled(m_pluginReplacementEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -486,4 +500,6 @@
</span><span class="cx"> settings()->setScrollingTreeIncludesFrames(enabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+// If you add to this list, make sure that you update the Backup class for test reproducability!
+
</ins><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.h (181284 => 181285)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.h 2015-03-09 22:08:36 UTC (rev 181284)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2015-03-09 22:09:34 UTC (rev 181285)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "FontGenericFamilies.h"
</span><span class="cx"> #include "IntSize.h"
</span><span class="cx"> #include "InternalSettingsGenerated.h"
</span><ins>+#include "SecurityOrigin.h"
</ins><span class="cx"> #include <wtf/PassRefPtr.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -87,6 +88,13 @@
</span><span class="cx"> bool m_autoscrollForDragAndDropEnabled;
</span><span class="cx"> bool m_pluginReplacementEnabled;
</span><span class="cx"> bool m_shouldConvertPositionStyleOnCopy;
</span><ins>+ bool m_fontFallbackPrefersPictographs;
+ bool m_backgroundShouldExtendBeyondPage;
+ SecurityOrigin::StorageBlockingPolicy m_storageBlockingPolicy;
+ bool m_scrollingTreeIncludesFrames;
+#if ENABLE(TOUCH_EVENTS)
+ bool m_touchEventEmulationEnabled;
+#endif
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> static PassRefPtr<InternalSettings> create(Page* page)
</span></span></pre>
</div>
</div>
</body>
</html>