<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181226] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181226">181226</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-08 01:06:39 -0800 (Sun, 08 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/181168">r181168</a> - Setting any of the <object> element plugin controlling attributes does not have any affect.
https://bugs.webkit.org/show_bug.cgi?id=141936.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-03-06
Reviewed by Simon Fraser.
Source/WebCore:
When setting any of the <object> element plugin controlling attributes
dynamically we need to mark the the element to be dirty by calling
setNeedsStyleRecalc(), so it has to recreate its renderer when needed.
Tests: fast/css/image-object-hover-inherit.html
svg/as-object/svg-in-object-dynamic-attribute-change.html
* dom/Element.h: Delete unimplemented function.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Mark the element dirty by
calling setNeedsStyleRecalc() when one of the plugin controlling attributes
gets changed. We have to clear m_useFallbackContent because the attribute's
new value might fix the object rendering.
* html/HTMLObjectElement.h: Add a function to clear m_useFallbackContent.
LayoutTests:
* fast/css/image-object-hover-inherit-expected.html: Added.
* fast/css/image-object-hover-inherit.html: Added.
A guarding test to catch the case of reconstructing the image <object>
renderer while performing a synchronous resolveTree() followed by page
rendering or dump render tree.
* svg/as-object/resources/lime100x100.html: Added.
* svg/as-object/resources/lime100x100.png: Added.
* svg/as-object/resources/lime100x100.svg: Added.
* svg/as-object/resources/red100x100.svg: Added.
* svg/as-object/svg-in-object-dynamic-attribute-change-expected.html: Added.
* svg/as-object/svg-in-object-dynamic-attribute-change.html: Added.
Ensure that changing the 'type' and the 'data' attributes of the <object>
element will have the expected outcome. Also make sure that the <object>
element renderer falls back correctly when setting any of the attributes
to some unexpected value.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLObjectElementcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLPlugInImageElementcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLPlugInImageElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastcssimageobjecthoverinheritexpectedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastcssimageobjecthoverinherithtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (181225 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-08 08:49:54 UTC (rev 181225)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2015-03-06 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Setting any of the <object> element plugin controlling attributes does not have any affect.
+ https://bugs.webkit.org/show_bug.cgi?id=141936.
+
+ Reviewed by Simon Fraser.
+
+ * fast/css/image-object-hover-inherit-expected.html: Added.
+ * fast/css/image-object-hover-inherit.html: Added.
+ A guarding test to catch the case of reconstructing the image <object>
+ renderer while performing a synchronous resolveTree() followed by page
+ rendering or dump render tree.
+
+ * svg/as-object/resources/lime100x100.html: Added.
+ * svg/as-object/resources/lime100x100.png: Added.
+ * svg/as-object/resources/lime100x100.svg: Added.
+ * svg/as-object/resources/red100x100.svg: Added.
+ * svg/as-object/svg-in-object-dynamic-attribute-change-expected.html: Added.
+ * svg/as-object/svg-in-object-dynamic-attribute-change.html: Added.
+ Ensure that changing the 'type' and the 'data' attributes of the <object>
+ element will have the expected outcome. Also make sure that the <object>
+ element renderer falls back correctly when setting any of the attributes
+ to some unexpected value.
+
+2015-03-03 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r180683.
+ https://bugs.webkit.org/show_bug.cgi?id=142249
+
+ Broke fast/css/acid2-pixel.html (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Setting any of the <object> element plugin controlling
+ attributes does not have any affect."
+ https://bugs.webkit.org/show_bug.cgi?id=141936
+ http://trac.webkit.org/changeset/180683
+
</ins><span class="cx"> 2015-02-27 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Use after free in WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastcssimageobjecthoverinheritexpectedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit-expected.html (0 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit-expected.html 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+ <style>
+ div {
+ width: 100px;
+ height: 100px;
+ background-color:lime;
+ }
+ </style>
+</head>
+<body>
+ <div></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastcssimageobjecthoverinherithtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit.html (0 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit.html (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/css/image-object-hover-inherit.html 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -0,0 +1,41 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+ <style>
+ div {
+ width: 100px;
+ height: 100px;
+ background-color:red;
+ }
+ div:hover {
+ border-bottom-color: inherit;
+ }
+ </style>
+</head>
+<body>
+ <div>
+ <object id="image" data="data:image/png;base64,
+ iVBORw0KGgoAAAANSUhEUgAAAGQAAABkCAYAAABw4pVUAAAAAXNSR0IArs4c6QAAAARnQU1BAACx
+ jwv8YQUAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAABh0RVh0
+ U29mdHdhcmUAUGFpbnQuTkVUIHYzLjA4ZXKc4QAAAeNJREFUeF7t0sERgDAQw0DSf9FAqvA+lBRw
+ Gsnnef/fgwzcIH3HQDEwAxiOs9QVSUEwAxjOapfO3YJgBjAcZ6krkoJgBjCc1S6duwXBDGA4zlJX
+ JAXBDGA4q106dwuCGcBwnKWuSAqCGcBwVrt07hYEM4DhOEtdkRQEM4DhrHbp3C0IZgDDcZa6IikI
+ ZgDDWe3SuVsQzACG4yx1RVIQzACGs9qlc7cgmAEMx1nqiqQgmAEMZ7VL525BMAMYjrPUFUlBMAMY
+ zmqXzt2CYAYwHGepK5KCYAYwnNUunbsFwQxgOM5SVyQFwQxgOKtdOncLghnAcJylrkgKghnAcFa7
+ dO4WBDOA4ThLXZEUBDOA4ax26dwtCGYAw3GWuiIpCGYAw1nt0rlbEMwAhuMsdUVSEMwAhrPapXO3
+ IJgBDMdZ6oqkIJgBDGe1S+duQTADGI6z1BVJQTADGM5ql87dgmAGMBxnqSuSgmAGMJzVLp27BcEM
+ YDjOUlckBcEMYDirXTp3C4IZwHCcpa5ICoIZwHBWu3TuFgQzgOE4S12RFAQzgOGsduncLQhmAMNx
+ lroiKQhmAMNZ7dK5WxDMAIbjLHVFUhDMAIaz2qVztyCYAQzHWeqKpCCYAQxntUvnbkEwAxiOs9QR
+ yQemSBErQhZ+LAAAAABJRU5ErkJggg==">
+ </object>
+ </div>
+ <script>
+ window.onload = function() {
+ if (window.eventSender) {
+ image = document.getElementById('image');
+ window.eventSender.mouseMoveTo(image.offsetLeft + 10, image.offsetTop + 10);
+ }
+ }
+ </script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (181225 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-08 08:49:54 UTC (rev 181225)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -1,3 +1,41 @@
</span><ins>+2015-03-06 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ Setting any of the <object> element plugin controlling attributes does not have any affect.
+ https://bugs.webkit.org/show_bug.cgi?id=141936.
+
+ Reviewed by Simon Fraser.
+
+ When setting any of the <object> element plugin controlling attributes
+ dynamically we need to mark the the element to be dirty by calling
+ setNeedsStyleRecalc(), so it has to recreate its renderer when needed.
+
+ Tests: fast/css/image-object-hover-inherit.html
+ svg/as-object/svg-in-object-dynamic-attribute-change.html
+
+ * dom/Element.h: Delete unimplemented function.
+
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseAttribute): Mark the element dirty by
+ calling setNeedsStyleRecalc() when one of the plugin controlling attributes
+ gets changed. We have to clear m_useFallbackContent because the attribute's
+ new value might fix the object rendering.
+
+ * html/HTMLObjectElement.h: Add a function to clear m_useFallbackContent.
+
+2015-03-03 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r180683.
+ https://bugs.webkit.org/show_bug.cgi?id=142249
+
+ Broke fast/css/acid2-pixel.html (Requested by ap on #webkit).
+
+ Reverted changeset:
+
+ "Setting any of the <object> element plugin controlling
+ attributes does not have any affect."
+ https://bugs.webkit.org/show_bug.cgi?id=141936
+ http://trac.webkit.org/changeset/180683
+
</ins><span class="cx"> 2015-03-02 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [SOUP] Use SoupMessage::starting instead of SoupSession::request-started
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLObjectElement.cpp (181225 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLObjectElement.cpp 2015-03-08 08:49:54 UTC (rev 181225)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLObjectElement.cpp 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -137,7 +137,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> clearUseFallbackContent();
</span><del>- setNeedsStyleRecalc(SyntheticStyleChange);
</del><ins>+ setNeedsStyleRecalc(ReconstructRenderTree);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void mapDataParamToSrc(Vector<String>* paramNames, Vector<String>* paramValues)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLPlugInImageElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLPlugInImageElement.cpp (181225 => 181226)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLPlugInImageElement.cpp 2015-03-08 08:49:54 UTC (rev 181225)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLPlugInImageElement.cpp 2015-03-08 09:06:39 UTC (rev 181226)
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: There shoudn't be need to force render tree reconstruction here.
</span><span class="cx"> // It is only done because loading and load event dispatching is tied to render tree construction.
</span><del>- if (!useFallbackContent() && needsWidgetUpdate() && renderer() && (displayState() != DisplayingSnapshot))
</del><ins>+ if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType() && (displayState() != DisplayingSnapshot))
</ins><span class="cx"> setNeedsStyleRecalc(ReconstructRenderTree);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>