<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181186] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181186">181186</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-06 14:41:15 -0800 (Fri, 06 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Adopt Object Literal Method Property Syntax
https://bugs.webkit.org/show_bug.cgi?id=142409
Reviewed by Timothy Hatcher.
Mechanical change touching lots of files.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsObjectPreviewjs">trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsPropertyDescriptorjs">trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsPropertyPathjs">trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectPreviewViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeArrayIndexTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeBaseTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeMapEntryTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeSetIndexTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -1,5 +1,14 @@
</span><span class="cx"> 2015-03-06 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Adopt Object Literal Method Property Syntax
+ https://bugs.webkit.org/show_bug.cgi?id=142409
+
+ Reviewed by Timothy Hatcher.
+
+ Mechanical change touching lots of files.
+
+2015-03-06 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Adopt Object Literal Shorthand Property Construction Syntax
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142374
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsObjectPreviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> return this._size;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- hasSize: function()
</del><ins>+ hasSize()
</ins><span class="cx"> {
</span><span class="cx"> return this._size !== undefined && (this._subtype === "array" || this._subtype === "set" || this._subtype === "map" || this._subtype === "weakmap");
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsPropertyDescriptorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -129,22 +129,22 @@
</span><span class="cx"> return this._internal;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- hasValue: function()
</del><ins>+ hasValue()
</ins><span class="cx"> {
</span><span class="cx"> return this._hasValue;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- hasGetter: function()
</del><ins>+ hasGetter()
</ins><span class="cx"> {
</span><span class="cx"> return this._get && this._get.type === "function";
</span><span class="cx"> },
</span><span class="cx">
</span><del>- hasSetter: function()
</del><ins>+ hasSetter()
</ins><span class="cx"> {
</span><span class="cx"> return this._set && this._set.type === "function";
</span><span class="cx"> },
</span><span class="cx">
</span><del>- isIndexProperty: function()
</del><ins>+ isIndexProperty()
</ins><span class="cx"> {
</span><span class="cx"> return !isNaN(Number(this._name));
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsPropertyPathjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -138,22 +138,22 @@
</span><span class="cx"> return components.join("");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- displayPath: function(type)
</del><ins>+ displayPath(type)
</ins><span class="cx"> {
</span><span class="cx"> return type === WebInspector.PropertyPath.Type.Value ? this.reducedPath : this.fullPath;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- isRoot: function()
</del><ins>+ isRoot()
</ins><span class="cx"> {
</span><span class="cx"> return !this._parent;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- isPathComponentImpossible: function()
</del><ins>+ isPathComponentImpossible()
</ins><span class="cx"> {
</span><span class="cx"> return this._pathComponent && this._pathComponent.startsWith("@");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- isFullPathImpossible: function()
</del><ins>+ isFullPathImpossible()
</ins><span class="cx"> {
</span><span class="cx"> if (this.isPathComponentImpossible())
</span><span class="cx"> return true;
</span><span class="lines">@@ -164,50 +164,50 @@
</span><span class="cx"> return false;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendPropertyName: function(object, propertyName)
</del><ins>+ appendPropertyName(object, propertyName)
</ins><span class="cx"> {
</span><span class="cx"> var isPrototype = propertyName === "__proto__";
</span><span class="cx"> var component = this._canPropertyNameBeDotAccess(propertyName) ? "." + propertyName : "[" + doubleQuotedString(propertyName) + "]";
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this, isPrototype);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendPropertySymbol: function(object, symbolName)
</del><ins>+ appendPropertySymbol(object, symbolName)
</ins><span class="cx"> {
</span><span class="cx"> var component = WebInspector.PropertyPath.SpecialPathComponent.SymbolPropertyName + (symbolName.length ? "(" + symbolName + ")" : "");
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendInternalPropertyName: function(object, propertyName)
</del><ins>+ appendInternalPropertyName(object, propertyName)
</ins><span class="cx"> {
</span><span class="cx"> var component = WebInspector.PropertyPath.SpecialPathComponent.InternalPropertyName + "[" + propertyName + "]";
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendGetterPropertyName: function(object, propertyName)
</del><ins>+ appendGetterPropertyName(object, propertyName)
</ins><span class="cx"> {
</span><span class="cx"> var component = ".__lookupGetter__(" + doubleQuotedString(propertyName) + ")";
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendSetterPropertyName: function(object, propertyName)
</del><ins>+ appendSetterPropertyName(object, propertyName)
</ins><span class="cx"> {
</span><span class="cx"> var component = ".__lookupSetter__(" + doubleQuotedString(propertyName) + ")";
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendArrayIndex: function(object, indexString)
</del><ins>+ appendArrayIndex(object, indexString)
</ins><span class="cx"> {
</span><span class="cx"> var component = "[" + indexString + "]";
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendMapKey: function(object)
</del><ins>+ appendMapKey(object)
</ins><span class="cx"> {
</span><span class="cx"> var component = WebInspector.PropertyPath.SpecialPathComponent.MapKey;
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendMapValue: function(object, keyObject)
</del><ins>+ appendMapValue(object, keyObject)
</ins><span class="cx"> {
</span><span class="cx"> console.assert(!keyObject || keyObject instanceof WebInspector.RemoteObject);
</span><span class="cx">
</span><span class="lines">@@ -225,13 +225,13 @@
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendSetIndex: function(object)
</del><ins>+ appendSetIndex(object)
</ins><span class="cx"> {
</span><span class="cx"> var component = WebInspector.PropertyPath.SpecialPathComponent.SetIndex;
</span><span class="cx"> return new WebInspector.PropertyPath(object, component, this);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendPropertyDescriptor: function(object, descriptor, type)
</del><ins>+ appendPropertyDescriptor(object, descriptor, type)
</ins><span class="cx"> {
</span><span class="cx"> if (descriptor.isInternalProperty)
</span><span class="cx"> return this.appendInternalPropertyName(object, descriptor.name);
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _canPropertyNameBeDotAccess: function(propertyName)
</del><ins>+ _canPropertyNameBeDotAccess(propertyName)
</ins><span class="cx"> {
</span><span class="cx"> return /^(?![0-9])\w+$/.test(propertyName);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectPreviewViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -85,13 +85,13 @@
</span><span class="cx"> return this._lossless;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- showTitle: function()
</del><ins>+ showTitle()
</ins><span class="cx"> {
</span><span class="cx"> this._titleElement.hidden = false;
</span><span class="cx"> this._previewElement.hidden = true;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- showPreview: function()
</del><ins>+ showPreview()
</ins><span class="cx"> {
</span><span class="cx"> this._titleElement.hidden = true;
</span><span class="cx"> this._previewElement.hidden = false;
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _initTitleElement: function()
</del><ins>+ _initTitleElement()
</ins><span class="cx"> {
</span><span class="cx"> // Display null / regexps as simple formatted values even in title.
</span><span class="cx"> if (this._preview.subtype === "regexp" || this._preview.subtype === "null")
</span><span class="lines">@@ -108,12 +108,12 @@
</span><span class="cx"> this._titleElement.textContent = this._preview.description || "";
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _numberOfPropertiesToShowInMode: function()
</del><ins>+ _numberOfPropertiesToShowInMode()
</ins><span class="cx"> {
</span><span class="cx"> return this._mode === WebInspector.ObjectPreviewView.Mode.Brief ? 3 : Infinity;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _appendPreview: function(element, preview)
</del><ins>+ _appendPreview(element, preview)
</ins><span class="cx"> {
</span><span class="cx"> var displayObjectAsValue = false;
</span><span class="cx"> if (preview.type === "object") {
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> return this._appendValuePreview(bodyElement, preview);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _appendEntryPreviews: function(element, preview)
</del><ins>+ _appendEntryPreviews(element, preview)
</ins><span class="cx"> {
</span><span class="cx"> var lossless = preview.lossless && !preview.propertyPreviews.length;
</span><span class="cx">
</span><span class="lines">@@ -171,7 +171,7 @@
</span><span class="cx"> return lossless;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _appendPropertyPreviews: function(element, preview)
</del><ins>+ _appendPropertyPreviews(element, preview)
</ins><span class="cx"> {
</span><span class="cx"> // Do not show Error properties in previews. They are more useful in full views.
</span><span class="cx"> if (preview.subtype === "error")
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx"> return preview.lossless;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _appendValuePreview: function(element, preview)
</del><ins>+ _appendValuePreview(element, preview)
</ins><span class="cx"> {
</span><span class="cx"> element.appendChild(WebInspector.FormattedValue.createElementForObjectPreview(preview));
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeArrayIndexTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- invokedGetter: function()
</del><ins>+ invokedGetter()
</ins><span class="cx"> {
</span><span class="cx"> this.mainTitle = this._titleFragment();
</span><span class="cx">
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _titleFragment: function()
</del><ins>+ _titleFragment()
</ins><span class="cx"> {
</span><span class="cx"> var container = document.createDocumentFragment();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeBaseTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -58,12 +58,12 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- oncontextmenu: function(event)
</del><ins>+ oncontextmenu(event)
</ins><span class="cx"> {
</span><span class="cx"> this._contextMenuHandler(event);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- resolvedValue: function()
</del><ins>+ resolvedValue()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this._property);
</span><span class="cx"> if (this._getterValue)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> return null;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- resolvedValuePropertyPath: function()
</del><ins>+ resolvedValuePropertyPath()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this._property);
</span><span class="cx"> if (this._getterValue)
</span><span class="lines">@@ -83,19 +83,19 @@
</span><span class="cx"> return null;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- thisPropertyPath: function()
</del><ins>+ thisPropertyPath()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this._property);
</span><span class="cx"> return this._propertyPath.appendPropertyDescriptor(null, this._property, this.propertyPathType());
</span><span class="cx"> },
</span><span class="cx">
</span><del>- hadError: function()
</del><ins>+ hadError()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this._property);
</span><span class="cx"> return this._property.wasThrown || this._getterHadError;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- propertyPathType: function()
</del><ins>+ propertyPathType()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this._property);
</span><span class="cx"> if (this._getterValue || this._property.hasValue())
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> return WebInspector.PropertyPath.Type.Value;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- propertyPathString: function(propertyPath)
</del><ins>+ propertyPathString(propertyPath)
</ins><span class="cx"> {
</span><span class="cx"> if (propertyPath.isFullPathImpossible())
</span><span class="cx"> return WebInspector.UIString("Unable to determine path to property from root");
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> return propertyPath.displayPath(this.propertyPathType());
</span><span class="cx"> },
</span><span class="cx">
</span><del>- createInteractiveGetterElement: function()
</del><ins>+ createInteractiveGetterElement()
</ins><span class="cx"> {
</span><span class="cx"> var getterElement = document.createElement("img");
</span><span class="cx"> getterElement.className = "getter";
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> return getterElement;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- createReadOnlyIconElement: function()
</del><ins>+ createReadOnlyIconElement()
</ins><span class="cx"> {
</span><span class="cx"> var readOnlyElement = document.createElement("img");
</span><span class="cx"> readOnlyElement.className = "read-only";
</span><span class="lines">@@ -146,7 +146,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _logValue: function(value)
</del><ins>+ _logValue(value)
</ins><span class="cx"> {
</span><span class="cx"> var resolvedValue = value || this.resolvedValue();
</span><span class="cx"> if (!resolvedValue)
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> WebInspector.consoleLogViewController.appendImmediateExecutionWithResult(text, resolvedValue);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _contextMenuHandler: function(event)
</del><ins>+ _contextMenuHandler(event)
</ins><span class="cx"> {
</span><span class="cx"> var resolvedValue = this.resolvedValue();
</span><span class="cx"> if (!resolvedValue)
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx"> contextMenu.show();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _appendMenusItemsForObject: function(contextMenu, resolvedValue)
</del><ins>+ _appendMenusItemsForObject(contextMenu, resolvedValue)
</ins><span class="cx"> {
</span><span class="cx"> if (resolvedValue.type === "function") {
</span><span class="cx"> // FIXME: We should better handle bound functions.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeMapEntryTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -50,19 +50,19 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- resolvedValue: function()
</del><ins>+ resolvedValue()
</ins><span class="cx"> {
</span><span class="cx"> return this._object;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- propertyPathType: function()
</del><ins>+ propertyPathType()
</ins><span class="cx"> {
</span><span class="cx"> return WebInspector.PropertyPath.Type.Value;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _titleFragment: function()
</del><ins>+ _titleFragment()
</ins><span class="cx"> {
</span><span class="cx"> var container = document.createDocumentFragment();
</span><span class="cx">
</span><span class="lines">@@ -96,12 +96,12 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- displayPropertyName: function()
</del><ins>+ displayPropertyName()
</ins><span class="cx"> {
</span><span class="cx"> return WebInspector.UIString("key");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- resolvedValuePropertyPath: function()
</del><ins>+ resolvedValuePropertyPath()
</ins><span class="cx"> {
</span><span class="cx"> return this._propertyPath.appendMapKey(this._object);
</span><span class="cx"> }
</span><span class="lines">@@ -121,12 +121,12 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- displayPropertyName: function()
</del><ins>+ displayPropertyName()
</ins><span class="cx"> {
</span><span class="cx"> return WebInspector.UIString("value");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- resolvedValuePropertyPath: function()
</del><ins>+ resolvedValuePropertyPath()
</ins><span class="cx"> {
</span><span class="cx"> return this._propertyPath.appendMapValue(this._object, this._key);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -55,24 +55,24 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- onpopulate: function()
</del><ins>+ onpopulate()
</ins><span class="cx"> {
</span><span class="cx"> this._updateChildren();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- onexpand: function()
</del><ins>+ onexpand()
</ins><span class="cx"> {
</span><span class="cx"> if (this._previewView)
</span><span class="cx"> this._previewView.showTitle();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- oncollapse: function()
</del><ins>+ oncollapse()
</ins><span class="cx"> {
</span><span class="cx"> if (this._previewView)
</span><span class="cx"> this._previewView.showPreview();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- invokedGetter: function()
</del><ins>+ invokedGetter()
</ins><span class="cx"> {
</span><span class="cx"> this.mainTitle = this._titleFragment();
</span><span class="cx">
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _updateHasChildren: function()
</del><ins>+ _updateHasChildren()
</ins><span class="cx"> {
</span><span class="cx"> var resolvedValue = this.resolvedValue();
</span><span class="cx"> var valueHasChildren = (resolvedValue && resolvedValue.hasChildren);
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> this.hasChildren = !wasThrown && valueHasChildren && (this.property.name === "__proto__" || this._alwaysDisplayAsProperty());
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateTooltips: function()
</del><ins>+ _updateTooltips()
</ins><span class="cx"> {
</span><span class="cx"> var attributes = [];
</span><span class="cx">
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> this.iconElement.title = attributes.join(" ");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _titleFragment: function()
</del><ins>+ _titleFragment()
</ins><span class="cx"> {
</span><span class="cx"> if (this.property.name === "__proto__")
</span><span class="cx"> return this._createTitlePrototype();
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> return this._createTitleAPIStyle();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _createTitlePrototype: function()
</del><ins>+ _createTitlePrototype()
</ins><span class="cx"> {
</span><span class="cx"> console.assert(this.property.hasValue());
</span><span class="cx"> console.assert(this.property.name === "__proto__");
</span><span class="lines">@@ -138,7 +138,7 @@
</span><span class="cx"> return nameElement;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _createTitlePropertyStyle: function()
</del><ins>+ _createTitlePropertyStyle()
</ins><span class="cx"> {
</span><span class="cx"> var container = document.createDocumentFragment();
</span><span class="cx">
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx"> return container;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _createTitleAPIStyle: function()
</del><ins>+ _createTitleAPIStyle()
</ins><span class="cx"> {
</span><span class="cx"> // Fixed values and special properties display like a property.
</span><span class="cx"> if (this._alwaysDisplayAsProperty())
</span><span class="lines">@@ -222,7 +222,7 @@
</span><span class="cx"> return container;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _alwaysDisplayAsProperty: function()
</del><ins>+ _alwaysDisplayAsProperty()
</ins><span class="cx"> {
</span><span class="cx"> // Constructor, though a function, is often better treated as an expandable object.
</span><span class="cx"> if (this.property.name === "constructor")
</span><span class="lines">@@ -239,12 +239,12 @@
</span><span class="cx"> return false;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _functionPropertyString: function()
</del><ins>+ _functionPropertyString()
</ins><span class="cx"> {
</span><span class="cx"> return "function" + this._functionParameterString();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _functionParameterString: function()
</del><ins>+ _functionParameterString()
</ins><span class="cx"> {
</span><span class="cx"> var resolvedValue = this.resolvedValue();
</span><span class="cx"> console.assert(resolvedValue.type === "function");
</span><span class="lines">@@ -276,7 +276,7 @@
</span><span class="cx"> return match ? match[1] : "()";
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _sanitizedPrototypeString: function(value)
</del><ins>+ _sanitizedPrototypeString(value)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: <https://webkit.org/b/141610> For many X, X.prototype is an X when it must be a plain object
</span><span class="cx"> if (value.type === "function")
</span><span class="lines">@@ -289,7 +289,7 @@
</span><span class="cx"> return value.description.replace(/Prototype$/, "");
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateChildren: function()
</del><ins>+ _updateChildren()
</ins><span class="cx"> {
</span><span class="cx"> if (this.children.length && !this.shouldRefreshChildren)
</span><span class="cx"> return;
</span><span class="lines">@@ -303,7 +303,7 @@
</span><span class="cx"> resolvedValue.getDisplayablePropertyDescriptors(this._updateChildrenInternal.bind(this, this._updateProperties, this._mode));
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateChildrenInternal: function(handler, mode, list)
</del><ins>+ _updateChildrenInternal(handler, mode, list)
</ins><span class="cx"> {
</span><span class="cx"> this.removeChildren();
</span><span class="cx">
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx"> handler.call(this, list, this.resolvedValuePropertyPath(), mode);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateEntries: function(entries, propertyPath, mode)
</del><ins>+ _updateEntries(entries, propertyPath, mode)
</ins><span class="cx"> {
</span><span class="cx"> for (var entry of entries) {
</span><span class="cx"> if (entry.key) {
</span><span class="lines">@@ -339,7 +339,7 @@
</span><span class="cx"> }.bind(this));
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateProperties: function(properties, propertyPath, mode)
</del><ins>+ _updateProperties(properties, propertyPath, mode)
</ins><span class="cx"> {
</span><span class="cx"> properties.sort(WebInspector.ObjectTreeView.ComparePropertyDescriptors);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeSetIndexTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeSetIndexTreeElement.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -49,19 +49,19 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- resolvedValue: function()
</del><ins>+ resolvedValue()
</ins><span class="cx"> {
</span><span class="cx"> return this._object;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- resolvedValuePropertyPath: function()
</del><ins>+ resolvedValuePropertyPath()
</ins><span class="cx"> {
</span><span class="cx"> return this.propertyPath.appendSetIndex(this._object);
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _titleFragment: function()
</del><ins>+ _titleFragment()
</ins><span class="cx"> {
</span><span class="cx"> var container = document.createDocumentFragment();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreeViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js (181185 => 181186)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js 2015-03-06 22:41:11 UTC (rev 181185)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js 2015-03-06 22:41:15 UTC (rev 181186)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> return this._expanded;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- expand: function()
</del><ins>+ expand()
</ins><span class="cx"> {
</span><span class="cx"> if (this._expanded)
</span><span class="cx"> return;
</span><span class="lines">@@ -172,7 +172,7 @@
</span><span class="cx"> this.update();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- collapse: function()
</del><ins>+ collapse()
</ins><span class="cx"> {
</span><span class="cx"> if (!this._expanded)
</span><span class="cx"> return;
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx"> this._untrackWeakEntries();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- appendTitleSuffix: function(suffixElement)
</del><ins>+ appendTitleSuffix(suffixElement)
</ins><span class="cx"> {
</span><span class="cx"> if (this._previewView)
</span><span class="cx"> this._previewView.element.appendChild(suffixElement);
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><del>- update: function()
</del><ins>+ update()
</ins><span class="cx"> {
</span><span class="cx"> if (this._object.isCollectionType() && this._mode === WebInspector.ObjectTreeView.Mode.Properties)
</span><span class="cx"> this._object.getCollectionEntries(0, 100, this._updateChildren.bind(this, this._updateEntries));
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx">
</span><span class="cx"> // Private
</span><span class="cx">
</span><del>- _updateChildren: function(handler, list)
</del><ins>+ _updateChildren(handler, list)
</ins><span class="cx"> {
</span><span class="cx"> this._outline.removeChildren();
</span><span class="cx">
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> handler.call(this, list, this._propertyPath);
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateEntries: function(entries, propertyPath)
</del><ins>+ _updateEntries(entries, propertyPath)
</ins><span class="cx"> {
</span><span class="cx"> for (var entry of entries) {
</span><span class="cx"> if (entry.key) {
</span><span class="lines">@@ -241,7 +241,7 @@
</span><span class="cx"> }.bind(this));
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateProperties: function(properties, propertyPath)
</del><ins>+ _updateProperties(properties, propertyPath)
</ins><span class="cx"> {
</span><span class="cx"> properties.sort(WebInspector.ObjectTreeView.ComparePropertyDescriptors);
</span><span class="cx">
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _handlePreviewOrTitleElementClick: function(event)
</del><ins>+ _handlePreviewOrTitleElementClick(event)
</ins><span class="cx"> {
</span><span class="cx"> if (this._hasLosslessPreview)
</span><span class="cx"> return;
</span><span class="lines">@@ -277,7 +277,7 @@
</span><span class="cx"> event.stopPropagation();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _trackWeakEntries: function()
</del><ins>+ _trackWeakEntries()
</ins><span class="cx"> {
</span><span class="cx"> if (this._trackingEntries)
</span><span class="cx"> return;
</span><span class="lines">@@ -294,7 +294,7 @@
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _untrackWeakEntries: function()
</del><ins>+ _untrackWeakEntries()
</ins><span class="cx"> {
</span><span class="cx"> if (!this._trackingEntries)
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>