<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181167] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181167">181167</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2015-03-06 10:21:36 -0800 (Fri, 06 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Test horiz-origin-x and horiz-origin-y in SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=142403
Source/WebCore:
Reviewed by Simon Fraser.
Remove incorrect comment.
Test: svg/fonts/svg-font-horiz-origin.html
* svg/SVGToOTFFontConversion.cpp:
(WebCore::CFFBuilder::CFFBuilder):
LayoutTests:
Simply moving to the origin in glyph-space at the beginning
of path parsing won't work if subsequent coordinates are absolute.
Reviewed by Simon Fraser.
* svg/fonts/resources/svg-font-horiz-origin-font.svg: Added.
* svg/fonts/svg-font-horiz-origin-expected.html: Added.
* svg/fonts/svg-font-horiz-origin.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGToOTFFontConversioncpp">trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/svg/fonts/</li>
<li>trunk/LayoutTests/svg/fonts/resources/</li>
<li><a href="#trunkLayoutTestssvgfontsresourcessvgfonthorizoriginfontsvg">trunk/LayoutTests/svg/fonts/resources/svg-font-horiz-origin-font.svg</a></li>
<li><a href="#trunkLayoutTestssvgfontssvgfonthorizoriginexpectedhtml">trunk/LayoutTests/svg/fonts/svg-font-horiz-origin-expected.html</a></li>
<li><a href="#trunkLayoutTestssvgfontssvgfonthorizoriginhtml">trunk/LayoutTests/svg/fonts/svg-font-horiz-origin.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (181166 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-06 18:20:40 UTC (rev 181166)
+++ trunk/LayoutTests/ChangeLog 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-03-06 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Test horiz-origin-x and horiz-origin-y in SVG fonts
+ https://bugs.webkit.org/show_bug.cgi?id=142403
+
+ Simply moving to the origin in glyph-space at the beginning
+ of path parsing won't work if subsequent coordinates are absolute.
+
+ Reviewed by Simon Fraser.
+
+ * svg/fonts/resources/svg-font-horiz-origin-font.svg: Added.
+ * svg/fonts/svg-font-horiz-origin-expected.html: Added.
+ * svg/fonts/svg-font-horiz-origin.html: Added.
+
</ins><span class="cx"> 2015-03-06 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> An SVG element without intrinsic size inherits the container size as its viewport instead of inheriting the container viewport.
</span></span></pre></div>
<a id="trunkLayoutTestssvgfontsresourcessvgfonthorizoriginfontsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/fonts/resources/svg-font-horiz-origin-font.svg (0 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/fonts/resources/svg-font-horiz-origin-font.svg (rev 0)
+++ trunk/LayoutTests/svg/fonts/resources/svg-font-horiz-origin-font.svg 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<?xml version="1.0" standalone="yes"?>
+<svg version="1.1" viewBox="0 0 160 160" xmlns = 'http://www.w3.org/2000/svg' xmlns:xlink="http://www.w3.org/1999/xlink">
+ <defs>
+ <font id="Litherum" horiz-adv-x="1000">
+ <font-face font-family="Litherum" font-weight="normal" font-style="normal" units-per-em="1000" cap-height="600" x-height="400" ascent="1000" descent="0" alphabetic="0" mathematical="500" ideographic="400" hanging="500">
+ <font-face-src>
+ <font-face-name name="Litherum"/>
+ </font-face-src>
+ </font-face>
+ <glyph unicode="A" horiz-adv-x="1000" d="M 500 0 H 1000 V 600 H 500 z"/>
+ </font>
+ <font id="Litherum2" horiz-adv-x="1000" horiz-origin-x="500" horiz-origin-y="300">
+ <font-face font-family="Litherum" font-weight="normal" font-style="normal" units-per-em="1000" cap-height="600" x-height="400" ascent="1000" descent="0" alphabetic="0" mathematical="500" ideographic="400" hanging="500">
+ <font-face-src>
+ <font-face-name name="Litherum"/>
+ </font-face-src>
+ </font-face>
+ <glyph unicode="A" horiz-adv-x="1000" d="M 0 -300 H 500 V 300 H 0 z"/>
+ </font>
+ </defs>
+</svg>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgfontssvgfonthorizoriginexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/fonts/svg-font-horiz-origin-expected.html (0 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/fonts/svg-font-horiz-origin-expected.html (rev 0)
+++ trunk/LayoutTests/svg/fonts/svg-font-horiz-origin-expected.html 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+@font-face {
+ font-family: 'Litherum';
+ src: url("resources/svg-font-horiz-origin-font.svg#Litherum2") format(svg)
+}
+</style>
+</head>
+<body>
+This test makes sure that the horiz-origin-x and horiz-origin-y attributes are correctly converted.
+<div><span style="font: 48px Litherum;">AAA</span>AAA</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgfontssvgfonthorizoriginhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/fonts/svg-font-horiz-origin.html (0 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/fonts/svg-font-horiz-origin.html (rev 0)
+++ trunk/LayoutTests/svg/fonts/svg-font-horiz-origin.html 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+@font-face {
+ font-family: 'Litherum';
+ src: url("resources/svg-font-horiz-origin-font.svg#Litherum") format(svg)
+}
+</style>
+</head>
+<body>
+This test makes sure that the horiz-origin-x and horiz-origin-y attributes are correctly converted.
+<div><span style="font: 48px Litherum;">AAA</span>AAA</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181166 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-06 18:20:40 UTC (rev 181166)
+++ trunk/Source/WebCore/ChangeLog 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-03-06 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Test horiz-origin-x and horiz-origin-y in SVG fonts
+ https://bugs.webkit.org/show_bug.cgi?id=142403
+
+ Reviewed by Simon Fraser.
+
+ Remove incorrect comment.
+
+ Test: svg/fonts/svg-font-horiz-origin.html
+
+ * svg/SVGToOTFFontConversion.cpp:
+ (WebCore::CFFBuilder::CFFBuilder):
+
</ins><span class="cx"> 2015-03-06 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Allow tree dumping functions to be used in release builds by switching a flag
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGToOTFFontConversioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp (181166 => 181167)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2015-03-06 18:20:40 UTC (rev 181166)
+++ trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2015-03-06 18:21:36 UTC (rev 181167)
</span><span class="lines">@@ -1051,7 +1051,6 @@
</span><span class="cx"> : m_cffData(cffData)
</span><span class="cx"> , m_hasBoundingBox(false)
</span><span class="cx"> {
</span><del>- // FIXME: Moving to the origin isn't going to work for subsequent absolute coordinates
</del><span class="cx"> writeCFFEncodedNumber(m_cffData, width);
</span><span class="cx"> writeCFFEncodedNumber(m_cffData, origin.x());
</span><span class="cx"> writeCFFEncodedNumber(m_cffData, origin.y());
</span></span></pre>
</div>
</div>
</body>
</html>