<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[181072] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/181072">181072</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2015-03-05 00:56:22 -0800 (Thu, 05 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>TextCheckingParagraph::isEmpty() is sufficient to check whether paragraph is empty
https://bugs.webkit.org/show_bug.cgi?id=142276
Reviewed by Darin Adler.
TextCheckingParagraph::isEmpty() already calls TextCheckingParagraph::isRangeEmpty().
There is no need to call them both at the caller site.
No new tests. No behavior change.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
Update caller site.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::isEmpty):
Avoid using helepers here to get rid of them as they are
no longer needed outside TextCheckingParagraph.
* editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::isTextEmpty): Deleted.
(WebCore::TextCheckingParagraph::isRangeEmpty): Deleted.
Do not expose isTextEmpty() and isRangeEmpty().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingTextCheckingHelpercpp">trunk/Source/WebCore/editing/TextCheckingHelper.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingTextCheckingHelperh">trunk/Source/WebCore/editing/TextCheckingHelper.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (181071 => 181072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-03-05 08:51:52 UTC (rev 181071)
+++ trunk/Source/WebCore/ChangeLog 2015-03-05 08:56:22 UTC (rev 181072)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2015-03-05 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ TextCheckingParagraph::isEmpty() is sufficient to check whether paragraph is empty
+ https://bugs.webkit.org/show_bug.cgi?id=142276
+
+ Reviewed by Darin Adler.
+
+ TextCheckingParagraph::isEmpty() already calls TextCheckingParagraph::isRangeEmpty().
+ There is no need to call them both at the caller site.
+
+ No new tests. No behavior change.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
+ Update caller site.
+
+ * editing/TextCheckingHelper.cpp:
+ (WebCore::TextCheckingParagraph::isEmpty):
+ Avoid using helepers here to get rid of them as they are
+ no longer needed outside TextCheckingParagraph.
+
+ * editing/TextCheckingHelper.h:
+ (WebCore::TextCheckingParagraph::isTextEmpty): Deleted.
+ (WebCore::TextCheckingParagraph::isRangeEmpty): Deleted.
+ Do not expose isTextEmpty() and isRangeEmpty().
+
</ins><span class="cx"> 2015-03-04 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Clarify RenderElement::adjustStyleDifference()
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (181071 => 181072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2015-03-05 08:51:52 UTC (rev 181071)
+++ trunk/Source/WebCore/editing/Editor.cpp 2015-03-05 08:56:22 UTC (rev 181072)
</span><span class="lines">@@ -2352,7 +2352,7 @@
</span><span class="cx">
</span><span class="cx"> Range* rangeToCheck = shouldMarkGrammar ? grammarRange : spellingRange;
</span><span class="cx"> TextCheckingParagraph paragraphToCheck(rangeToCheck);
</span><del>- if (paragraphToCheck.isRangeEmpty() || paragraphToCheck.isEmpty())
</del><ins>+ if (paragraphToCheck.isEmpty())
</ins><span class="cx"> return;
</span><span class="cx"> RefPtr<Range> paragraphRange = paragraphToCheck.paragraphRange();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingTextCheckingHelpercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/TextCheckingHelper.cpp (181071 => 181072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2015-03-05 08:51:52 UTC (rev 181071)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2015-03-05 08:56:22 UTC (rev 181072)
</span><span class="lines">@@ -184,7 +184,7 @@
</span><span class="cx"> {
</span><span class="cx"> // Both predicates should have same result, but we check both just for sure.
</span><span class="cx"> // We need to investigate to remove this redundancy.
</span><del>- return isRangeEmpty() || isTextEmpty();
</del><ins>+ return checkingStart() >= checkingEnd() || text().isEmpty();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Range> TextCheckingParagraph::offsetAsRange() const
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingTextCheckingHelperh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/TextCheckingHelper.h (181071 => 181072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/TextCheckingHelper.h 2015-03-05 08:51:52 UTC (rev 181071)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.h 2015-03-05 08:56:22 UTC (rev 181072)
</span><span class="lines">@@ -50,10 +50,8 @@
</span><span class="cx"> int textLength() const { return text().length(); }
</span><span class="cx"> String textSubstring(unsigned pos, unsigned len = UINT_MAX) const { return text().substring(pos, len); }
</span><span class="cx"> UChar textCharAt(int index) const { return text()[static_cast<unsigned>(index)]; }
</span><del>- bool isTextEmpty() const { return text().isEmpty(); }
</del><span class="cx">
</span><span class="cx"> bool isEmpty() const;
</span><del>- bool isRangeEmpty() const { return checkingStart() >= checkingEnd(); }
</del><span class="cx">
</span><span class="cx"> int checkingStart() const;
</span><span class="cx"> int checkingEnd() const;
</span></span></pre>
</div>
</div>
</body>
</html>