<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180957] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180957">180957</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-03 14:43:34 -0800 (Tue, 03 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Convert ManualTests/svg-tooltip.svg to a DRT test
https://bugs.webkit.org/show_bug.cgi?id=140480
Patch by Daniel Bates <dabates@apple.com> on 2015-03-03
Reviewed by Alex Christensen.
.:
* ManualTests/svg-tooltip.svg: Removed.
LayoutTests:
* svg/hittest/svg-tooltip-expected.txt: Added.
* svg/hittest/svg-tooltip.svg: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvghittestsvgtooltipexpectedtxt">trunk/LayoutTests/svg/hittest/svg-tooltip-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvghittestsvgtooltipsvg">trunk/LayoutTests/svg/hittest/svg-tooltip.svg</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkManualTestssvgtooltipsvg">trunk/ManualTests/svg-tooltip.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (180956 => 180957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2015-03-03 22:35:14 UTC (rev 180956)
+++ trunk/ChangeLog 2015-03-03 22:43:34 UTC (rev 180957)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2015-03-03 Daniel Bates <dabates@apple.com>
+
+ Convert ManualTests/svg-tooltip.svg to a DRT test
+ https://bugs.webkit.org/show_bug.cgi?id=140480
+
+ Reviewed by Alex Christensen.
+
+ * ManualTests/svg-tooltip.svg: Removed.
+
</ins><span class="cx"> 2015-03-02 Debarshi Ray <debarshir@gnome.org>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r179409): [GTK] Undefined symbol prevents web extensions from being loaded
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (180956 => 180957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-03-03 22:35:14 UTC (rev 180956)
+++ trunk/LayoutTests/ChangeLog 2015-03-03 22:43:34 UTC (rev 180957)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-03-03 Daniel Bates <dabates@apple.com>
+
+ Convert ManualTests/svg-tooltip.svg to a DRT test
+ https://bugs.webkit.org/show_bug.cgi?id=140480
+
+ Reviewed by Alex Christensen.
+
+ * svg/hittest/svg-tooltip-expected.txt: Added.
+ * svg/hittest/svg-tooltip.svg: Added.
+
</ins><span class="cx"> 2015-03-03 Timothy Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> <attachment> label can get very wide, doesn't wrap/truncate
</span></span></pre></div>
<a id="trunkLayoutTestssvghittestsvgtooltipexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/hittest/svg-tooltip-expected.txt (0 => 180957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/hittest/svg-tooltip-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/hittest/svg-tooltip-expected.txt 2015-03-03 22:43:34 UTC (rev 180957)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+PASS document.title is 'SVG Tooltips'.
+PASS tooltip for <ellipse id="e1"> is 'PASS'.
+PASS tooltip for <ellipse id="e2"> is 'PASS'.
+PASS tooltip for <ellipse id="e3"> is 'PASS'.
+PASS tooltip for <use id="e4"> is ''.
+PASS tooltip for <use id="e5"> is 'PASS'.
+PASS tooltip for <ellipse id="e6"> is 'PASS'.
+PASS tooltip for <use id="e7"> is ''.
+PASS tooltip for <use id="e8"> is 'PASS'.
+
</ins></span></pre></div>
<a id="trunkLayoutTestssvghittestsvgtooltipsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/hittest/svg-tooltip.svg (0 => 180957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/hittest/svg-tooltip.svg (rev 0)
+++ trunk/LayoutTests/svg/hittest/svg-tooltip.svg 2015-03-03 22:43:34 UTC (rev 180957)
</span><span class="lines">@@ -0,0 +1,120 @@
</span><ins>+<?xml version="1.0"?>
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <style type="text/css">
+ <![CDATA[
+ text {
+ display: block;
+ }
+ ]]>
+ </style>
+ <script type="text/javascript">
+ <![CDATA[
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function log(message)
+ {
+ document.getElementById("log").appendChild(document.createTextNode(message + "\n"))
+ }
+
+ function testTooltipForElement(element)
+ {
+ console.assert(window.internals);
+ console.assert(element.id);
+ var testCaseName = "<" + element.tagName + ' id="' + element.id + '"' + ">";
+ var tooltip = internals.toolTipFromElement(element);
+ var expectedTooltip = element.getAttribute("data-expected-tooltip");
+ if (tooltip == expectedTooltip)
+ log("PASS tooltip for " + testCaseName + " is '" + expectedTooltip + "'.");
+ else
+ log("FAIL tooltip for " + testCaseName + " should be '" + expectedTooltip + "'. Was '" + tooltip + "'.");
+ }
+
+ function testDocumentTitle()
+ {
+ var expectedTitle = document.getElementById("expected-document-title").textContent;
+ if (document.title == expectedTitle)
+ log("PASS document.title is '" + expectedTitle + "'.");
+ else
+ log("FAIL document.title should be '" + expectedTitle + "'. Was '" + document.title + "'.");
+ }
+
+ function runTest()
+ {
+ if (!window.testRunner || !window.internals)
+ return;
+
+ testDocumentTitle();
+ var testCases = document.querySelectorAll(".test-case");
+ for (var i = 0; i < testCases.length; ++i)
+ testTooltipForElement(testCases[i]);
+
+ // Hide all <text> elements that describe the expected result for a human as they are not applicable
+ // when running this test in DRT/WTR.
+ document.styleSheets[0].rules[0].style.display = "none";
+ }
+
+ window.onload = runTest;
+ ]]>
+ </script>
+ <title id="expected-document-title">SVG Tooltips</title>
+ <defs>
+ <ellipse id="e4" cx="100" cy="200" rx="50" ry="30" fill="blue">
+ <title>PASS</title>
+ </ellipse>
+ <ellipse id="e5" cx="250" cy="200" rx="50" ry="30" fill="blue">
+ <title>FAIL</title>
+ </ellipse>
+ <symbol id="e7">
+ <ellipse cx="100" cy="300" rx="50" ry="30" fill="blue">
+ <title>PASS</title>
+ </ellipse>
+ </symbol>
+ <symbol id="e8">
+ <title>FAIL</title>
+ <ellipse cx="250" cy="300" rx="50" ry="30" fill="blue">
+ </ellipse>
+ </symbol>
+ </defs>
+
+ <text y="15" x="0" id="manual-instructions">Hover the cursor over each shape (below). This test passed if the tooltip for each shape that has a tooltip is "PASS". Otherwise, this test failed.</text>
+
+ <ellipse id="e1" cx="100" cy="100" rx="50" ry="30" fill="blue" class="test-case" data-expected-tooltip="PASS">
+ <title>PASS</title>
+ </ellipse>
+
+ <g>
+ <title>PASS</title>
+ <ellipse id="e2" cx="250" cy="100" rx="50" ry="30" fill="blue" class="test-case" data-expected-tooltip="PASS"/>
+ </g>
+
+ <a xlink:title="PASS" xlink:href="#">
+ <title>FAIL</title>
+ <ellipse id="e3" cx="400" cy="100" rx="50" ry="30" fill="blue" class="test-case" data-expected-tooltip="PASS"/>
+ </a>
+
+ <use id="e4" xlink:href="#e4" class="test-case" data-expected-tooltip=""/>
+ <text x="100" y="200" text-anchor="middle" fill="white">(no tooltip)</text>
+
+ <use id="e5" xlink:href="#e5" class="test-case" data-expected-tooltip="PASS">
+ <title>PASS</title>
+ </use>
+
+ <g>
+ <title>FAIL</title>
+ <ellipse id="e6" cx="400" cy="200" rx="50" ry="30" fill="blue" class="test-case" data-expected-tooltip="PASS">
+ <title>PASS</title>
+ </ellipse>
+ </g>
+
+ <use id="e7" xlink:href="#e7" class="test-case" data-expected-tooltip=""/>
+ <text x="100" y="300" text-anchor="middle" fill="white">(no tooltip)</text>
+
+ <use id="e8" xlink:href="#e8" class="test-case" data-expected-tooltip="PASS">
+ <title>PASS</title>
+ </use>
+
+ <foreignObject y="400" width="600" height="400">
+ <pre id="log" xmlns="http://www.w3.org/1999/xhtml"></pre>
+ </foreignObject>
+</svg>
</ins></span></pre></div>
<a id="trunkManualTestssvgtooltipsvg"></a>
<div class="delfile"><h4>Deleted: trunk/ManualTests/svg-tooltip.svg (180956 => 180957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ManualTests/svg-tooltip.svg 2015-03-03 22:35:14 UTC (rev 180956)
+++ trunk/ManualTests/svg-tooltip.svg 2015-03-03 22:43:34 UTC (rev 180957)
</span><span class="lines">@@ -1,62 +0,0 @@
</span><del>-<?xml version="1.0"?>
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
- <title>This string should not show up as a tooltip</title>
- <desc>
- This test verifies that tooltips are properly rendered for SVG content in a variety of
- scenarios. Hovering over every shape should result in a tooltip of "PASS".
- </desc>
- <defs>
- <ellipse id="e1" cx="100" cy="200" rx="50" ry="30" fill="blue">
- <title>PASS</title>
- </ellipse>
- <ellipse id="e2" cx="250" cy="200" rx="50" ry="30" fill="blue">
- <title>FAIL</title>
- </ellipse>
- <symbol id="e3">
- <ellipse cx="100" cy="300" rx="50" ry="30" fill="blue">
- <title>PASS</title>
- </ellipse>
- </symbol>
- <symbol id="e4">
- <title>FAIL</title>
- <ellipse cx="250" cy="300" rx="50" ry="30" fill="blue">
- </ellipse>
- </symbol>
- </defs>
-
- <text y="15" x="0">When hovered, all shapes should show a "PASS" tooltip. Anything else is a failure.</text>
-
- <ellipse cx="100" cy="100" rx="50" ry="30" fill="blue">
- <title>PASS</title>
- </ellipse>
-
- <g>
- <title>PASS</title>
- <ellipse cx="250" cy="100" rx="50" ry="30" fill="blue"/>
- </g>
-
- <a xlink:title="PASS" xlink:href="#">
- <title>FAIL</title>
- <ellipse id="e4" cx="400" cy="100" rx="50" ry="30" fill="blue"/>
- </a>
-
- <use xlink:href="#e1"/>
-
- <use xlink:href="#e2">
- <title>PASS</title>
- </use>
-
- <g>
- <title>FAIL</title>
- <ellipse id="e8" cx="400" cy="200" rx="50" ry="30" fill="blue">
- <title>PASS</title>
- </ellipse>
- </g>
-
- <use xlink:href="#e3"/>
- <use xlink:href="#e4">
- <title>PASS</title>
- </use>
-
-
-</svg>
</del></span></pre>
</div>
</div>
</body>
</html>