<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180886] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180886">180886</a></dd>
<dt>Author</dt> <dd>jer.noble@apple.com</dd>
<dt>Date</dt> <dd>2015-03-02 09:39:10 -0800 (Mon, 02 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[WK2][Mac] WebPageProxy::supressVisibilityUpdates() should suppress visibility updates.
https://bugs.webkit.org/show_bug.cgi?id=141907
Reviewed by Tim Horton.
At some point, the window/view/page visibility update code was refactored such that setting
WebPageProxy::setSuppressVisibilityUpdate() no longer suppressed visibility updates. This causes
full screen animations to become "flashy" when moving the WebView between the regular and full
screen window, as a HTMLMediaElement in the full screen animation will receive a "!visible"
notification and disconnect its rendering pipeline.
In WebPageProxy::viewStateDidChange(), respect m_suppressVisibilityUpdates and bail out early
if set. In WebPageProxy::setSuppressVisibilityUpdates(), trigger an explicit update after
clearing m_suppressVisibilityUpdates.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setSuppressVisibilityUpdates):
(WebKit::WebPageProxy::viewStateDidChange):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setSuppressVisibilityUpdates): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (180885 => 180886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2015-03-02 17:37:14 UTC (rev 180885)
+++ trunk/Source/WebKit2/ChangeLog 2015-03-02 17:39:10 UTC (rev 180886)
</span><span class="lines">@@ -1,5 +1,28 @@
</span><span class="cx"> 2015-03-02 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><ins>+ [WK2][Mac] WebPageProxy::supressVisibilityUpdates() should suppress visibility updates.
+ https://bugs.webkit.org/show_bug.cgi?id=141907
+
+ Reviewed by Tim Horton.
+
+ At some point, the window/view/page visibility update code was refactored such that setting
+ WebPageProxy::setSuppressVisibilityUpdate() no longer suppressed visibility updates. This causes
+ full screen animations to become "flashy" when moving the WebView between the regular and full
+ screen window, as a HTMLMediaElement in the full screen animation will receive a "!visible"
+ notification and disconnect its rendering pipeline.
+
+ In WebPageProxy::viewStateDidChange(), respect m_suppressVisibilityUpdates and bail out early
+ if set. In WebPageProxy::setSuppressVisibilityUpdates(), trigger an explicit update after
+ clearing m_suppressVisibilityUpdates.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::setSuppressVisibilityUpdates):
+ (WebKit::WebPageProxy::viewStateDidChange):
+ * UIProcess/WebPageProxy.h:
+ (WebKit::WebPageProxy::setSuppressVisibilityUpdates): Deleted.
+
+2015-03-02 Jer Noble <jer.noble@apple.com>
+
</ins><span class="cx"> [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=142121
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (180885 => 180886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-03-02 17:37:14 UTC (rev 180885)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-03-02 17:39:10 UTC (rev 180886)
</span><span class="lines">@@ -1228,6 +1228,21 @@
</span><span class="cx"> m_pageClient.requestScroll(scrollPosition, isProgrammaticScroll);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebPageProxy::setSuppressVisibilityUpdates(bool flag)
+{
+ if (m_suppressVisibilityUpdates == flag)
+ return;
+ m_suppressVisibilityUpdates = flag;
+
+ if (!m_suppressVisibilityUpdates) {
+#if PLATFORM(COCOA)
+ m_viewStateChangeDispatcher->schedule();
+#else
+ dispatchViewStateChange();
+#endif
+ }
+}
+
</ins><span class="cx"> void WebPageProxy::updateViewState(ViewState::Flags flagsToUpdate)
</span><span class="cx"> {
</span><span class="cx"> m_viewState &= ~flagsToUpdate;
</span><span class="lines">@@ -1252,6 +1267,9 @@
</span><span class="cx"> m_potentiallyChangedViewStateFlags |= mayHaveChanged;
</span><span class="cx"> m_viewStateChangeWantsSynchronousReply = m_viewStateChangeWantsSynchronousReply || wantsSynchronousReply;
</span><span class="cx">
</span><ins>+ if (m_suppressVisibilityUpdates && dispatchMode != ViewStateChangeDispatchMode::Immediate)
+ return;
+
</ins><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx"> bool isNewlyInWindow = !isInWindow() && (mayHaveChanged & ViewState::IsInWindow) && m_pageClient.isViewInWindow();
</span><span class="cx"> if (dispatchMode == ViewStateChangeDispatchMode::Immediate || isNewlyInWindow) {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (180885 => 180886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2015-03-02 17:37:14 UTC (rev 180885)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2015-03-02 17:39:10 UTC (rev 180886)
</span><span class="lines">@@ -894,7 +894,7 @@
</span><span class="cx"> // WebPopupMenuProxy::Client
</span><span class="cx"> virtual NativeWebMouseEvent* currentlyProcessedMouseDownEvent() override;
</span><span class="cx">
</span><del>- void setSuppressVisibilityUpdates(bool flag) { m_suppressVisibilityUpdates = flag; }
</del><ins>+ void setSuppressVisibilityUpdates(bool flag);
</ins><span class="cx"> bool suppressVisibilityUpdates() { return m_suppressVisibilityUpdates; }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre>
</div>
</div>
</body>
</html>