<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180917] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180917">180917</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2015-03-02 20:05:05 -0800 (Mon, 02 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove op_get_callee, it's unused
https://bugs.webkit.org/show_bug.cgi?id=142206
Reviewed by Andreas Kling.
It's a bit of a shame that we stopped using this opcode since it gives us same-callee
profiling. But, if we were to add this functionality back in, we would almost certainly do
it by adding a JSFunction allocation watchpoint on FunctionExecutable.
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeUnconditionally):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee): Deleted.
(JSC::JIT::emitSlow_op_get_callee): Deleted.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee): Deleted.
(JSC::JIT::emitSlow_op_get_callee): Deleted.
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeBytecodeListjson">trunk/Source/JavaScriptCore/bytecode/BytecodeList.json</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeBytecodeUseDefh">trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockcpp">trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGByteCodeParsercpp">trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGCapabilitiescpp">trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITcpp">trunk/Source/JavaScriptCore/jit/JIT.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITh">trunk/Source/JavaScriptCore/jit/JIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITOpcodescpp">trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITOpcodes32_64cpp">trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorellintLowLevelInterpreter32_64asm">trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm</a></li>
<li><a href="#trunkSourceJavaScriptCorellintLowLevelInterpreter64asm">trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeCommonSlowPathscpp">trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/ChangeLog 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -1,3 +1,40 @@
</span><ins>+2015-03-02 Filip Pizlo <fpizlo@apple.com>
+
+ Remove op_get_callee, it's unused
+ https://bugs.webkit.org/show_bug.cgi?id=142206
+
+ Reviewed by Andreas Kling.
+
+ It's a bit of a shame that we stopped using this opcode since it gives us same-callee
+ profiling. But, if we were to add this functionality back in, we would almost certainly do
+ it by adding a JSFunction allocation watchpoint on FunctionExecutable.
+
+ * bytecode/BytecodeList.json:
+ * bytecode/BytecodeUseDef.h:
+ (JSC::computeUsesForBytecodeOffset):
+ (JSC::computeDefsForBytecodeOffset):
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpBytecode):
+ (JSC::CodeBlock::finalizeUnconditionally):
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::parseBlock):
+ * dfg/DFGCapabilities.cpp:
+ (JSC::DFG::capabilityLevel):
+ * jit/JIT.cpp:
+ (JSC::JIT::privateCompileMainPass):
+ (JSC::JIT::privateCompileSlowCases):
+ * jit/JIT.h:
+ * jit/JITOpcodes.cpp:
+ (JSC::JIT::emit_op_get_callee): Deleted.
+ (JSC::JIT::emitSlow_op_get_callee): Deleted.
+ * jit/JITOpcodes32_64.cpp:
+ (JSC::JIT::emit_op_get_callee): Deleted.
+ (JSC::JIT::emitSlow_op_get_callee): Deleted.
+ * llint/LowLevelInterpreter32_64.asm:
+ * llint/LowLevelInterpreter64.asm:
+ * runtime/CommonSlowPaths.cpp:
+ (JSC::SLOW_PATH_DECL): Deleted.
+
</ins><span class="cx"> 2015-03-02 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Context Menu to Log a Particular Object
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeBytecodeListjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/BytecodeList.json (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/BytecodeList.json 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/bytecode/BytecodeList.json 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -10,7 +10,6 @@
</span><span class="cx"> { "name" : "op_init_lazy_reg", "length" : 2 },
</span><span class="cx"> { "name" : "op_create_arguments", "length" : 3 },
</span><span class="cx"> { "name" : "op_create_this", "length" : 4 },
</span><del>- { "name" : "op_get_callee", "length" : 3 },
</del><span class="cx"> { "name" : "op_to_this", "length" : 4 },
</span><span class="cx"> { "name" : "op_new_object", "length" : 4 },
</span><span class="cx"> { "name" : "op_new_array", "length" : 5 },
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeBytecodeUseDefh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -49,7 +49,6 @@
</span><span class="cx"> case op_jmp:
</span><span class="cx"> case op_new_object:
</span><span class="cx"> case op_init_lazy_reg:
</span><del>- case op_get_callee:
</del><span class="cx"> case op_enter:
</span><span class="cx"> case op_catch:
</span><span class="cx"> case op_touch_entry:
</span><span class="lines">@@ -365,7 +364,6 @@
</span><span class="cx"> case op_mov:
</span><span class="cx"> case op_new_object:
</span><span class="cx"> case op_to_this:
</span><del>- case op_get_callee:
</del><span class="cx"> case op_init_lazy_reg:
</span><span class="cx"> case op_get_scope:
</span><span class="cx"> case op_create_arguments:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -772,12 +772,6 @@
</span><span class="cx"> printLocationOpAndRegisterOperand(out, exec, location, it, "init_lazy_reg", r0);
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>- case op_get_callee: {
- int r0 = (++it)->u.operand;
- printLocationOpAndRegisterOperand(out, exec, location, it, "get_callee", r0);
- ++it;
- break;
- }
</del><span class="cx"> case op_create_this: {
</span><span class="cx"> int r0 = (++it)->u.operand;
</span><span class="cx"> int r1 = (++it)->u.operand;
</span><span class="lines">@@ -2566,13 +2560,6 @@
</span><span class="cx"> curInstruction[3].u.toThisStatus = merge(
</span><span class="cx"> curInstruction[3].u.toThisStatus, ToThisClearedByGC);
</span><span class="cx"> break;
</span><del>- case op_get_callee:
- if (!curInstruction[2].u.jsCell || Heap::isMarked(curInstruction[2].u.jsCell.get()))
- break;
- if (Options::verboseOSR())
- dataLogF("Clearing LLInt get callee with function %p.\n", curInstruction[2].u.jsCell.get());
- curInstruction[2].u.jsCell.clear();
- break;
</del><span class="cx"> case op_resolve_scope: {
</span><span class="cx"> WriteBarrierBase<JSLexicalEnvironment>& lexicalEnvironment = curInstruction[6].u.lexicalEnvironment;
</span><span class="cx"> if (!lexicalEnvironment || Heap::isMarked(lexicalEnvironment.get()))
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGByteCodeParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -2690,22 +2690,6 @@
</span><span class="cx"> NEXT_OPCODE(op_new_regexp);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case op_get_callee: {
- JSCell* cachedFunction = currentInstruction[2].u.jsCell.get();
- if (!cachedFunction
- || m_inlineStackTop->m_profiledBlock->couldTakeSlowCase(m_currentIndex)
- || m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCell)) {
- set(VirtualRegister(currentInstruction[1].u.operand), get(VirtualRegister(JSStack::Callee)));
- } else {
- FrozenValue* frozen = m_graph.freeze(cachedFunction);
- ASSERT(cachedFunction->inherits(JSFunction::info()));
- Node* actualCallee = get(VirtualRegister(JSStack::Callee));
- addToGraph(CheckCell, OpInfo(frozen), actualCallee);
- set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(JSConstant, OpInfo(frozen)));
- }
- NEXT_OPCODE(op_get_callee);
- }
-
</del><span class="cx"> // === Bitwise operations ===
</span><span class="cx">
</span><span class="cx"> case op_bitand: {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGCapabilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -103,7 +103,6 @@
</span><span class="cx"> case op_touch_entry:
</span><span class="cx"> case op_to_this:
</span><span class="cx"> case op_create_this:
</span><del>- case op_get_callee:
</del><span class="cx"> case op_bitand:
</span><span class="cx"> case op_bitor:
</span><span class="cx"> case op_bitxor:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JIT.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JIT.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/jit/JIT.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -199,7 +199,6 @@
</span><span class="cx"> DEFINE_OP(op_construct_varargs)
</span><span class="cx"> DEFINE_OP(op_catch)
</span><span class="cx"> DEFINE_OP(op_construct)
</span><del>- DEFINE_OP(op_get_callee)
</del><span class="cx"> DEFINE_OP(op_create_this)
</span><span class="cx"> DEFINE_OP(op_to_this)
</span><span class="cx"> DEFINE_OP(op_init_lazy_reg)
</span><span class="lines">@@ -379,7 +378,6 @@
</span><span class="cx"> DEFINE_SLOWCASE_OP(op_create_this)
</span><span class="cx"> DEFINE_SLOWCASE_OP(op_div)
</span><span class="cx"> DEFINE_SLOWCASE_OP(op_eq)
</span><del>- DEFINE_SLOWCASE_OP(op_get_callee)
</del><span class="cx"> case op_get_by_id_out_of_line:
</span><span class="cx"> case op_get_array_length:
</span><span class="cx"> DEFINE_SLOWCASE_OP(op_get_by_id)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JIT.h (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JIT.h 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/jit/JIT.h 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -466,7 +466,6 @@
</span><span class="cx"> void emit_op_construct_varargs(Instruction*);
</span><span class="cx"> void emit_op_catch(Instruction*);
</span><span class="cx"> void emit_op_construct(Instruction*);
</span><del>- void emit_op_get_callee(Instruction*);
</del><span class="cx"> void emit_op_create_this(Instruction*);
</span><span class="cx"> void emit_op_to_this(Instruction*);
</span><span class="cx"> void emit_op_create_arguments(Instruction*);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITOpcodescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -729,26 +729,6 @@
</span><span class="cx"> addSlowCase(branch32(NotEqual, Address(regT1, JSCell::structureIDOffset()), regT2));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT::emit_op_get_callee(Instruction* currentInstruction)
-{
- int result = currentInstruction[1].u.operand;
- WriteBarrierBase<JSCell>* cachedFunction = &currentInstruction[2].u.jsCell;
- emitGetFromCallFrameHeaderPtr(JSStack::Callee, regT0);
-
- loadPtr(cachedFunction, regT2);
- addSlowCase(branchPtr(NotEqual, regT0, regT2));
-
- emitPutVirtualRegister(result);
-}
-
-void JIT::emitSlow_op_get_callee(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter)
-{
- linkSlowCase(iter);
-
- JITSlowPathCall slowPathCall(this, currentInstruction, slow_path_get_callee);
- slowPathCall.call();
-}
-
</del><span class="cx"> void JIT::emit_op_create_this(Instruction* currentInstruction)
</span><span class="cx"> {
</span><span class="cx"> int callee = currentInstruction[2].u.operand;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITOpcodes32_64cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -947,27 +947,6 @@
</span><span class="cx"> emitStore(dst, JSValue());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void JIT::emit_op_get_callee(Instruction* currentInstruction)
-{
- int result = currentInstruction[1].u.operand;
- WriteBarrierBase<JSCell>* cachedFunction = &currentInstruction[2].u.jsCell;
- emitGetFromCallFrameHeaderPtr(JSStack::Callee, regT0);
-
- loadPtr(cachedFunction, regT2);
- addSlowCase(branchPtr(NotEqual, regT0, regT2));
-
- move(TrustedImm32(JSValue::CellTag), regT1);
- emitStore(result, regT1, regT0);
-}
-
-void JIT::emitSlow_op_get_callee(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter)
-{
- linkSlowCase(iter);
-
- JITSlowPathCall slowPathCall(this, currentInstruction, slow_path_get_callee);
- slowPathCall.call();
-}
-
</del><span class="cx"> void JIT::emit_op_create_this(Instruction* currentInstruction)
</span><span class="cx"> {
</span><span class="cx"> int callee = currentInstruction[2].u.operand;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorellintLowLevelInterpreter32_64asm"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -772,20 +772,6 @@
</span><span class="cx"> dispatch(4)
</span><span class="cx">
</span><span class="cx">
</span><del>-_llint_op_get_callee:
- traceExecution()
- loadi 4[PC], t0
- loadp PayloadOffset + Callee[cfr], t1
- loadpFromInstruction(2, t2)
- bpneq t1, t2, .opGetCalleeSlow
- storei CellTag, TagOffset[cfr, t0, 8]
- storei t1, PayloadOffset[cfr, t0, 8]
- dispatch(3)
-
-.opGetCalleeSlow:
- callSlowPath(_slow_path_get_callee)
- dispatch(3)
-
</del><span class="cx"> _llint_op_to_this:
</span><span class="cx"> traceExecution()
</span><span class="cx"> loadi 4[PC], t0
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorellintLowLevelInterpreter64asm"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -656,19 +656,6 @@
</span><span class="cx"> dispatch(4)
</span><span class="cx">
</span><span class="cx">
</span><del>-_llint_op_get_callee:
- traceExecution()
- loadisFromInstruction(1, t0)
- loadp Callee[cfr], t1
- loadpFromInstruction(2, t2)
- bpneq t1, t2, .opGetCalleeSlow
- storep t1, [cfr, t0, 8]
- dispatch(3)
-
-.opGetCalleeSlow:
- callSlowPath(_slow_path_get_callee)
- dispatch(3)
-
</del><span class="cx"> _llint_op_to_this:
</span><span class="cx"> traceExecution()
</span><span class="cx"> loadisFromInstruction(1, t0)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeCommonSlowPathscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp (180916 => 180917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp 2015-03-03 03:58:53 UTC (rev 180916)
+++ trunk/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp 2015-03-03 04:05:05 UTC (rev 180917)
</span><span class="lines">@@ -210,14 +210,6 @@
</span><span class="cx"> END();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-SLOW_PATH_DECL(slow_path_get_callee)
-{
- BEGIN();
- JSFunction* callee = jsCast<JSFunction*>(exec->callee());
- pc[2].u.jsCell.set(exec->vm(), exec->codeBlock()->ownerExecutable(), callee);
- RETURN(callee);
-}
-
</del><span class="cx"> SLOW_PATH_DECL(slow_path_create_arguments)
</span><span class="cx"> {
</span><span class="cx"> BEGIN();
</span></span></pre>
</div>
</div>
</body>
</html>