<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180849] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180849">180849</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-03-01 00:15:20 -0800 (Sun, 01 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/180621">r180621</a> - AX: Implement support for ARIA 1.1 'searchbox' role
https://bugs.webkit.org/show_bug.cgi?id=142004
Reviewed by Chris Fleizach.
Source/WebCore:
Add a new accessible SearchFieldRole to handle both the ARIA role
and the "search" input type.
No new tests. Instead, added a new test case to roles-exposed.html
for the mapping, and updated roles-computedRoleString.html because
there is now a one-to-one mapping between the "search" input type
and an ARIA role.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isSearchField):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIATextControl):
(WebCore::AccessibilityObject::isARIAInput):
(WebCore::initializeRoleMap):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
LayoutTests:
* accessibility/roles-computedRoleString-expected.txt: Updated for new role.
* accessibility/roles-computedRoleString.html: Updated for new role.
* accessibility/roles-exposed.html: New test case added.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated for new test case.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated for new test case.
* platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for new test case.
* platform/mac/accessibility/roles-exposed-expected.txt: Updated for new test case.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolescomputedRoleStringexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolescomputedRoleStringhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolesexposedhtml">releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-exposed.html</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformeflaccessibilityrolesexposedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformmacmavericksaccessibilityrolesexposedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityNodeObjectcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityObjectcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityObjecth">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.h</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityRenderObjectcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-02-25 Joanmarie Diggs <jdiggs@igalia.com>
+
+ AX: Implement support for ARIA 1.1 'searchbox' role
+ https://bugs.webkit.org/show_bug.cgi?id=142004
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/roles-computedRoleString-expected.txt: Updated for new role.
+ * accessibility/roles-computedRoleString.html: Updated for new role.
+ * accessibility/roles-exposed.html: New test case added.
+ * platform/efl/accessibility/roles-exposed-expected.txt: Updated for new test case.
+ * platform/gtk/accessibility/roles-exposed-expected.txt: Updated for new test case.
+ * platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for new test case.
+ * platform/mac/accessibility/roles-exposed-expected.txt: Updated for new test case.
+
</ins><span class="cx"> 2015-02-24 Joanmarie Diggs <jdiggs@igalia.com>
</span><span class="cx">
</span><span class="cx"> AX: Implement support for ARIA 1.1 'switch' role
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolescomputedRoleStringexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString-expected.txt (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> PASS: input[type='radio'] -> radio.
</span><span class="cx"> PASS: input[type='range'] -> slider.
</span><span class="cx"> PASS: input[type='reset'] -> button.
</span><del>-PASS: input[type='search'] -> .
</del><ins>+PASS: input[type='search'] -> searchbox.
</ins><span class="cx"> PASS: input[type='submit'] -> button.
</span><span class="cx"> PASS: input[type='tel'] -> .
</span><span class="cx"> PASS: input[type='text'] -> .
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolescomputedRoleStringhtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString.html (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString.html 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-computedRoleString.html 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> <input type="radio" data-role="radio" class="ex" data-note="[type='radio']">
</span><span class="cx"> <input type="range" data-role="slider" class="ex" data-note="[type='range']">
</span><span class="cx"> <input type="reset" data-role="button" class="ex" data-note="[type='reset']">
</span><del>-<input type="search" value="X" data-role="" class="ex" data-note="[type='search']">
</del><ins>+<input type="search" value="X" data-role="searchbox" class="ex" data-note="[type='search']">
</ins><span class="cx"> <input type="submit" data-role="button" class="ex" data-note="[type='submit']">
</span><span class="cx"> <input type="tel" value="X" data-role="" class="ex" data-note="[type='tel']">
</span><span class="cx"> <input type="text" value="X" data-role="" class="ex" data-note="[type='text']">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsaccessibilityrolesexposedhtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-exposed.html (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-exposed.html 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/accessibility/roles-exposed.html 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -300,6 +300,7 @@
</span><span class="cx"> <div role="region" data-platform="atk,mac" class="ex">X</div>
</span><span class="cx"> <div role="scrollbar" data-platform="atk,mac" class="ex">X</div>
</span><span class="cx"> <div role="search" data-platform="atk,mac" class="ex">X</div>
</span><ins>+<div role="searchbox" data-platform="atk,mac" class="ex">X</div>
</ins><span class="cx"> <div role="separator" data-platform="atk,mac" class="ex">X</div>
</span><span class="cx"> <div role="slider" data-platform="atk,mac" class="ex">X</div>
</span><span class="cx"> <div role="spinbutton" data-platform="atk,mac" class="ex">X</div>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformeflaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -631,6 +631,9 @@
</span><span class="cx"> div[role=search]
</span><span class="cx"> AXRole: AXLandmarkSearch
</span><span class="cx">
</span><ins>+div[role=searchbox]
+ AXRole: AXTextField
+
</ins><span class="cx"> div[role=separator]
</span><span class="cx"> AXRole: AXSeparator
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -631,6 +631,9 @@
</span><span class="cx"> div[role=search]
</span><span class="cx"> AXRole: AXLandmarkSearch
</span><span class="cx">
</span><ins>+div[role=searchbox]
+ AXRole: AXTextField
+
</ins><span class="cx"> div[role=separator]
</span><span class="cx"> AXRole: AXSeparator
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -1049,6 +1049,11 @@
</span><span class="cx"> AXSubrole: AXLandmarkSearch
</span><span class="cx"> AXRoleDescription: search
</span><span class="cx">
</span><ins>+div[role=searchbox]
+ AXRole: AXTextField
+ AXSubrole: AXSearchField
+ AXRoleDescription: search text field
+
</ins><span class="cx"> div[role=separator]
</span><span class="cx"> AXRole: AXSplitter
</span><span class="cx"> AXSubrole:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformmacmavericksaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -1049,6 +1049,11 @@
</span><span class="cx"> AXSubrole: AXLandmarkSearch
</span><span class="cx"> AXRoleDescription: search
</span><span class="cx">
</span><ins>+div[role=searchbox]
+ AXRole: AXTextField
+ AXSubrole: AXSearchField
+ AXRoleDescription: search text field
+
</ins><span class="cx"> div[role=separator]
</span><span class="cx"> AXRole: AXSplitter
</span><span class="cx"> AXSubrole:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2015-02-25 Joanmarie Diggs <jdiggs@igalia.com>
+
+ AX: Implement support for ARIA 1.1 'searchbox' role
+ https://bugs.webkit.org/show_bug.cgi?id=142004
+
+ Reviewed by Chris Fleizach.
+
+ Add a new accessible SearchFieldRole to handle both the ARIA role
+ and the "search" input type.
+
+ No new tests. Instead, added a new test case to roles-exposed.html
+ for the mapping, and updated roles-computedRoleString.html because
+ there is now a one-to-one mapping between the "search" input type
+ and an ARIA role.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
+ (WebCore::AccessibilityNodeObject::isSearchField):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isARIATextControl):
+ (WebCore::AccessibilityObject::isARIAInput):
+ (WebCore::initializeRoleMap):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
+ (-[WebAccessibilityObjectWrapper accessibilityTraits]):
+ (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (createAccessibilityRoleMap):
+
</ins><span class="cx"> 2015-02-24 Joanmarie Diggs <jdiggs@igalia.com>
</span><span class="cx">
</span><span class="cx"> AX: Implement support for ARIA 1.1 'switch' role
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -302,6 +302,8 @@
</span><span class="cx"> return SliderRole;
</span><span class="cx"> if (input.isInputTypeHidden())
</span><span class="cx"> return IgnoredRole;
</span><ins>+ if (input.isSearchField())
+ return SearchFieldRole;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(INPUT_TYPE_COLOR)
</span><span class="cx"> const AtomicString& type = input.getAttribute(typeAttr);
</span><span class="lines">@@ -485,13 +487,13 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ if (roleValue() == SearchFieldRole)
+ return true;
+
</ins><span class="cx"> HTMLInputElement* inputElement = node->toInputElement();
</span><span class="cx"> if (!inputElement)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (inputElement->isSearchField())
- return true;
-
</del><span class="cx"> // Some websites don't label their search fields as such. However, they will
</span><span class="cx"> // use the word "search" in either the form or input type. This won't catch every case,
</span><span class="cx"> // but it will catch google.com for example.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.cpp (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.cpp 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.cpp 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -386,7 +386,7 @@
</span><span class="cx">
</span><span class="cx"> bool AccessibilityObject::isARIATextControl() const
</span><span class="cx"> {
</span><del>- return ariaRoleAttribute() == TextAreaRole || ariaRoleAttribute() == TextFieldRole;
</del><ins>+ return ariaRoleAttribute() == TextAreaRole || ariaRoleAttribute() == TextFieldRole || ariaRoleAttribute() == SearchFieldRole;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityObject::isLandmark() const
</span><span class="lines">@@ -779,7 +779,7 @@
</span><span class="cx">
</span><span class="cx"> bool AccessibilityObject::isARIAInput(AccessibilityRole ariaRole)
</span><span class="cx"> {
</span><del>- return ariaRole == RadioButtonRole || ariaRole == CheckBoxRole || ariaRole == TextFieldRole || ariaRole == SwitchRole;
</del><ins>+ return ariaRole == RadioButtonRole || ariaRole == CheckBoxRole || ariaRole == TextFieldRole || ariaRole == SwitchRole || ariaRole == SearchFieldRole;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityObject::isARIAControl(AccessibilityRole ariaRole)
</span><span class="lines">@@ -1912,6 +1912,7 @@
</span><span class="cx"> { "row", RowRole },
</span><span class="cx"> { "scrollbar", ScrollBarRole },
</span><span class="cx"> { "search", LandmarkSearchRole },
</span><ins>+ { "searchbox", SearchFieldRole },
</ins><span class="cx"> { "separator", SplitterRole },
</span><span class="cx"> { "slider", SliderRole },
</span><span class="cx"> { "spinbutton", SpinButtonRole },
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityObjecth"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.h (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.h 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityObject.h 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -180,6 +180,7 @@
</span><span class="cx"> RulerMarkerRole,
</span><span class="cx"> ScrollAreaRole,
</span><span class="cx"> ScrollBarRole,
</span><ins>+ SearchFieldRole,
</ins><span class="cx"> SheetRole,
</span><span class="cx"> SliderRole,
</span><span class="cx"> SliderThumbRole,
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -2484,8 +2484,10 @@
</span><span class="cx"> if (cssBox && cssBox->isRenderView())
</span><span class="cx"> return WebAreaRole;
</span><span class="cx">
</span><del>- if (cssBox && cssBox->isTextField())
- return TextFieldRole;
</del><ins>+ if (cssBox && cssBox->isTextField()) {
+ if (is<HTMLInputElement>(node))
+ return downcast<HTMLInputElement>(*node).isSearchField() ? SearchFieldRole : TextFieldRole;
+ }
</ins><span class="cx">
</span><span class="cx"> if (cssBox && cssBox->isTextArea())
</span><span class="cx"> return TextAreaRole;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -524,6 +524,7 @@
</span><span class="cx"> return ATK_ROLE_PAGE_TAB_LIST;
</span><span class="cx"> case TextFieldRole:
</span><span class="cx"> case TextAreaRole:
</span><ins>+ case SearchFieldRole:
</ins><span class="cx"> return ATK_ROLE_ENTRY;
</span><span class="cx"> case StaticTextRole:
</span><span class="cx"> return ATK_ROLE_TEXT;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -297,6 +297,7 @@
</span><span class="cx"> case PopUpButtonRole:
</span><span class="cx"> case RadioButtonRole:
</span><span class="cx"> case ScrollBarRole:
</span><ins>+ case SearchFieldRole:
</ins><span class="cx"> case SliderRole:
</span><span class="cx"> case StaticTextRole:
</span><span class="cx"> case SwitchRole:
</span><span class="lines">@@ -543,6 +544,7 @@
</span><span class="cx"> if (m_object->isPasswordField())
</span><span class="cx"> traits |= [self _axSecureTextFieldTrait];
</span><span class="cx"> FALLTHROUGH;
</span><ins>+ case SearchFieldRole:
</ins><span class="cx"> case TextAreaRole:
</span><span class="cx"> traits |= [self _axTextEntryTrait];
</span><span class="cx"> if (m_object->isFocused())
</span><span class="lines">@@ -648,6 +650,7 @@
</span><span class="cx"> case DocumentMathRole:
</span><span class="cx"> case HorizontalRuleRole:
</span><span class="cx"> case SwitchRole:
</span><ins>+ case SearchFieldRole:
</ins><span class="cx"> return true;
</span><span class="cx"> case StaticTextRole:
</span><span class="cx"> {
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (180848 => 180849)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-03-01 04:36:39 UTC (rev 180848)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-03-01 08:15:20 UTC (rev 180849)
</span><span class="lines">@@ -1944,6 +1944,7 @@
</span><span class="cx"> { HorizontalRuleRole, NSAccessibilitySplitterRole },
</span><span class="cx"> { BlockquoteRole, NSAccessibilityGroupRole },
</span><span class="cx"> { SwitchRole, NSAccessibilityCheckBoxRole },
</span><ins>+ { SearchFieldRole, NSAccessibilityTextFieldRole },
</ins><span class="cx"> };
</span><span class="cx"> AccessibilityRoleMap& roleMap = *new AccessibilityRoleMap;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>