<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180827] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180827">180827</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-28 03:05:40 -0800 (Sat, 28 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/180566">r180566</a> - [GTK] Layout Test accessibility/roles-exposed.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141960
Reviewed by Martin Robinson.
Source/WebCore:
The test was failing because Gtk now uses GtkColorChooserDialog for the
color input, making the input field a button which results in the color
chooser dialog appearing. As a side effect of this change, the input now
has an accessible role of ColorWell, which is currently mapped to
ATK_ROLE_COLOR_CHOOSER (which is by definition the dialog which results
upon activating the button input field). Changed the Gtk platform mapping
to ATK_ROLE_BUTTON, leaving the Efl mapping as-is.
No new tests. Instead, updated and unskipped failing test.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
* platform/gtk/TestExpectations: Unskip the failing test.
* platform/gtk/accessibility/roles-exposed-expected.txt: Update the expectations.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (180826 => 180827)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-02-28 11:03:37 UTC (rev 180826)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-02-28 11:05:40 UTC (rev 180827)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-02-24 Joanmarie Diggs <jdiggs@igalia.com>
+
+ [GTK] Layout Test accessibility/roles-exposed.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=141960
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/TestExpectations: Unskip the failing test.
+ * platform/gtk/accessibility/roles-exposed-expected.txt: Update the expectations.
+
</ins><span class="cx"> 2015-02-24 Dhi Aurrahman <diorahman@rockybars.com>
</span><span class="cx">
</span><span class="cx"> Always serialize :lang()'s arguments to strings
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsplatformgtkaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (180826 => 180827)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2015-02-28 11:03:37 UTC (rev 180826)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2015-02-28 11:05:40 UTC (rev 180827)
</span><span class="lines">@@ -137,7 +137,7 @@
</span><span class="cx"> AXRole: AXButton
</span><span class="cx">
</span><span class="cx"> input[type='color']
</span><del>- AXRole: AXTextField
</del><ins>+ AXRole: AXButton
</ins><span class="cx">
</span><span class="cx"> input[type='checkbox']
</span><span class="cx"> AXRole: AXCheckBox
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (180826 => 180827)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-02-28 11:03:37 UTC (rev 180826)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-02-28 11:05:40 UTC (rev 180827)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-02-24 Joanmarie Diggs <jdiggs@igalia.com>
+
+ [GTK] Layout Test accessibility/roles-exposed.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=141960
+
+ Reviewed by Martin Robinson.
+
+ The test was failing because Gtk now uses GtkColorChooserDialog for the
+ color input, making the input field a button which results in the color
+ chooser dialog appearing. As a side effect of this change, the input now
+ has an accessible role of ColorWell, which is currently mapped to
+ ATK_ROLE_COLOR_CHOOSER (which is by definition the dialog which results
+ upon activating the button input field). Changed the Gtk platform mapping
+ to ATK_ROLE_BUTTON, leaving the Efl mapping as-is.
+
+ No new tests. Instead, updated and unskipped failing test.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+
</ins><span class="cx"> 2015-02-26 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [FreeType] REGRESSION(r180563): Introduced crashes
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (180826 => 180827)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2015-02-28 11:03:37 UTC (rev 180826)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2015-02-28 11:05:40 UTC (rev 180827)
</span><span class="lines">@@ -565,7 +565,12 @@
</span><span class="cx"> case SplitterRole:
</span><span class="cx"> return ATK_ROLE_SEPARATOR;
</span><span class="cx"> case ColorWellRole:
</span><ins>+#if PLATFORM(GTK)
+ // ATK_ROLE_COLOR_CHOOSER is defined as a dialog (i.e. it's what appears when you push the button).
+ return ATK_ROLE_PUSH_BUTTON;
+#elif PLATFORM(EFL)
</ins><span class="cx"> return ATK_ROLE_COLOR_CHOOSER;
</span><ins>+#endif
</ins><span class="cx"> case ListRole:
</span><span class="cx"> return ATK_ROLE_LIST;
</span><span class="cx"> case ScrollBarRole:
</span></span></pre>
</div>
</div>
</body>
</html>