<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180819] releases/WebKitGTK/webkit-2.8</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180819">180819</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-28 00:41:40 -0800 (Sat, 28 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/180530">r180530</a> - Default value of HTMLSelectElement size IDL attribute should be 0.
https://bugs.webkit.org/show_bug.cgi?id=141795
Reviewed by Andreas Kling.
Source/WebCore:
Default value of HTMLSelectElement size IDL attribute should be 0.
As in spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#the-select-element, also this matches the behavior of Chrome, IE and
Gecko.
Test: fast/dom/select-size.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
LayoutTests:
* fast/dom/select-size-expected.txt: Added.
* fast/dom/select-size.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLSelectElementcpp">releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomselectsizeexpectedtxt">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit28LayoutTestsfastdomselectsizehtml">releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit28LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (180818 => 180819)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-02-28 08:38:13 UTC (rev 180818)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog 2015-02-28 08:41:40 UTC (rev 180819)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2015-02-23 Shivakumar JM <shiva.jm@samsung.com>
+
+ Default value of HTMLSelectElement size IDL attribute should be 0.
+ https://bugs.webkit.org/show_bug.cgi?id=141795
+
+ Reviewed by Andreas Kling.
+
+ * fast/dom/select-size-expected.txt: Added.
+ * fast/dom/select-size.html: Added.
+
</ins><span class="cx"> 2015-02-23 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Drawing an SVG image into a canvas using drawImage() ignores globalAlpha.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomselectsizeexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size-expected.txt (0 => 180819)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size-expected.txt 2015-02-28 08:41:40 UTC (rev 180819)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+Test HTMLSelectElement::size behavior.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS select.size is 0
+PASS select.setAttribute("size", "1"); select.size is 1
+PASS select.setAttribute("size", "2"); select.size is 2
+PASS select.setAttribute("size", "3"); select.size is 3
+PASS select.setAttribute("size", "4"); select.size is 4
+PASS select.setAttribute("size", "0"); select.size is 0
+PASS select.setAttribute("size", "-1"); select.size is 0
+PASS select.setAttribute("size", "abc"); select.size is 0
+PASS select.setAttribute("size", "3.14"); select.size is 3
+PASS select.size is 2
+PASS select.setAttribute("size", "1"); select.size is 1
+PASS select.setAttribute("size", "0"); select.size is 0
+PASS select.setAttribute("size", "-1"); select.size is 0
+PASS select.setAttribute("size", "abc"); select.size is 0
+PASS select.setAttribute("size", "3.14"); select.size is 3
+PASS select.size is 0
+PASS select.setAttribute("size", "1"); select.size is 1
+PASS select.setAttribute("size", "0"); select.size is 0
+PASS select.setAttribute("size", "-1"); select.size is 0
+PASS select.setAttribute("size", "abc"); select.size is 0
+PASS select.setAttribute("size", "3.14"); select.size is 3
+PASS select.size is 1
+PASS select.setAttribute("size", "2"); select.size is 2
+PASS select.setAttribute("size", "0"); select.size is 0
+PASS select.setAttribute("size", "-1"); select.size is 0
+PASS select.setAttribute("size", "abc"); select.size is 0
+PASS select.setAttribute("size", "3.14"); select.size is 3
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28LayoutTestsfastdomselectsizehtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size.html (0 => 180819)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size.html (rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/fast/dom/select-size.html 2015-02-28 08:41:40 UTC (rev 180819)
</span><span class="lines">@@ -0,0 +1,51 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../resources/js-test.js"></script>
+</head>
+<body>
+<select id="test1"></select>
+<select id="test2" size=2></select>
+<select id="test3" multiple></select>
+<select id="test4" multiple size=1></select>
+<script>
+description('Test HTMLSelectElement::size behavior.');
+
+var select = document.getElementById('test1');
+shouldBe('select.size', '0');
+shouldBe('select.setAttribute("size", "1"); select.size', '1');
+shouldBe('select.setAttribute("size", "2"); select.size', '2');
+shouldBe('select.setAttribute("size", "3"); select.size', '3');
+shouldBe('select.setAttribute("size", "4"); select.size', '4');
+shouldBe('select.setAttribute("size", "0"); select.size', '0');
+shouldBe('select.setAttribute("size", "-1"); select.size', '0');
+shouldBe('select.setAttribute("size", "abc"); select.size', '0');
+shouldBe('select.setAttribute("size", "3.14"); select.size', '3');
+
+var select = document.getElementById('test2');
+shouldBe('select.size', '2');
+shouldBe('select.setAttribute("size", "1"); select.size', '1');
+shouldBe('select.setAttribute("size", "0"); select.size', '0');
+shouldBe('select.setAttribute("size", "-1"); select.size', '0');
+shouldBe('select.setAttribute("size", "abc"); select.size', '0');
+shouldBe('select.setAttribute("size", "3.14"); select.size', '3');
+
+var select = document.getElementById('test3');
+shouldBe('select.size', '0');
+shouldBe('select.setAttribute("size", "1"); select.size', '1');
+shouldBe('select.setAttribute("size", "0"); select.size', '0');
+shouldBe('select.setAttribute("size", "-1"); select.size', '0');
+shouldBe('select.setAttribute("size", "abc"); select.size', '0');
+shouldBe('select.setAttribute("size", "3.14"); select.size', '3');
+
+var select = document.getElementById('test4');
+shouldBe('select.size', '1');
+shouldBe('select.setAttribute("size", "2"); select.size', '2');
+shouldBe('select.setAttribute("size", "0"); select.size', '0');
+shouldBe('select.setAttribute("size", "-1"); select.size', '0');
+shouldBe('select.setAttribute("size", "abc"); select.size', '0');
+shouldBe('select.setAttribute("size", "3.14"); select.size', '3');
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (180818 => 180819)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-02-28 08:38:13 UTC (rev 180818)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-02-28 08:41:40 UTC (rev 180819)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-02-23 Shivakumar JM <shiva.jm@samsung.com>
+
+ Default value of HTMLSelectElement size IDL attribute should be 0.
+ https://bugs.webkit.org/show_bug.cgi?id=141795
+
+ Reviewed by Andreas Kling.
+
+ Default value of HTMLSelectElement size IDL attribute should be 0.
+ As in spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#the-select-element, also this matches the behavior of Chrome, IE and
+ Gecko.
+
+ Test: fast/dom/select-size.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseAttribute):
+
</ins><span class="cx"> 2015-02-23 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> Drawing an SVG image into a canvas using drawImage() ignores globalAlpha.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit28SourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLSelectElement.cpp (180818 => 180819)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLSelectElement.cpp 2015-02-28 08:38:13 UTC (rev 180818)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/html/HTMLSelectElement.cpp 2015-02-28 08:41:40 UTC (rev 180819)
</span><span class="lines">@@ -311,7 +311,7 @@
</span><span class="cx"> if (Attribute* sizeAttribute = ensureUniqueElementData().findAttributeByName(sizeAttr))
</span><span class="cx"> sizeAttribute->setValue(attrSize);
</span><span class="cx"> }
</span><del>- size = std::max(size, 1);
</del><ins>+ size = std::max(size, 0);
</ins><span class="cx">
</span><span class="cx"> // Ensure that we've determined selectedness of the items at least once prior to changing the size.
</span><span class="cx"> if (oldSize != size)
</span></span></pre>
</div>
</div>
</body>
</html>