<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180661] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180661">180661</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2015-02-25 22:56:01 -0800 (Wed, 25 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Black line across screen on Adobe Illustrator detail page (non-retina only)
https://bugs.webkit.org/show_bug.cgi?id=141866
Reviewed by Simon Fraser.
Phase is relative to the destination origin. We need to take location information into account
while snapping so that the result is inline with the snapped destination rect.
(location affects the snapped size.)
Source/WebCore:
Test: fast/backgrounds/gradient-background-on-subpixel-position.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::pixelSnapBackgroundImageGeometryForPainting):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
* fast/backgrounds/gradient-background-on-subpixel-position-expected.html: Added.
* fast/backgrounds/gradient-background-on-subpixel-position.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundshidpibitmapbackgroundrepeatonsubpixelpositionexpectedhtml">trunk/LayoutTests/fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxModelObjectcpp">trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbackgroundsgradientbackgroundonsubpixelpositionexpectedhtml">trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsgradientbackgroundonsubpixelpositionhtml">trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (180660 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-02-26 06:05:02 UTC (rev 180660)
+++ trunk/LayoutTests/ChangeLog 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-02-25 Zalan Bujtas <zalan@apple.com>
+
+ Black line across screen on Adobe Illustrator detail page (non-retina only)
+ https://bugs.webkit.org/show_bug.cgi?id=141866
+
+ Reviewed by Simon Fraser.
+
+ Phase is relative to the destination origin. We need to take location information into account
+ while snapping so that the result is inline with the snapped destination rect.
+ (location affects the snapped size.)
+
+ * fast/backgrounds/gradient-background-on-subpixel-position-expected.html: Added.
+ * fast/backgrounds/gradient-background-on-subpixel-position.html: Added.
+
</ins><span class="cx"> 2015-02-25 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: CRASH when debugger pauses inside a Promise handler
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsgradientbackgroundonsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position-expected.html (0 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position-expected.html 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<html>
+<head>
+<title>This tests that background image is filling up the space properly when on subpixel position.</title>
+<style>
+.gradient{
+ width: 300px;
+ height: 100.8px;
+ position: absolute;
+ background-image: linear-gradient(white, black);
+}
+</style>
+</head>
+<body>
+<div class="container">
+ <div class="gradient">Pass if there's no black line at the top of the gradient.</div>
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsgradientbackgroundonsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position.html (0 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/gradient-background-on-subpixel-position.html 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<html>
+<head>
+<title>This tests that background image is filling up the space properly when on subpixel position.</title>
+<style>
+.container {
+ position: relative;
+ height: 100.5px;
+}
+
+.gradient{
+ width: 300px;
+ height: 100.1px;
+ position: absolute;
+ bottom: 0px;
+ background-image: linear-gradient(white, black);
+}
+</style>
+</head>
+<body>
+<div class="container">
+ <div class="gradient">Pass if there's no black line at the top of the gradient.</div>
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundshidpibitmapbackgroundrepeatonsubpixelpositionexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position-expected.html (180660 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position-expected.html 2015-02-26 06:05:02 UTC (rev 180660)
+++ trunk/LayoutTests/fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position-expected.html 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -51,12 +51,14 @@
</span><span class="cx"> </script>
</span><span class="cx"> <div class=thin style="left: 151px; top: 25px; width: 255px;"></div>
</span><span class="cx"> <div class=thick style="left: 406px; top: 25px; width: 105px;"></div>
</span><del>-<div class=thin style="left: 176px; top: 0px; height: 50px;"></div>
</del><ins>+<div class=thin style="left: 151px; top: 0px; height: 50px;"></div>
+<div class=thin style="left: 176.5px; top: 0px; height: 50px;"></div>
</ins><span class="cx"> <div class=thin style="left: 226.5px; top: 0px; height: 50px;"></div>
</span><span class="cx"> <div class=thin style="left: 277.5px; top: 0px; height: 50px;"></div>
</span><span class="cx"> <div class=thin style="left: 328.5px; top: 0px; height: 50px;"></div>
</span><span class="cx"> <div class=thin style="left: 380px; top: 0px; height: 50px;"></div>
</span><del>-<div class=thick style="left: 431.5px; top: 0px; height: 50px;"></div>
</del><ins>+<div class=thick style="left: 406px; top: 0px; height: 50px;"></div>
+<div class=thick style="left: 432px; top: 0px; height: 50px;"></div>
</ins><span class="cx"> <div class=thick style="left: 483px; top: 0px; height: 50px;"></div>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (180660 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-26 06:05:02 UTC (rev 180660)
+++ trunk/Source/WebCore/ChangeLog 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-02-25 Zalan Bujtas <zalan@apple.com>
+
+ Black line across screen on Adobe Illustrator detail page (non-retina only)
+ https://bugs.webkit.org/show_bug.cgi?id=141866
+
+ Reviewed by Simon Fraser.
+
+ Phase is relative to the destination origin. We need to take location information into account
+ while snapping so that the result is inline with the snapped destination rect.
+ (location affects the snapped size.)
+
+ Test: fast/backgrounds/gradient-background-on-subpixel-position.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::pixelSnapBackgroundImageGeometryForPainting):
+ (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
+
</ins><span class="cx"> 2015-02-25 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Use WEBCORE_EXPORT instead of Definition file
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (180660 => 180661)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-02-26 06:05:02 UTC (rev 180660)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-02-26 06:56:01 UTC (rev 180661)
</span><span class="lines">@@ -1035,9 +1035,9 @@
</span><span class="cx"> static void pixelSnapBackgroundImageGeometryForPainting(LayoutRect& destinationRect, LayoutSize& tileSize, LayoutSize& phase, LayoutSize& space, float scaleFactor)
</span><span class="cx"> {
</span><span class="cx"> tileSize = LayoutSize(snapRectToDevicePixels(LayoutRect(destinationRect.location(), tileSize), scaleFactor).size());
</span><ins>+ phase = LayoutSize(snapRectToDevicePixels(LayoutRect(destinationRect.location(), phase), scaleFactor).size());
</ins><span class="cx"> space = LayoutSize(snapRectToDevicePixels(LayoutRect(LayoutPoint(), space), scaleFactor).size());
</span><span class="cx"> destinationRect = LayoutRect(snapRectToDevicePixels(destinationRect, scaleFactor));
</span><del>- phase = LayoutSize(toFloatSize(roundPointToDevicePixels(toLayoutPoint(phase), scaleFactor)));
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates() const
</span><span class="lines">@@ -1161,7 +1161,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (backgroundRepeatX == RepeatFill) {
</span><del>- phase.setWidth(tileSize.width() ? tileSize.width() - fmodf(computedXPosition + left, tileSize.width()): 0);
</del><ins>+ phase.setWidth(tileSize.width() ? tileSize.width() - fmodf(computedXPosition + left, tileSize.width()) : 0);
</ins><span class="cx"> spaceSize.setWidth(0);
</span><span class="cx"> } else if (backgroundRepeatX == SpaceFill && tileSize.width() > 0) {
</span><span class="cx"> LayoutUnit space = getSpace(positioningAreaSize.width(), tileSize.width());
</span></span></pre>
</div>
</div>
</body>
</html>