<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180509] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180509">180509</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2015-02-23 10:53:06 -0800 (Mon, 23 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
<http://webkit.org/b/141884>
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks): Remove
snowleopard, lion and older leaks. Add known leak for
mavericks, but check Port.operating_system before calling
Port.is_mavericks.
* Scripts/webkitpy/port/mac.py:
(MacPort.is_snowleopard): Delete.
(MacPort.is_lion): Delete.
(MacPort.is_mavericks): Add.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpyportleakdetectorpy">trunk/Tools/Scripts/webkitpy/port/leakdetector.py</a></li>
<li><a href="#trunkToolsScriptswebkitpyportmacpy">trunk/Tools/Scripts/webkitpy/port/mac.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (180508 => 180509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2015-02-23 18:45:45 UTC (rev 180508)
+++ trunk/Tools/ChangeLog        2015-02-23 18:53:06 UTC (rev 180509)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-02-23 David Kilzer <ddkilzer@apple.com>
+
+ [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
+ <http://webkit.org/b/141884>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/port/leakdetector.py:
+ (LeakDetector._callstacks_to_exclude_from_leaks): Remove
+ snowleopard, lion and older leaks. Add known leak for
+ mavericks, but check Port.operating_system before calling
+ Port.is_mavericks.
+ * Scripts/webkitpy/port/mac.py:
+ (MacPort.is_snowleopard): Delete.
+ (MacPort.is_lion): Delete.
+ (MacPort.is_mavericks): Add.
+
</ins><span class="cx"> 2015-02-23 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> build.webkit.org/dashboard should filter out commits to other branches
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportleakdetectorpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/leakdetector.py (180508 => 180509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/leakdetector.py        2015-02-23 18:45:45 UTC (rev 180508)
+++ trunk/Tools/Scripts/webkitpy/port/leakdetector.py        2015-02-23 18:53:06 UTC (rev 180509)
</span><span class="lines">@@ -53,26 +53,11 @@
</span><span class="cx"> return []
</span><span class="cx">
</span><span class="cx"> def _callstacks_to_exclude_from_leaks(self):
</span><del>- callstacks = [
- "Flash_EnforceLocalSecurity", # leaks in Flash plug-in code, rdar://problem/4449747
- "ScanFromString", # <http://code.google.com/p/angleproject/issues/detail?id=249> leak in ANGLE
- ]
- if self._port.is_snowleopard():
</del><ins>+ callstacks = []
+ if self._port.operating_system == 'mac' and self._port.is_mavericks():
</ins><span class="cx"> callstacks += [
</span><del>- "readMakerNoteProps", # <rdar://problem/7156432> leak in ImageIO
- "QTKitMovieControllerView completeUISetup", # <rdar://problem/7155156> leak in QTKit
- "getVMInitArgs", # <rdar://problem/7714444> leak in Java
- "Java_java_lang_System_initProperties", # <rdar://problem/7714465> leak in Java
- "glrCompExecuteKernel", # <rdar://problem/7815391> leak in graphics driver while using OpenGL
- "NSNumberFormatter getObjectValue:forString:errorDescription:", # <rdar://problem/7149350> Leak in NSNumberFormatter
</del><ins>+ 'AVAssetResourceLoader _poseAuthenticationChallengeWithKey:data:requestDictionary:fallbackHandler:', # <rdar://problem/19699887> leak in AVFoundation
</ins><span class="cx"> ]
</span><del>- elif self._port.is_lion():
- callstacks += [
- "FigByteFlumeCustomURLCreateWithURL", # <rdar://problem/10461926> leak in CoreMedia
- "PDFPage\(PDFPageInternal\) pageLayoutIfAvail", # <rdar://problem/10462055> leak in PDFKit
- "SecTransformExecute", # <rdar://problem/10470667> leak in Security.framework
- "_NSCopyStyleRefForFocusRingStyleClip", # <rdar://problem/10462031> leak in AppKit
- ]
</del><span class="cx"> return callstacks
</span><span class="cx">
</span><span class="cx"> def _leaks_args(self, pid):
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportmacpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (180508 => 180509)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/mac.py        2015-02-23 18:45:45 UTC (rev 180508)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py        2015-02-23 18:53:06 UTC (rev 180509)
</span><span class="lines">@@ -111,13 +111,9 @@
</span><span class="cx"> return 'mac'
</span><span class="cx">
</span><span class="cx"> # Belongs on a Platform object.
</span><del>- def is_snowleopard(self):
- return self._version == "snowleopard"
</del><ins>+ def is_mavericks(self):
+ return self._version == 'mavericks'
</ins><span class="cx">
</span><del>- # Belongs on a Platform object.
- def is_lion(self):
- return self._version == "lion"
-
</del><span class="cx"> def default_child_processes(self):
</span><span class="cx"> if self._version == "snowleopard":
</span><span class="cx"> _log.warning("Cannot run tests in parallel on Snow Leopard due to rdar://problem/10621525.")
</span></span></pre>
</div>
</div>
</body>
</html>