<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180484] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180484">180484</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-22 08:43:32 -0800 (Sun, 22 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Make Console UI icons / lines slightly larger
https://bugs.webkit.org/show_bug.cgi?id=141876
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-02-22
Reviewed by Timothy Hatcher.
In preparation for a new ObjectTree design with larger icons,
increase the size of existing output in the Console / Log
so they don't look so small in comparison. This:
- bumps minimum height of lines from 16px to 21px
- 10x10 icons to be 12x12
- recenters icons to match console prompt
- realigns icons with console log / object output
* UserInterface/Views/LogContentView.css:
(.console-user-command-result.console-log-level::before):
(.console-message, .console-user-command):
(.console-item::before):
(.console-user-command::before):
(:matches(.console-warning-level, .console-error-level, .console-log-level).console-message):
(:matches(.console-warning-level, .console-error-level, .console-log-level)::before):
(.outline-disclosure li):
(.outline-disclosure .expanded li):
Fix a case breaking single-line message height.
Only add padding to expanded trees, not collapsed trees.
* UserInterface/Views/QuickConsole.css:
(.quick-console > .console-prompt::before):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsQuickConsolecss">trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (180483 => 180484)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-02-22 03:50:34 UTC (rev 180483)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-02-22 16:43:32 UTC (rev 180484)
</span><span class="lines">@@ -1,3 +1,34 @@
</span><ins>+2015-02-22 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Make Console UI icons / lines slightly larger
+ https://bugs.webkit.org/show_bug.cgi?id=141876
+
+ Reviewed by Timothy Hatcher.
+
+ In preparation for a new ObjectTree design with larger icons,
+ increase the size of existing output in the Console / Log
+ so they don't look so small in comparison. This:
+
+ - bumps minimum height of lines from 16px to 21px
+ - 10x10 icons to be 12x12
+ - recenters icons to match console prompt
+ - realigns icons with console log / object output
+
+ * UserInterface/Views/LogContentView.css:
+ (.console-user-command-result.console-log-level::before):
+ (.console-message, .console-user-command):
+ (.console-item::before):
+ (.console-user-command::before):
+ (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message):
+ (:matches(.console-warning-level, .console-error-level, .console-log-level)::before):
+ (.outline-disclosure li):
+ (.outline-disclosure .expanded li):
+ Fix a case breaking single-line message height.
+ Only add padding to expanded trees, not collapsed trees.
+
+ * UserInterface/Views/QuickConsole.css:
+ (.quick-console > .console-prompt::before):
+
</ins><span class="cx"> 2015-02-21 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Generate Previews more often for RemoteObject interaction
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (180483 => 180484)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-02-22 03:50:34 UTC (rev 180483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-02-22 16:43:32 UTC (rev 180484)
</span><span class="lines">@@ -88,13 +88,13 @@
</span><span class="cx">
</span><span class="cx"> .console-user-command-result.console-log-level::before {
</span><span class="cx"> content: url(../Images/UserInputResult.svg);
</span><del>- margin-top: 1px; /* align with 11px Menlo */
</del><ins>+ margin-left: 1px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .console-message, .console-user-command {
</span><span class="cx"> position: relative;
</span><del>- padding: 2px 12px 2px 18px;
- min-height: 16px;
</del><ins>+ padding: 4px 12px 2px 20px;
+ min-height: 21px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .console-item::before {
</span><span class="lines">@@ -102,7 +102,8 @@
</span><span class="cx">
</span><span class="cx"> position: absolute;
</span><span class="cx"> left: 4px;
</span><del>- width: 10px;
</del><ins>+ height: 12px;
+ width: 12px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .console-message .bubble {
</span><span class="lines">@@ -207,9 +208,18 @@
</span><span class="cx">
</span><span class="cx"> .console-user-command::before {
</span><span class="cx"> content: url(../Images/UserInputPromptPrevious.svg);
</span><del>- margin-top: 1px; /* align with 11px Menlo */
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+:matches(.console-warning-level, .console-error-level, .console-log-level).console-message {
+ /* Move non-monospace log/warning/error text up a bit. */
+ padding: 3px 12px 3px 20px;
+}
+
+:matches(.console-warning-level, .console-error-level, .console-log-level)::before {
+ /* Re-center log/warning/error icons. */
+ padding-top: 1px;
+}
+
</ins><span class="cx"> .console-user-command > .console-message-text {
</span><span class="cx"> color: rgb(0, 128, 255);
</span><span class="cx"> }
</span><span class="lines">@@ -426,11 +436,15 @@
</span><span class="cx"> .outline-disclosure li {
</span><span class="cx"> padding: 0 0 0 14px;
</span><span class="cx"> margin-top: 0;
</span><del>- margin-bottom: 2px;
</del><ins>+ margin-bottom: 0;
</ins><span class="cx"> margin-left: -2px;
</span><span class="cx"> word-wrap: break-word;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.outline-disclosure .expanded li {
+ margin-bottom: 2px;
+}
+
</ins><span class="cx"> .outline-disclosure li.parent {
</span><span class="cx"> margin-left: -12px
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsQuickConsolecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css (180483 => 180484)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css 2015-02-22 03:50:34 UTC (rev 180483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css 2015-02-22 16:43:32 UTC (rev 180484)
</span><span class="lines">@@ -63,13 +63,13 @@
</span><span class="cx"> position: relative;
</span><span class="cx"> z-index: 1;
</span><span class="cx">
</span><del>- top: 5px;
</del><ins>+ top: 4px;
</ins><span class="cx"> left: 4px;
</span><span class="cx">
</span><del>- margin-right: 1px;
</del><ins>+ margin-right: 2px;
</ins><span class="cx">
</span><del>- width: 10px;
- height: 10px;
</del><ins>+ width: 12px;
+ height: 12px;
</ins><span class="cx">
</span><span class="cx"> content: url(../Images/UserInputPrompt.svg);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>