<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180442] trunk/Websites/perf.webkit.org</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180442">180442</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-20 12:09:47 -0800 (Fri, 20 Feb 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed test fixes after <a href="http://trac.webkit.org/projects/webkit/changeset/179037">r179037</a>, <a href="http://trac.webkit.org/projects/webkit/changeset/179591">r179591</a>, and <a href="http://trac.webkit.org/projects/webkit/changeset/179763">r179763</a>.

* tests/admin-regenerate-manifest.js:
* tests/admin-reprocess-report.js:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtestsadminregeneratemanifestjs">trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgtestsadminreprocessreportjs">trunk/Websites/perf.webkit.org/tests/admin-reprocess-report.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (180441 => 180442)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog        2015-02-20 20:05:12 UTC (rev 180441)
+++ trunk/Websites/perf.webkit.org/ChangeLog        2015-02-20 20:09:47 UTC (rev 180442)
</span><span class="lines">@@ -1,3 +1,10 @@
</span><ins>+2015-02-20  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;
+
+        Unreviewed test fixes after r179037, r179591, and r179763.
+
+        * tests/admin-regenerate-manifest.js:
+        * tests/admin-reprocess-report.js:
+
</ins><span class="cx"> 2015-02-19  Ryosuke Niwa  &lt;rniwa@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Relationship between A/B testing results are unclear
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtestsadminregeneratemanifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js (180441 => 180442)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js        2015-02-20 20:05:12 UTC (rev 180441)
+++ trunk/Websites/perf.webkit.org/tests/admin-regenerate-manifest.js        2015-02-20 20:09:47 UTC (rev 180442)
</span><span class="lines">@@ -7,6 +7,7 @@
</span><span class="cx">                 assert.equal(response.statusCode, 200);
</span><span class="cx">                 var manifest = JSON.parse(response.responseText);
</span><span class="cx">                 delete manifest.defaultDashboard;
</span><ins>+                delete manifest.dashboards;
</ins><span class="cx">                 assert.deepEqual(manifest, {
</span><span class="cx">                     all: [],
</span><span class="cx">                     bugTrackers: [],
</span><span class="lines">@@ -47,11 +48,11 @@
</span><span class="cx">                             assert.equal(response.statusCode, 200);
</span><span class="cx">                             var manifest = JSON.parse(response.responseText);
</span><span class="cx">                             assert.deepEqual(manifest['repositories'], {
</span><del>-                                'WebKit': { url: 'trac.webkit.org', blameUrl: null, hasReportedCommits: false },
-                                'Chromium': { url: null, blameUrl: 'SomeBlameURL', hasReportedCommits: false }
</del><ins>+                                1: { name: 'WebKit', url: 'trac.webkit.org', blameUrl: null, hasReportedCommits: false },
+                                2: { name: 'Chromium', url: null, blameUrl: 'SomeBlameURL', hasReportedCommits: false }
</ins><span class="cx">                             });
</span><del>-                            assert.deepEqual(manifest['bugTrackers'][3], {name: 'Bugzilla', bugUrl: null, newBugUrl: null, repositories: ['WebKit']});
-                            assert.deepEqual(manifest['bugTrackers'][4], {name: 'Issue Tracker', bugUrl: null, newBugUrl: null, repositories: ['WebKit', 'Chromium']});
</del><ins>+                            assert.deepEqual(manifest['bugTrackers'][3], {name: 'Bugzilla', bugUrl: null, newBugUrl: null, repositories: ['1']});
+                            assert.deepEqual(manifest['bugTrackers'][4], {name: 'Issue Tracker', bugUrl: null, newBugUrl: null, repositories: ['1', '2']});
</ins><span class="cx">                             notifyDone();
</span><span class="cx">                         });
</span><span class="cx">                     });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgtestsadminreprocessreportjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/tests/admin-reprocess-report.js (180441 => 180442)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/tests/admin-reprocess-report.js        2015-02-20 20:05:12 UTC (rev 180441)
+++ trunk/Websites/perf.webkit.org/tests/admin-reprocess-report.js        2015-02-20 20:09:47 UTC (rev 180442)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx">                     queryAndFetchAll('SELECT * FROM reports', [], function (reportRows) {
</span><span class="cx">                         assert.equal(reportRows.length, 1);
</span><span class="cx">                         assert.equal(reportRows[0]['report_build_number'], 1986);
</span><del>-                        queryAndFetchAll('DELETE FROM builds; SELECT * FROM builds', [], function (buildRows) {
</del><ins>+                        queryAndFetchAll('UPDATE reports SET report_build = NULL; DELETE FROM builds; SELECT * FROM builds', [], function (buildRows) {
</ins><span class="cx">                             assert.equal(buildRows.length, 0);
</span><span class="cx">                             var reportId = reportRows[0]['report_id'];
</span><span class="cx">                             httpGet('/admin/reprocess-report?report=' + reportId, function (response) {
</span><span class="lines">@@ -54,13 +54,16 @@
</span><span class="cx">                 assert.equal(JSON.parse(response.responseText)['status'], 'OK');
</span><span class="cx">                 queryAndFetchAll('SELECT * FROM reports', [], function (originalReprotRows) {
</span><span class="cx">                     assert.equal(originalReprotRows.length, 1);
</span><del>-                    queryAndFetchAll('DELETE FROM builds', [], function () {
</del><ins>+                    queryAndFetchAll('UPDATE reports SET report_build = NULL; DELETE FROM builds', [], function () {
</ins><span class="cx">                         httpGet('/admin/reprocess-report?report=' + originalReprotRows[0]['report_id'], function (response) {
</span><span class="cx">                             assert.equal(response.statusCode, 200);
</span><span class="cx">                             assert.equal(JSON.parse(response.responseText)['status'], 'OK');
</span><span class="cx">                             queryAndFetchAll('SELECT * FROM reports', [], function (reportRows) {
</span><span class="cx">                                 originalReprotRows[0]['report_committed_at'] = null;
</span><span class="cx">                                 reportRows[0]['report_committed_at'] = null;
</span><ins>+                                assert.notEqual(originalReprotRows[0]['report_build'], reportRows[0]['report_build']);
+                                originalReprotRows[0]['report_build'] = null;
+                                reportRows[0]['report_build'] = null;
</ins><span class="cx">                                 assert.deepEqual(reportRows, originalReprotRows);
</span><span class="cx">                                 notifyDone();
</span><span class="cx">                             });
</span></span></pre>
</div>
</div>

</body>
</html>