<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180254] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180254">180254</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2015-02-17 20:23:11 -0800 (Tue, 17 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename CSSPropertyAnimationWrapperMap::instance() to singleton()
https://bugs.webkit.org/show_bug.cgi?id=141739
Reviewed by Simon Fraser.
Rename CSSPropertyAnimationWrapperMap::instance() to singleton(), as
per coding style.
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::singleton):
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
(WebCore::CSSPropertyAnimation::getNumProperties):
(WebCore::CSSPropertyAnimationWrapperMap::instance): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageanimationCSSPropertyAnimationcpp">trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (180253 => 180254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-18 04:17:45 UTC (rev 180253)
+++ trunk/Source/WebCore/ChangeLog 2015-02-18 04:23:11 UTC (rev 180254)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2015-02-17 Chris Dumez <cdumez@apple.com>
+
+ Rename CSSPropertyAnimationWrapperMap::instance() to singleton()
+ https://bugs.webkit.org/show_bug.cgi?id=141739
+
+ Reviewed by Simon Fraser.
+
+ Rename CSSPropertyAnimationWrapperMap::instance() to singleton(), as
+ per coding style.
+
+ * page/animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::singleton):
+ (WebCore::CSSPropertyAnimation::blendProperties):
+ (WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
+ (WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
+ (WebCore::CSSPropertyAnimation::propertiesEqual):
+ (WebCore::CSSPropertyAnimation::getPropertyAtIndex):
+ (WebCore::CSSPropertyAnimation::getNumProperties):
+ (WebCore::CSSPropertyAnimationWrapperMap::instance): Deleted.
+
</ins><span class="cx"> 2015-02-17 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r180224): Remove unused generate-export-file script
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationCSSPropertyAnimationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp (180253 => 180254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2015-02-18 04:17:45 UTC (rev 180253)
+++ trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2015-02-18 04:23:11 UTC (rev 180254)
</span><span class="lines">@@ -1108,7 +1108,7 @@
</span><span class="cx">
</span><span class="cx"> class CSSPropertyAnimationWrapperMap {
</span><span class="cx"> public:
</span><del>- static CSSPropertyAnimationWrapperMap& instance()
</del><ins>+ static CSSPropertyAnimationWrapperMap& singleton()
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: This data is never destroyed. Maybe we should ref count it and toss it when the last AnimationController is destroyed?
</span><span class="cx"> static NeverDestroyed<CSSPropertyAnimationWrapperMap> map;
</span><span class="lines">@@ -1140,6 +1140,8 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> CSSPropertyAnimationWrapperMap();
</span><ins>+ ~CSSPropertyAnimationWrapperMap() = delete;
+
</ins><span class="cx"> unsigned char& indexFromPropertyID(CSSPropertyID propertyID)
</span><span class="cx"> {
</span><span class="cx"> return m_propertyToIdMap[propertyID - firstCSSProperty];
</span><span class="lines">@@ -1399,7 +1401,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(prop != CSSPropertyInvalid);
</span><span class="cx">
</span><del>- AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::instance().wrapperForProperty(prop);
</del><ins>+ AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::singleton().wrapperForProperty(prop);
</ins><span class="cx"> if (wrapper) {
</span><span class="cx"> wrapper->blend(anim, dst, a, b, progress);
</span><span class="cx"> return !wrapper->animationIsAccelerated() || !anim->isAccelerated();
</span><span class="lines">@@ -1410,14 +1412,14 @@
</span><span class="cx">
</span><span class="cx"> bool CSSPropertyAnimation::animationOfPropertyIsAccelerated(CSSPropertyID prop)
</span><span class="cx"> {
</span><del>- AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::instance().wrapperForProperty(prop);
</del><ins>+ AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::singleton().wrapperForProperty(prop);
</ins><span class="cx"> return wrapper ? wrapper->animationIsAccelerated() : false;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Note: this is inefficient. It's only called from pauseTransitionAtTime().
</span><span class="cx"> HashSet<CSSPropertyID> CSSPropertyAnimation::animatableShorthandsAffectingProperty(CSSPropertyID property)
</span><span class="cx"> {
</span><del>- CSSPropertyAnimationWrapperMap& map = CSSPropertyAnimationWrapperMap::instance();
</del><ins>+ CSSPropertyAnimationWrapperMap& map = CSSPropertyAnimationWrapperMap::singleton();
</ins><span class="cx">
</span><span class="cx"> HashSet<CSSPropertyID> foundProperties;
</span><span class="cx"> for (unsigned i = 0; i < map.size(); ++i)
</span><span class="lines">@@ -1428,7 +1430,7 @@
</span><span class="cx">
</span><span class="cx"> bool CSSPropertyAnimation::propertiesEqual(CSSPropertyID prop, const RenderStyle* a, const RenderStyle* b)
</span><span class="cx"> {
</span><del>- AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::instance().wrapperForProperty(prop);
</del><ins>+ AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::singleton().wrapperForProperty(prop);
</ins><span class="cx"> if (wrapper)
</span><span class="cx"> return wrapper->equals(a, b);
</span><span class="cx"> return true;
</span><span class="lines">@@ -1436,7 +1438,7 @@
</span><span class="cx">
</span><span class="cx"> CSSPropertyID CSSPropertyAnimation::getPropertyAtIndex(int i, bool& isShorthand)
</span><span class="cx"> {
</span><del>- CSSPropertyAnimationWrapperMap& map = CSSPropertyAnimationWrapperMap::instance();
</del><ins>+ CSSPropertyAnimationWrapperMap& map = CSSPropertyAnimationWrapperMap::singleton();
</ins><span class="cx">
</span><span class="cx"> if (i < 0 || static_cast<unsigned>(i) >= map.size())
</span><span class="cx"> return CSSPropertyInvalid;
</span><span class="lines">@@ -1448,7 +1450,7 @@
</span><span class="cx">
</span><span class="cx"> int CSSPropertyAnimation::getNumProperties()
</span><span class="cx"> {
</span><del>- return CSSPropertyAnimationWrapperMap::instance().size();
</del><ins>+ return CSSPropertyAnimationWrapperMap::singleton().size();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>