<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180120] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180120">180120</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-14 21:08:48 -0800 (Sat, 14 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Build URL on new perf dashboard doesn't resolve $builderName
https://bugs.webkit.org/show_bug.cgi?id=141583
Reviewed by Darin Adler.
Support $builderName in the build URL template.
* public/js/helper-classes.js:
(TestBuild.buildUrl): Replaced $builderName with the builder name.
* public/v2/manifest.js:
(App.Metric.fullName): Fixed the typo. We need &ni, not &in.
(App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicjshelperclassesjs">trunk/Websites/perf.webkit.org/public/js/helper-classes.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (180119 => 180120)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-15 04:54:26 UTC (rev 180119)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-15 05:08:48 UTC (rev 180120)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
+
+ Build URL on new perf dashboard doesn't resolve $builderName
+ https://bugs.webkit.org/show_bug.cgi?id=141583
+
+ Reviewed by Darin Adler.
+
+ Support $builderName in the build URL template.
+
+ * public/js/helper-classes.js:
+ (TestBuild.buildUrl): Replaced $builderName with the builder name.
+
+ * public/v2/manifest.js:
+ (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
+ (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
+
</ins><span class="cx"> 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed build fix after r179591.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicjshelperclassesjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (180119 => 180120)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2015-02-15 04:54:26 UTC (rev 180119)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2015-02-15 05:08:48 UTC (rev 180120)
</span><span class="lines">@@ -77,8 +77,11 @@
</span><span class="cx"> this.builder = function () { return builders[rawRun.builder].name; }
</span><span class="cx"> this.buildNumber = function () { return rawRun.buildNumber; }
</span><span class="cx"> this.buildUrl = function () {
</span><del>- var template = builders[rawRun.builder].buildUrl;
- return template ? template.replace(/\$buildNumber/g, this.buildNumber()) : null;
</del><ins>+ var builder = builders[rawRun.builder];
+ var template = builder.buildUrl;
+ if (!template)
+ return null;
+ return template.replace(/\$buildNumber/g, this.buildNumber()).replace(/\$builderName/g, builder.name);
</ins><span class="cx"> }
</span><span class="cx"> this.platform = function () { return platform; }
</span><span class="cx"> this.revision = function(repositoryId) { return revisions[repositoryId][0]; }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (180119 => 180120)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-02-15 04:54:26 UTC (rev 180119)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-02-15 05:08:48 UTC (rev 180120)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> }.property('name', 'test'),
</span><span class="cx"> fullName: function ()
</span><span class="cx"> {
</span><del>- return this.get('path').join(' \u2208 ') /* &in; */
</del><ins>+ return this.get('path').join(' \u220b ') /* &ni; */
</ins><span class="cx"> + ' : ' + this.get('label');
</span><span class="cx"> }.property('path', 'label'),
</span><span class="cx"> });
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> urlFromBuildNumber: function (buildNumber)
</span><span class="cx"> {
</span><span class="cx"> var template = this.get('buildUrl');
</span><del>- return template ? template.replace(/\$buildNumber/g, buildNumber) : null;
</del><ins>+ return template ? template.replace(/\$builderName/g, this.get('name')).replace(/\$buildNumber/g, buildNumber) : null;
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>