<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[180106] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/180106">180106</a></dd>
<dt>Author</dt> <dd>ossy@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-14 00:56:28 -0800 (Sat, 14 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>[buildbot] Enable run-api-tests on release Mac bots
https://bugs.webkit.org/show_bug.cgi?id=141518
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunUnitTests):
(BuildFactory.__init__):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(RunUnitTests.start): Deleted.
(unitTestsSupported): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (180105 => 180106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2015-02-14 06:37:32 UTC (rev 180105)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2015-02-14 08:56:28 UTC (rev 180106)
</span><span class="lines">@@ -411,17 +411,9 @@
</span><span class="cx"> name = "run-api-tests"
</span><span class="cx"> description = ["unit tests running"]
</span><span class="cx"> descriptionDone = ["unit-tests"]
</span><del>- command = ["perl", "./Tools/Scripts/run-api-tests", WithProperties("--%(configuration)s"), "--verbose"]
</del><ins>+ command = ["perl", "./Tools/Scripts/run-api-tests", "--no-build", WithProperties("--%(configuration)s"), "--verbose"]
</ins><span class="cx"> failedTestsFormatString = "%d unit test%s failed or timed out"
</span><span class="cx">
</span><del>- def start(self):
- platform = self.getProperty('fullPlatform')
- if platform.startswith('win'):
- self.setCommand(self.command + ['--no-build'])
- if platform.startswith('mac'):
- self.setCommand(self.command + ['--no-build'])
- return shell.Test.start(self)
-
</del><span class="cx"> def countFailures(self, cmd):
</span><span class="cx"> log_text = cmd.logs['stdio'].getText()
</span><span class="cx"> count = 0
</span><span class="lines">@@ -775,11 +767,6 @@
</span><span class="cx"> self.addStep(UploadBuiltProduct())
</span><span class="cx"> self.addStep(trigger.Trigger(schedulerNames=triggers))
</span><span class="cx">
</span><del>-def unitTestsSupported(configuration, platform):
- if platform.startswith('mac') and configuration == "release":
- return False; # https://bugs.webkit.org/show_bug.cgi?id=82652
- return platform == 'win' or platform.startswith('mac')
-
</del><span class="cx"> def pickLatestBuild(builder, requests):
</span><span class="cx"> return max(requests, key=operator.attrgetter("submittedAt"))
</span><span class="cx">
</span><span class="lines">@@ -794,7 +781,7 @@
</span><span class="cx"> if self.LayoutTestClass:
</span><span class="cx"> self.addStep(self.LayoutTestClass())
</span><span class="cx">
</span><del>- if unitTestsSupported(configuration, platform):
</del><ins>+ if platform == 'win' or platform.startswith('mac'):
</ins><span class="cx"> self.addStep(RunUnitTests())
</span><span class="cx"> self.addStep(RunPythonTests())
</span><span class="cx"> self.addStep(RunPerlTests())
</span><span class="lines">@@ -819,8 +806,6 @@
</span><span class="cx"> self.addStep(RunJavaScriptCoreTests())
</span><span class="cx"> if self.LayoutTestClass:
</span><span class="cx"> self.addStep(self.LayoutTestClass())
</span><del>- if unitTestsSupported(configuration, platform):
- self.addStep(RunUnitTests())
</del><span class="cx"> self.addStep(RunPythonTests())
</span><span class="cx"> self.addStep(RunPerlTests())
</span><span class="cx"> self.addStep(RunBindingsTests())
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (180105 => 180106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-02-14 06:37:32 UTC (rev 180105)
+++ trunk/Tools/ChangeLog 2015-02-14 08:56:28 UTC (rev 180106)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
+
+ [buildbot] Enable run-api-tests on release Mac bots
+ https://bugs.webkit.org/show_bug.cgi?id=141518
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunUnitTests):
+ (BuildFactory.__init__):
+ (TestFactory.__init__):
+ (BuildAndTestFactory.__init__):
+ (RunUnitTests.start): Deleted.
+ (unitTestsSupported): Deleted.
+
</ins><span class="cx"> 2015-02-13 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a move constructor and move assignment operator to Deque
</span></span></pre>
</div>
</div>
</body>
</html>