<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179970] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179970">179970</a></dd>
<dt>Author</dt> <dd>mrowe@apple.com</dd>
<dt>Date</dt> <dd>2015-02-11 15:14:30 -0800 (Wed, 11 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre><https://webkit.org/b/141492> extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed
Avoid updating the target file if the contents haven't changed. This prevents Xcode from copying the identical
file into the framework and resigning it, which avoids the resulting relinking of all targets that depend on
the framework.
Reviewed by Dan Bernstein.
* extract-localizable-strings.pl: Write our output to a temporary file. If the output differs from the
existing contents of the target file, move the temporary file over the target file. Otherwise, delete
the temporary file.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreextractlocalizablestringspl">trunk/Source/WebCore/extract-localizable-strings.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179969 => 179970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-11 23:12:09 UTC (rev 179969)
+++ trunk/Source/WebCore/ChangeLog 2015-02-11 23:14:30 UTC (rev 179970)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-02-11 Mark Rowe <mrowe@apple.com>
+
+ <https://webkit.org/b/141492> extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed
+
+ Avoid updating the target file if the contents haven't changed. This prevents Xcode from copying the identical
+ file into the framework and resigning it, which avoids the resulting relinking of all targets that depend on
+ the framework.
+
+ Reviewed by Dan Bernstein.
+
+ * extract-localizable-strings.pl: Write our output to a temporary file. If the output differs from the
+ existing contents of the target file, move the temporary file over the target file. Otherwise, delete
+ the temporary file.
+
</ins><span class="cx"> 2015-02-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Turn recent assertions into release assertions to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
</span></span></pre></div>
<a id="trunkSourceWebCoreextractlocalizablestringspl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/extract-localizable-strings.pl (179969 => 179970)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/extract-localizable-strings.pl 2015-02-11 23:12:09 UTC (rev 179969)
+++ trunk/Source/WebCore/extract-localizable-strings.pl 2015-02-11 23:14:30 UTC (rev 179970)
</span><span class="lines">@@ -43,6 +43,8 @@
</span><span class="cx"> # The exceptions file has a list of strings in quotes, filenames, and filename/string pairs separated by :.
</span><span class="cx">
</span><span class="cx"> use strict;
</span><ins>+use File::Compare;
+use File::Copy;
</ins><span class="cx"> use Getopt::Long;
</span><span class="cx"> no warnings 'deprecated';
</span><span class="cx">
</span><span class="lines">@@ -401,9 +403,17 @@
</span><span class="cx"> if (-e "$fileToUpdate") {
</span><span class="cx"> if (!$verify) {
</span><span class="cx"> # Write out the strings file as UTF-8
</span><del>- open STRINGS, ">", "$fileToUpdate" or die;
</del><ins>+ my $temporaryFile = "$fileToUpdate.updated";
+ open STRINGS, ">", $temporaryFile or die;
</ins><span class="cx"> print STRINGS $localizedStrings;
</span><span class="cx"> close STRINGS;
</span><ins>+
+ # Avoid updating the target file's modification time if the contents have not changed.
+ if (compare($temporaryFile, $fileToUpdate)) {
+ move($temporaryFile, $fileToUpdate);
+ } else {
+ unlink $temporaryFile;
+ }
</ins><span class="cx"> } else {
</span><span class="cx"> open STRINGS, $fileToUpdate or die;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>