<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179974] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179974">179974</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2015-02-11 17:09:50 -0800 (Wed, 11 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Do not export functions defined in headers.
This prevents weak external symbol errors in some configurations.
* dom/Range.h:
(WebCore::Range::startContainer):
(WebCore::Range::startOffset):
(WebCore::Range::endContainer):
(WebCore::Range::endOffset):
* inspector/InspectorController.h:
* page/Settings.h:
(WebCore::Settings::setMediaKeysStorageDirectory):
* page/make_settings.pl:
(printGetterAndSetter):
* platform/network/cocoa/ProtectionSpaceCocoa.h:
(WebCore::ProtectionSpace::encodingRequiresPlatformData):
* platform/text/TextEncoding.h:
(WebCore::TextEncoding::decode):
Removed WEBCORE_EXPORT macros.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomRangeh">trunk/Source/WebCore/dom/Range.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllerh">trunk/Source/WebCore/inspector/InspectorController.h</a></li>
<li><a href="#trunkSourceWebCorepageSettingsh">trunk/Source/WebCore/page/Settings.h</a></li>
<li><a href="#trunkSourceWebCorepagemake_settingspl">trunk/Source/WebCore/page/make_settings.pl</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkcocoaProtectionSpaceCocoah">trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h</a></li>
<li><a href="#trunkSourceWebCoreplatformtextTextEncodingh">trunk/Source/WebCore/platform/text/TextEncoding.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/ChangeLog 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2015-02-11 Alex Christensen <achristensen@webkit.org>
+
+ Do not export functions defined in headers.
+ This prevents weak external symbol errors in some configurations.
+
+ * dom/Range.h:
+ (WebCore::Range::startContainer):
+ (WebCore::Range::startOffset):
+ (WebCore::Range::endContainer):
+ (WebCore::Range::endOffset):
+ * inspector/InspectorController.h:
+ * page/Settings.h:
+ (WebCore::Settings::setMediaKeysStorageDirectory):
+ * page/make_settings.pl:
+ (printGetterAndSetter):
+ * platform/network/cocoa/ProtectionSpaceCocoa.h:
+ (WebCore::ProtectionSpace::encodingRequiresPlatformData):
+ * platform/text/TextEncoding.h:
+ (WebCore::TextEncoding::decode):
+ Removed WEBCORE_EXPORT macros.
+
</ins><span class="cx"> 2015-02-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [WK2] Add logging to validate the network cache efficacy (Part 2)
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.h (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.h 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/dom/Range.h 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -58,10 +58,10 @@
</span><span class="cx">
</span><span class="cx"> Document& ownerDocument() const { return const_cast<Document&>(m_ownerDocument.get()); }
</span><span class="cx">
</span><del>- WEBCORE_EXPORT Node* startContainer() const { return m_start.container(); }
- WEBCORE_EXPORT int startOffset() const { return m_start.offset(); }
- WEBCORE_EXPORT Node* endContainer() const { return m_end.container(); }
- WEBCORE_EXPORT int endOffset() const { return m_end.offset(); }
</del><ins>+ Node* startContainer() const { return m_start.container(); }
+ int startOffset() const { return m_start.offset(); }
+ Node* endContainer() const { return m_end.container(); }
+ int endOffset() const { return m_end.offset(); }
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT Node* startContainer(ExceptionCode&) const;
</span><span class="cx"> WEBCORE_EXPORT int startOffset(ExceptionCode&) const;
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.h (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.h 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/inspector/InspectorController.h 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> void resume();
</span><span class="cx">
</span><span class="cx"> InspectorClient* inspectorClient() const { return m_inspectorClient; }
</span><del>- WEBCORE_EXPORT InspectorPageAgent* pageAgent() const { return m_pageAgent; }
</del><ins>+ InspectorPageAgent* pageAgent() const { return m_pageAgent; }
</ins><span class="cx">
</span><span class="cx"> virtual bool developerExtrasEnabled() const override;
</span><span class="cx"> virtual bool canAccessInspectedScriptState(JSC::ExecState*) const override;
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.h (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.h 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/page/Settings.h 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(ENCRYPTED_MEDIA_V2)
</span><del>- WEBCORE_EXPORT void setMediaKeysStorageDirectory(const String& directory) { m_mediaKeysStorageDirectory = directory; }
</del><ins>+ void setMediaKeysStorageDirectory(const String& directory) { m_mediaKeysStorageDirectory = directory; }
</ins><span class="cx"> const String& mediaKeysStorageDirectory() const { return m_mediaKeysStorageDirectory; }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepagemake_settingspl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/make_settings.pl (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/make_settings.pl 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/page/make_settings.pl 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -240,10 +240,10 @@
</span><span class="cx"> my ($file, $settingName, $type, $setNeedsStyleRecalcInAllFrames) = @_;
</span><span class="cx"> my $setterFunctionName = setterFunctionName($settingName);
</span><span class="cx"> if (lc(substr($type, 0, 1)) eq substr($type, 0, 1)) {
</span><del>- print $file " WEBCORE_EXPORT $type $settingName() const { return m_$settingName; } \\\n";
</del><ins>+ print $file " $type $settingName() const { return m_$settingName; } \\\n";
</ins><span class="cx"> print $file " WEBCORE_EXPORT void $setterFunctionName($type $settingName)";
</span><span class="cx"> } else {
</span><del>- print $file " WEBCORE_EXPORT const $type& $settingName() { return m_$settingName; } \\\n";
</del><ins>+ print $file " const $type& $settingName() { return m_$settingName; } \\\n";
</ins><span class="cx"> print $file " WEBCORE_EXPORT void $setterFunctionName(const $type& $settingName)";
</span><span class="cx"> }
</span><span class="cx"> if ($setNeedsStyleRecalcInAllFrames) {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkcocoaProtectionSpaceCocoah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx">
</span><span class="cx"> static bool platformCompare(const ProtectionSpace& a, const ProtectionSpace& b);
</span><span class="cx">
</span><del>- WEBCORE_EXPORT bool encodingRequiresPlatformData() const { return m_nsSpace && encodingRequiresPlatformData(m_nsSpace.get()); }
</del><ins>+ bool encodingRequiresPlatformData() const { return m_nsSpace && encodingRequiresPlatformData(m_nsSpace.get()); }
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT bool receivesCredentialSecurely() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextTextEncodingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/TextEncoding.h (179973 => 179974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/TextEncoding.h 2015-02-12 00:46:21 UTC (rev 179973)
+++ trunk/Source/WebCore/platform/text/TextEncoding.h 2015-02-12 01:09:50 UTC (rev 179974)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> const TextEncoding& closestByteBasedEquivalent() const;
</span><span class="cx"> const TextEncoding& encodingForFormSubmission() const;
</span><span class="cx">
</span><del>- WEBCORE_EXPORT String decode(const char* str, size_t length) const
</del><ins>+ String decode(const char* str, size_t length) const
</ins><span class="cx"> {
</span><span class="cx"> bool ignored;
</span><span class="cx"> return decode(str, length, false, ignored);
</span></span></pre>
</div>
</div>
</body>
</html>