<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179820] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179820">179820</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2015-02-08 23:09:50 -0800 (Sun, 08 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
https://bugs.webkit.org/show_bug.cgi?id=140485
Reviewed by Anders Carlsson.
Source/WebCore:
If setting an accessibility attribute results in a modal alert being displayed, it can cause VoiceOver
to hang. A simple solution is perform the actual work after a short delay, which will ensure the call
returns without hanging.
Test: platform/mac/accessibility/setting-attributes-is-asynchronous.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
Tools:
Implement takeFocus() as a way to set focus through accessibility wrappers.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::takeFocus):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::takeFocus):
LayoutTests:
Modify tests that relied on setting behavior and immediately checking results. Those
tests now need to retrieve results after a short timeout.
* accessibility/textarea-selected-text-range-expected.txt:
* accessibility/textarea-selected-text-range.html:
* platform/mac/accessibility/select-element-selection-with-optgroups.html:
* platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt: Added.
* platform/mac/accessibility/setting-attributes-is-asynchronous.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitytextareaselectedtextrangeexpectedtxt">trunk/LayoutTests/accessibility/textarea-selected-text-range-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitytextareaselectedtextrangehtml">trunk/LayoutTests/accessibility/textarea-selected-text-range.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityselectelementselectionwithoptgroupshtml">trunk/LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacAccessibilityUIElementMacmm">trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleBindingsAccessibilityUIElementidl">trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm">trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysettingattributesisasynchronousexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitysettingattributesisasynchronoushtml">trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/LayoutTests/ChangeLog 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2015-02-08 Chris Fleizach <cfleizach@apple.com>
+
+ AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
+ https://bugs.webkit.org/show_bug.cgi?id=140485
+
+ Reviewed by Anders Carlsson.
+
+ Modify tests that relied on setting behavior and immediately checking results. Those
+ tests now need to retrieve results after a short timeout.
+
+ * accessibility/textarea-selected-text-range-expected.txt:
+ * accessibility/textarea-selected-text-range.html:
+ * platform/mac/accessibility/select-element-selection-with-optgroups.html:
+ * platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt: Added.
+ * platform/mac/accessibility/setting-attributes-is-asynchronous.html: Added.
+
</ins><span class="cx"> 2015-02-08 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add parsing support for CSS Selector L4's case-insensitive attribute
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytextareaselectedtextrangeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/textarea-selected-text-range-expected.txt (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/textarea-selected-text-range-expected.txt 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/LayoutTests/accessibility/textarea-selected-text-range-expected.txt 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><del>-(4,0) = {4, 0}
</del><ins>+PASS textArea.selectedTextRange is '{4, 0}'
+PASS textArea.selectedTextRange is '{8, 2}'
+PASS textArea.selectedTextRange is '{25, 0}'
+PASS successfullyParsed is true
</ins><span class="cx">
</span><del>-(8,2) = {8, 2}
</del><ins>+TEST COMPLETE
</ins><span class="cx">
</span><del>-(100,0) = {25, 0}
-
-
</del></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytextareaselectedtextrangehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/textarea-selected-text-range.html (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/textarea-selected-text-range.html 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/LayoutTests/accessibility/textarea-selected-text-range.html 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1,8 +1,5 @@
</span><span class="cx"> <html>
</span><del>-<script>
- if (window.testRunner)
- testRunner.dumpAsText();
-</script>
</del><ins>+<script src="../resources/js-test-pre.js"></script>
</ins><span class="cx"> <body>
</span><span class="cx">
</span><span class="cx"> <div id="result"></div>
</span><span class="lines">@@ -15,23 +12,31 @@
</span><span class="cx">
</span><span class="cx"> <script>
</span><span class="cx"> if (window.accessibilityController) {
</span><del>- var result = document.getElementById("result");
-
</del><ins>+ window.jsTestIsAsync = true;
</ins><span class="cx"> var area1 = document.getElementById("area1");
</span><span class="cx"> area1.focus();
</span><span class="cx">
</span><span class="cx"> var textArea = accessibilityController.focusedElement;
</span><span class="cx">
</span><span class="cx"> textArea.setSelectedTextRange(4,0);
</span><del>- result.innerText += "(4,0) = " + textArea.selectedTextRange + "\n\n";
</del><span class="cx">
</span><del>- textArea.setSelectedTextRange(8,2);
- result.innerText += "(8,2) = " + textArea.selectedTextRange + "\n\n";
</del><ins>+ // After setting a property through accessibility, the value won't be updated immediately, so we
+ // must check after a timeout to re-verify the value.
+ setTimeout(function() {
+ shouldBe("textArea.selectedTextRange", "'{4, 0}'");
+ textArea.setSelectedTextRange(8,2);
+ setTimeout(function() {
+ shouldBe("textArea.selectedTextRange", "'{8, 2}'");
+ textArea.setSelectedTextRange(100,0);
+ setTimeout(function() {
+ shouldBe("textArea.selectedTextRange", "'{25, 0}'");
+ finishJSTest();
+ }, 1);
+ }, 1);
+ }, 1);
</ins><span class="cx">
</span><del>- textArea.setSelectedTextRange(100,0);
- result.innerText += "(100,0) = " + textArea.selectedTextRange + "\n\n";
-
</del><span class="cx"> }
</span><span class="cx"> </script>
</span><ins>+<script src="../resources/js-test-post.js"></script>
</ins><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityselectelementselectionwithoptgroupshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> description("This tests that setting selection within a list box works correctly if there are optgroups");
</span><span class="cx">
</span><span class="cx"> if (window.accessibilityController) {
</span><ins>+ window.jsTestIsAsync = true;
</ins><span class="cx">
</span><span class="cx"> document.getElementById("suite").focus();
</span><span class="cx"> var selectElement = accessibilityController.focusedElement;
</span><span class="lines">@@ -36,17 +37,26 @@
</span><span class="cx"> var option2 = selectElement.childAtIndex(2);
</span><span class="cx"> var option3 = selectElement.childAtIndex(4);
</span><span class="cx">
</span><ins>+ // Selection operations happen after a delay so they don't hang. Check the result on a timeout.
</ins><span class="cx"> selectElement.setSelectedChild(option1);
</span><del>- shouldBe("selectElement.selectedChildrenCount", "1");
- shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option1)");
</del><ins>+ setTimeout(function() {
+ shouldBe("selectElement.selectedChildrenCount", "1");
+ shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option1)");
</ins><span class="cx">
</span><del>- selectElement.setSelectedChild(option2);
- shouldBe("selectElement.selectedChildrenCount", "1");
- shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option2)");
</del><ins>+ selectElement.setSelectedChild(option2);
+ setTimeout(function() {
+ shouldBe("selectElement.selectedChildrenCount", "1");
+ shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option2)");
</ins><span class="cx">
</span><del>- selectElement.setSelectedChild(option3);
- shouldBe("selectElement.selectedChildrenCount", "1");
- shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option3)");
</del><ins>+ selectElement.setSelectedChild(option3);
+ setTimeout(function() {
+ shouldBe("selectElement.selectedChildrenCount", "1");
+ shouldBeTrue("selectElement.selectedChildAtIndex(0).isEqual(option3)");
+ finishJSTest();
+ }, 1);
+ }, 1);
+ }, 1);
+
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysettingattributesisasynchronousexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt (0 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+
+This tests makes sure that setting accessibility attributes happens asychronously, so that a caller won't hang if the result is an alert.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+This line should be printed first
+This line should be printed second.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitysettingattributesisasynchronoushtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html (0 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+
+<input type="text" id="textfield" onfocus="debug('This line should be printed second.'); finishJSTest(); ">
+
+<div id="description"></div>
+<div id="console"></div>
+
+<script>
+
+description("This tests makes sure that setting accessibility attributes happens asychronously, so that a caller won't hang if the result is an alert.")
+
+if (window.testRunner && window.accessibilityController) {
+
+ window.jsTestIsAsync = true;
+ var textfield = accessibilityController.accessibleElementById("textfield");
+ textfield.takeFocus();
+ debug("This line should be printed first");
+}
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Source/WebCore/ChangeLog 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2015-02-08 Chris Fleizach <cfleizach@apple.com>
+
+ AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
+ https://bugs.webkit.org/show_bug.cgi?id=140485
+
+ Reviewed by Anders Carlsson.
+
+ If setting an accessibility attribute results in a modal alert being displayed, it can cause VoiceOver
+ to hang. A simple solution is perform the actual work after a short delay, which will ensure the call
+ returns without hanging.
+
+ Test: platform/mac/accessibility/setting-attributes-is-asynchronous.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
+ (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
+
</ins><span class="cx"> 2015-02-08 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add parsing support for CSS Selector L4's case-insensitive attribute
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -3246,6 +3246,15 @@
</span><span class="cx">
</span><span class="cx"> - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
</span><span class="cx"> {
</span><ins>+ // In case anything we do by changing values causes an alert or other modal
+ // behaviors, we need to return now, so that VoiceOver doesn't hang indefinitely.
+ dispatch_async(dispatch_get_main_queue(), ^{
+ [self _accessibilitySetValue:value forAttribute:attributeName];
+ });
+}
+
+- (void)_accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
+{
</ins><span class="cx"> if (![self updateObjectBackingStore])
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Tools/ChangeLog 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-02-08 Chris Fleizach <cfleizach@apple.com>
+
+ AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
+ https://bugs.webkit.org/show_bug.cgi?id=140485
+
+ Reviewed by Anders Carlsson.
+
+ Implement takeFocus() as a way to set focus through accessibility wrappers.
+
+ * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+ (AccessibilityUIElement::takeFocus):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::takeFocus):
+
</ins><span class="cx"> 2015-02-08 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove the SVG instance tree
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacAccessibilityUIElementMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1517,7 +1517,9 @@
</span><span class="cx">
</span><span class="cx"> void AccessibilityUIElement::takeFocus()
</span><span class="cx"> {
</span><del>- // FIXME: implement
</del><ins>+ BEGIN_AX_OBJC_EXCEPTIONS
+ [m_element accessibilitySetValue:@YES forAttribute:NSAccessibilityFocusedAttribute];
+ END_AX_OBJC_EXCEPTIONS
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void AccessibilityUIElement::takeSelection()
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleBindingsAccessibilityUIElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -168,6 +168,7 @@
</span><span class="cx"> readonly attribute AccessibilityUIElement verticalScrollbar;
</span><span class="cx">
</span><span class="cx"> void scrollToMakeVisible();
</span><ins>+ void takeFocus();
</ins><span class="cx">
</span><span class="cx"> // Text markers.
</span><span class="cx"> AccessibilityTextMarkerRange lineTextMarkerRangeForTextMarker(AccessibilityTextMarker textMarker);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundlemacAccessibilityUIElementMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (179819 => 179820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-02-09 03:44:57 UTC (rev 179819)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2015-02-09 07:09:50 UTC (rev 179820)
</span><span class="lines">@@ -1532,7 +1532,9 @@
</span><span class="cx">
</span><span class="cx"> void AccessibilityUIElement::takeFocus()
</span><span class="cx"> {
</span><del>- // FIXME: implement
</del><ins>+ BEGIN_AX_OBJC_EXCEPTIONS
+ [m_element accessibilitySetValue:@YES forAttribute:NSAccessibilityFocusedAttribute];
+ END_AX_OBJC_EXCEPTIONS
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void AccessibilityUIElement::takeSelection()
</span></span></pre>
</div>
</div>
</body>
</html>