<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179796] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179796">179796</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2015-02-08 00:02:48 -0800 (Sun, 08 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: The input element with type="search" has no default focus outline
https://bugs.webkit.org/show_bug.cgi?id=140326
Reviewed by Darin Adler.
Source/WebCore:
The platform RenderTheme takes care of the search field, and that code
was missing a check for whether the element was focused.
Test: fast/css/focus-ring-exists-for-search-field.html
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchField):
LayoutTests:
* fast/css/focus-ring-exists-for-search-field.html: Added.
* platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
* platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssfocusringexistsforsearchfieldhtml">trunk/LayoutTests/fast/css/focus-ring-exists-for-search-field.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastcssfocusringexistsforsearchfieldexpectedpng">trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastcssfocusringexistsforsearchfieldexpectedtxt">trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (179795 => 179796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-02-08 07:54:20 UTC (rev 179795)
+++ trunk/LayoutTests/ChangeLog 2015-02-08 08:02:48 UTC (rev 179796)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2015-02-07 Chris Fleizach <cfleizach@apple.com>
+
+ AX: The input element with type="search" has no default focus outline
+ https://bugs.webkit.org/show_bug.cgi?id=140326
+
+ Reviewed by Darin Adler.
+
+ * fast/css/focus-ring-exists-for-search-field.html: Added.
+ * platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
+ * platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
+
</ins><span class="cx"> 2015-02-07 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssfocusringexistsforsearchfieldhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/focus-ring-exists-for-search-field.html (0 => 179796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/focus-ring-exists-for-search-field.html (rev 0)
+++ trunk/LayoutTests/fast/css/focus-ring-exists-for-search-field.html 2015-02-08 08:02:48 UTC (rev 179796)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+<html>
+<head>
+<script>
+window.onload = function()
+{
+ document.getElementById("search").focus();
+}
+</script>
+</head>
+<body>
+<p>Assuming the port-specific theme draws focus rings, this test can be used to ensure that a focus ring is drawn around a search field.</p>
+<input type="search" id="search">
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastcssfocusringexistsforsearchfieldexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsplatformmacfastcssfocusringexistsforsearchfieldexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt (0 => 179796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt 2015-02-08 08:02:48 UTC (rev 179796)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x36
+ RenderText {#text} at (0,0) size 757x36
+ text run at (0,0) width 757: "Assuming the port-specific theme draws focus rings, this test can be used to ensure that a focus ring is drawn around a"
+ text run at (0,18) width 78: "search field."
+ RenderBlock (anonymous) at (0,52) size 784x23
+ RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
+ RenderBlock {DIV} at (0,1) size 8x11
+ RenderBlock {DIV} at (8,0) size 131x13
+ RenderBlock {DIV} at (138,1) size 14x11
+ RenderText {#text} at (0,0) size 0x0
+layer at (21,65) size 130x13
+ RenderBlock {DIV} at (0,0) size 131x13
+caret: position 0 of child 0 {DIV} of child 1 {DIV} of child 0 {DIV} of {#document-fragment} of child 3 {INPUT} of body
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179795 => 179796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-08 07:54:20 UTC (rev 179795)
+++ trunk/Source/WebCore/ChangeLog 2015-02-08 08:02:48 UTC (rev 179796)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-02-07 Chris Fleizach <cfleizach@apple.com>
+
+ AX: The input element with type="search" has no default focus outline
+ https://bugs.webkit.org/show_bug.cgi?id=140326
+
+ Reviewed by Darin Adler.
+
+ The platform RenderTheme takes care of the search field, and that code
+ was missing a check for whether the element was focused.
+
+ Test: fast/css/focus-ring-exists-for-search-field.html
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSearchField):
+
</ins><span class="cx"> 2015-02-07 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Add some dictionary lookup tests
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (179795 => 179796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-02-08 07:54:20 UTC (rev 179795)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-02-08 08:02:48 UTC (rev 179796)
</span><span class="lines">@@ -1572,11 +1572,17 @@
</span><span class="cx"> // Set the search button to nil before drawing. Then reset it so we can draw it later.
</span><span class="cx"> [search setSearchButtonCell:nil];
</span><span class="cx">
</span><del>- [search drawWithFrame:NSRect(unzoomedRect) inView:documentViewFor(o)];
</del><ins>+ NSView *documentView = documentViewFor(o);
+ [search drawWithFrame:NSRect(unzoomedRect) inView:documentView];
</ins><span class="cx">
</span><span class="cx"> [search setControlView:nil];
</span><span class="cx"> [search resetSearchButtonCell];
</span><span class="cx">
</span><ins>+ if (isFocused(o) && o.style().outlineStyleIsAuto()) {
+ if (wkDrawCellFocusRingWithFrameAtTime(search, NSRect(unzoomedRect), documentView, std::numeric_limits<double>::max()))
+ o.document().page()->focusController().setFocusedElementNeedsRepaint();
+ }
+
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>