<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179770] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179770">179770</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2015-02-06 17:08:52 -0800 (Fri, 06 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Ref-ify various getters that return HTMLCollection.
<https://webkit.org/b/141336>
Reviewed by Anders Carlsson.
Make all the getters that return HTMLCollection objects (and never return nullptr)
return Ref instead of RefPtr.
Removed a couple of useless null checks that were exposed by this change.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* dom/Document.cpp:
(WebCore::Document::ensureCachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::iconURLs):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::ensureCachedHTMLCollection):
* dom/Element.h:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestions):
* html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
* html/HTMLDataListElement.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
* html/HTMLElement.h:
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
* html/HTMLFieldSetElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::areas):
* html/HTMLMapElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
* html/HTMLSelectElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
* html/HTMLTableElement.h:
* html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
* html/HTMLTableRowElement.h:
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
* html/HTMLTableSectionElement.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::updateTickMarkValues):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLDocumentCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCorehtmlColorInputTypecpp">trunk/Source/WebCore/html/ColorInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDataListElementcpp">trunk/Source/WebCore/html/HTMLDataListElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDataListElementh">trunk/Source/WebCore/html/HTMLDataListElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementh">trunk/Source/WebCore/html/HTMLElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFieldSetElementcpp">trunk/Source/WebCore/html/HTMLFieldSetElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFieldSetElementh">trunk/Source/WebCore/html/HTMLFieldSetElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementcpp">trunk/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementh">trunk/Source/WebCore/html/HTMLFormElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementcpp">trunk/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMapElementcpp">trunk/Source/WebCore/html/HTMLMapElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMapElementh">trunk/Source/WebCore/html/HTMLMapElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementh">trunk/Source/WebCore/html/HTMLSelectElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementcpp">trunk/Source/WebCore/html/HTMLTableElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementh">trunk/Source/WebCore/html/HTMLTableElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableRowElementcpp">trunk/Source/WebCore/html/HTMLTableRowElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableRowElementh">trunk/Source/WebCore/html/HTMLTableRowElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableSectionElementcpp">trunk/Source/WebCore/html/HTMLTableSectionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableSectionElementh">trunk/Source/WebCore/html/HTMLTableSectionElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlRangeInputTypecpp">trunk/Source/WebCore/html/RangeInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
<li><a href="#trunkSourceWebKitwinDOMHTMLClassescpp">trunk/Source/WebKit/win/DOMHTMLClasses.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/ChangeLog 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -1,3 +1,81 @@
</span><ins>+2015-02-06 Andreas Kling <akling@apple.com>
+
+ Ref-ify various getters that return HTMLCollection.
+ <https://webkit.org/b/141336>
+
+ Reviewed by Anders Carlsson.
+
+ Make all the getters that return HTMLCollection objects (and never return nullptr)
+ return Ref instead of RefPtr.
+
+ Removed a couple of useless null checks that were exposed by this change.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::getDocumentLinks):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::namedItemGetter):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::nameGetter):
+ * dom/Document.cpp:
+ (WebCore::Document::ensureCachedCollection):
+ (WebCore::Document::images):
+ (WebCore::Document::applets):
+ (WebCore::Document::embeds):
+ (WebCore::Document::plugins):
+ (WebCore::Document::scripts):
+ (WebCore::Document::links):
+ (WebCore::Document::forms):
+ (WebCore::Document::anchors):
+ (WebCore::Document::all):
+ (WebCore::Document::windowNamedItems):
+ (WebCore::Document::documentNamedItems):
+ (WebCore::Document::iconURLs):
+ * dom/Document.h:
+ * dom/Element.cpp:
+ (WebCore::Element::ensureCachedHTMLCollection):
+ * dom/Element.h:
+ * html/ColorInputType.cpp:
+ (WebCore::ColorInputType::suggestions):
+ * html/HTMLDataListElement.cpp:
+ (WebCore::HTMLDataListElement::options):
+ * html/HTMLDataListElement.h:
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::children):
+ * html/HTMLElement.h:
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::elements):
+ * html/HTMLFieldSetElement.h:
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::elements):
+ * html/HTMLFormElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setupDateTimeChooserParameters):
+ * html/HTMLMapElement.cpp:
+ (WebCore::HTMLMapElement::areas):
+ * html/HTMLMapElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::selectedOptions):
+ (WebCore::HTMLSelectElement::options):
+ * html/HTMLSelectElement.h:
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::rows):
+ (WebCore::HTMLTableElement::tBodies):
+ * html/HTMLTableElement.h:
+ * html/HTMLTableRowElement.cpp:
+ (WebCore::HTMLTableRowElement::insertCell):
+ (WebCore::HTMLTableRowElement::deleteCell):
+ (WebCore::HTMLTableRowElement::cells):
+ * html/HTMLTableRowElement.h:
+ * html/HTMLTableSectionElement.cpp:
+ (WebCore::HTMLTableSectionElement::insertRow):
+ (WebCore::HTMLTableSectionElement::deleteRow):
+ (WebCore::HTMLTableSectionElement::rows):
+ * html/HTMLTableSectionElement.h:
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::updateTickMarkValues):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::paintSliderTicks):
+
</ins><span class="cx"> 2015-02-06 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Implement audio track selection in fullscreen.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -1741,7 +1741,7 @@
</span><span class="cx"> void AccessibilityRenderObject::getDocumentLinks(AccessibilityChildrenVector& result)
</span><span class="cx"> {
</span><span class="cx"> Document& document = m_renderer->document();
</span><del>- RefPtr<HTMLCollection> links = document.links();
</del><ins>+ Ref<HTMLCollection> links = document.links();
</ins><span class="cx"> for (unsigned i = 0; Node* curr = links->item(i); i++) {
</span><span class="cx"> RenderObject* obj = curr->renderer();
</span><span class="cx"> if (obj) {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><span class="cx"> if (UNLIKELY(downcast<HTMLDocument>(*document).windowNamedItemContainsMultipleElements(*atomicPropertyName))) {
</span><del>- RefPtr<HTMLCollection> collection = document->windowNamedItems(atomicPropertyName);
</del><ins>+ Ref<HTMLCollection> collection = document->windowNamedItems(atomicPropertyName);
</ins><span class="cx"> ASSERT(collection->length() > 1);
</span><span class="cx"> return JSValue::encode(toJS(exec, thisObj->globalObject(), WTF::getPtr(collection)));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLDocumentCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><span class="cx"> if (UNLIKELY(document.documentNamedItemContainsMultipleElements(*atomicPropertyName))) {
</span><del>- RefPtr<HTMLCollection> collection = document.documentNamedItems(atomicPropertyName);
</del><ins>+ Ref<HTMLCollection> collection = document.documentNamedItems(atomicPropertyName);
</ins><span class="cx"> ASSERT(collection->length() > 1);
</span><span class="cx"> return JSValue::encode(toJS(exec, thisObj->globalObject(), WTF::getPtr(collection)));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -4537,63 +4537,63 @@
</span><span class="cx"> return documentElement() && documentElement()->hasTagName(SVGNames::svgTag);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::ensureCachedCollection(CollectionType type)
</del><ins>+Ref<HTMLCollection> Document::ensureCachedCollection(CollectionType type)
</ins><span class="cx"> {
</span><span class="cx"> return ensureRareData().ensureNodeLists().addCachedCollection<HTMLCollection>(*this, type);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::images()
</del><ins>+Ref<HTMLCollection> Document::images()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocImages);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::applets()
</del><ins>+Ref<HTMLCollection> Document::applets()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocApplets);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::embeds()
</del><ins>+Ref<HTMLCollection> Document::embeds()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocEmbeds);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::plugins()
</del><ins>+Ref<HTMLCollection> Document::plugins()
</ins><span class="cx"> {
</span><span class="cx"> // This is an alias for embeds() required for the JS DOM bindings.
</span><span class="cx"> return ensureCachedCollection(DocEmbeds);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::scripts()
</del><ins>+Ref<HTMLCollection> Document::scripts()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocScripts);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::links()
</del><ins>+Ref<HTMLCollection> Document::links()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocLinks);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::forms()
</del><ins>+Ref<HTMLCollection> Document::forms()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocForms);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::anchors()
</del><ins>+Ref<HTMLCollection> Document::anchors()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedCollection(DocAnchors);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::all()
</del><ins>+Ref<HTMLCollection> Document::all()
</ins><span class="cx"> {
</span><span class="cx"> return ensureRareData().ensureNodeLists().addCachedCollection<HTMLAllCollection>(*this, DocAll);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::windowNamedItems(const AtomicString& name)
</del><ins>+Ref<HTMLCollection> Document::windowNamedItems(const AtomicString& name)
</ins><span class="cx"> {
</span><span class="cx"> return ensureRareData().ensureNodeLists().addCachedCollection<WindowNameCollection>(*this, WindowNamedItems, name);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Document::documentNamedItems(const AtomicString& name)
</del><ins>+Ref<HTMLCollection> Document::documentNamedItems(const AtomicString& name)
</ins><span class="cx"> {
</span><span class="cx"> return ensureRareData().ensureNodeLists().addCachedCollection<DocumentNameCollection>(*this, DocumentNamedItems, name);
</span><span class="cx"> }
</span><span class="lines">@@ -4704,10 +4704,10 @@
</span><span class="cx"> {
</span><span class="cx"> m_iconURLs.clear();
</span><span class="cx">
</span><del>- if (!head() || !(head()->children()))
</del><ins>+ if (!head())
</ins><span class="cx"> return m_iconURLs;
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> children = head()->children();
</del><ins>+ Ref<HTMLCollection> children = head()->children();
</ins><span class="cx"> unsigned int length = children->length();
</span><span class="cx"> for (unsigned int i = 0; i < length; ++i) {
</span><span class="cx"> Node* child = children->item(i);
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/dom/Document.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -506,18 +506,18 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<Node> adoptNode(PassRefPtr<Node> source, ExceptionCode&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> images();
- RefPtr<HTMLCollection> embeds();
- RefPtr<HTMLCollection> plugins(); // an alias for embeds() required for the JS DOM bindings.
- RefPtr<HTMLCollection> applets();
- RefPtr<HTMLCollection> links();
- RefPtr<HTMLCollection> forms();
- RefPtr<HTMLCollection> anchors();
- RefPtr<HTMLCollection> scripts();
- RefPtr<HTMLCollection> all();
</del><ins>+ Ref<HTMLCollection> images();
+ Ref<HTMLCollection> embeds();
+ Ref<HTMLCollection> plugins(); // an alias for embeds() required for the JS DOM bindings.
+ Ref<HTMLCollection> applets();
+ Ref<HTMLCollection> links();
+ Ref<HTMLCollection> forms();
+ Ref<HTMLCollection> anchors();
+ Ref<HTMLCollection> scripts();
+ Ref<HTMLCollection> all();
</ins><span class="cx">
</span><del>- RefPtr<HTMLCollection> windowNamedItems(const AtomicString& name);
- RefPtr<HTMLCollection> documentNamedItems(const AtomicString& name);
</del><ins>+ Ref<HTMLCollection> windowNamedItems(const AtomicString& name);
+ Ref<HTMLCollection> documentNamedItems(const AtomicString& name);
</ins><span class="cx">
</span><span class="cx"> // Other methods (not part of DOM)
</span><span class="cx"> bool isSynthesized() const { return m_isSynthesized; }
</span><span class="lines">@@ -1351,7 +1351,7 @@
</span><span class="cx">
</span><span class="cx"> Node* nodeFromPoint(const LayoutPoint& clientPoint, LayoutPoint* localPoint = nullptr);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> ensureCachedCollection(CollectionType);
</del><ins>+ Ref<HTMLCollection> ensureCachedCollection(CollectionType);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><span class="cx"> void dispatchFullScreenChangeOrErrorEvent(Deque<RefPtr<Node>>&, const AtomicString& eventName, bool shouldNotifyMediaElement);
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/dom/Element.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -2901,10 +2901,10 @@
</span><span class="cx"> dispatchSubtreeModifiedEvent();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> Element::ensureCachedHTMLCollection(CollectionType type)
</del><ins>+Ref<HTMLCollection> Element::ensureCachedHTMLCollection(CollectionType type)
</ins><span class="cx"> {
</span><span class="cx"> if (HTMLCollection* collection = cachedHTMLCollection(type))
</span><del>- return collection;
</del><ins>+ return *collection;
</ins><span class="cx">
</span><span class="cx"> if (type == TableRows) {
</span><span class="cx"> return ensureRareData().ensureNodeLists().addCachedCollection<HTMLTableRowsCollection>(downcast<HTMLTableElement>(*this), type);
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/dom/Element.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -570,7 +570,7 @@
</span><span class="cx"> void clearTabIndexExplicitlyIfNeeded();
</span><span class="cx"> void setTabIndexExplicitly(short);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> ensureCachedHTMLCollection(CollectionType);
</del><ins>+ Ref<HTMLCollection> ensureCachedHTMLCollection(CollectionType);
</ins><span class="cx"> HTMLCollection* cachedHTMLCollection(CollectionType);
</span><span class="cx">
</span><span class="cx"> // classAttributeChanged() exists to share code between
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlColorInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ColorInputType.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ColorInputType.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/ColorInputType.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -229,7 +229,7 @@
</span><span class="cx"> #if ENABLE(DATALIST_ELEMENT)
</span><span class="cx"> HTMLDataListElement* dataList = element().dataList();
</span><span class="cx"> if (dataList) {
</span><del>- RefPtr<HTMLCollection> options = dataList->options();
</del><ins>+ Ref<HTMLCollection> options = dataList->options();
</ins><span class="cx"> for (unsigned i = 0; HTMLOptionElement* option = downcast<HTMLOptionElement>(options->item(i)); ++i) {
</span><span class="cx"> if (!element().isValidValue(option->value()))
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDataListElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDataListElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDataListElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLDataListElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> return adoptRef(*new HTMLDataListElement(tagName, document));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLDataListElement::options()
</del><ins>+Ref<HTMLCollection> HTMLDataListElement::options()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(DataListOptions);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDataListElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDataListElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDataListElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLDataListElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<HTMLDataListElement> create(const QualifiedName&, Document&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> options();
</del><ins>+ Ref<HTMLCollection> options();
</ins><span class="cx">
</span><span class="cx"> void optionElementChildrenChanged();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -806,7 +806,7 @@
</span><span class="cx"> setAttribute(translateAttr, enable ? "yes" : "no");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLElement::children()
</del><ins>+Ref<HTMLCollection> HTMLElement::children()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(NodeChildren);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<HTMLElement> create(const QualifiedName& tagName, Document&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> children();
</del><ins>+ Ref<HTMLCollection> children();
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT virtual String title() const override final;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFieldSetElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFieldSetElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> return const_cast<HTMLLegendElement*>(childrenOfType<HTMLLegendElement>(*this).first());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLFieldSetElement::elements()
</del><ins>+Ref<HTMLCollection> HTMLFieldSetElement::elements()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(FormControls);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFieldSetElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFieldSetElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> static Ref<HTMLFieldSetElement> create(const QualifiedName&, Document&, HTMLFormElement*);
</span><span class="cx">
</span><span class="cx"> HTMLLegendElement* legend() const;
</span><del>- RefPtr<HTMLCollection> elements();
</del><ins>+ Ref<HTMLCollection> elements();
</ins><span class="cx">
</span><span class="cx"> const Vector<FormAssociatedElement*>& associatedElements() const;
</span><span class="cx"> unsigned length() const;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -644,7 +644,7 @@
</span><span class="cx"> ASSERT_UNUSED(removed, removed);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLFormElement::elements()
</del><ins>+Ref<HTMLCollection> HTMLFormElement::elements()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(FormControls);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLFormElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> static Ref<HTMLFormElement> create(const QualifiedName&, Document&);
</span><span class="cx"> virtual ~HTMLFormElement();
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> elements();
</del><ins>+ Ref<HTMLCollection> elements();
</ins><span class="cx"> bool hasNamedElement(const AtomicString&);
</span><span class="cx"> Vector<Ref<Element>> namedElements(const AtomicString&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -1887,7 +1887,7 @@
</span><span class="cx"> parameters.isAnchorElementRTL = computedStyle()->direction() == RTL;
</span><span class="cx"> #if ENABLE(DATALIST_ELEMENT)
</span><span class="cx"> if (HTMLDataListElement* dataList = this->dataList()) {
</span><del>- RefPtr<HTMLCollection> options = dataList->options();
</del><ins>+ Ref<HTMLCollection> options = dataList->options();
</ins><span class="cx"> for (unsigned i = 0; HTMLOptionElement* option = downcast<HTMLOptionElement>(options->item(i)); ++i) {
</span><span class="cx"> if (!isValidValue(option->value()))
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMapElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMapElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMapElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLMapElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> HTMLElement::parseAttribute(name, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLMapElement::areas()
</del><ins>+Ref<HTMLCollection> HTMLMapElement::areas()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(MapAreas);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMapElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMapElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMapElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLMapElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> bool mapMouseEvent(LayoutPoint location, const LayoutSize&, HitTestResult&);
</span><span class="cx">
</span><span class="cx"> HTMLImageElement* imageElement();
</span><del>- RefPtr<HTMLCollection> areas();
</del><ins>+ Ref<HTMLCollection> areas();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> HTMLMapElement(const QualifiedName&, Document&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -373,12 +373,12 @@
</span><span class="cx"> return validationMessageShadowTreeContains(child);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLSelectElement::selectedOptions()
</del><ins>+Ref<HTMLCollection> HTMLSelectElement::selectedOptions()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(SelectedOptions);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLOptionsCollection> HTMLSelectElement::options()
</del><ins>+Ref<HTMLOptionsCollection> HTMLSelectElement::options()
</ins><span class="cx"> {
</span><span class="cx"> return downcast<HTMLOptionsCollection>(ensureCachedHTMLCollection(SelectOptions).get());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLSelectElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -67,8 +67,8 @@
</span><span class="cx"> WEBCORE_EXPORT String value() const;
</span><span class="cx"> void setValue(const String&);
</span><span class="cx">
</span><del>- RefPtr<HTMLOptionsCollection> options();
- RefPtr<HTMLCollection> selectedOptions();
</del><ins>+ Ref<HTMLOptionsCollection> options();
+ Ref<HTMLCollection> selectedOptions();
</ins><span class="cx">
</span><span class="cx"> void optionElementChildrenChanged();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -550,12 +550,12 @@
</span><span class="cx"> return attribute.name() == backgroundAttr || HTMLElement::isURLAttribute(attribute);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLTableElement::rows()
</del><ins>+Ref<HTMLCollection> HTMLTableElement::rows()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(TableRows);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLTableElement::tBodies()
</del><ins>+Ref<HTMLCollection> HTMLTableElement::tBodies()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(TableTBodies);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -60,8 +60,8 @@
</span><span class="cx"> RefPtr<HTMLElement> insertRow(int index, ExceptionCode&);
</span><span class="cx"> void deleteRow(int index, ExceptionCode&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> rows();
- RefPtr<HTMLCollection> tBodies();
</del><ins>+ Ref<HTMLCollection> rows();
+ Ref<HTMLCollection> tBodies();
</ins><span class="cx">
</span><span class="cx"> const AtomicString& rules() const;
</span><span class="cx"> const AtomicString& summary() const;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableRowElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableRowElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableRowElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableRowElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -120,8 +120,8 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<HTMLElement> HTMLTableRowElement::insertCell(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- RefPtr<HTMLCollection> children = cells();
- int numCells = children ? children->length() : 0;
</del><ins>+ Ref<HTMLCollection> children = cells();
+ int numCells = children->length();
</ins><span class="cx"> if (index < -1 || index > numCells) {
</span><span class="cx"> ec = INDEX_SIZE_ERR;
</span><span class="cx"> return 0;
</span><span class="lines">@@ -143,8 +143,8 @@
</span><span class="cx">
</span><span class="cx"> void HTMLTableRowElement::deleteCell(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- RefPtr<HTMLCollection> children = cells();
- int numCells = children ? children->length() : 0;
</del><ins>+ Ref<HTMLCollection> children = cells();
+ int numCells = children->length();
</ins><span class="cx"> if (index == -1)
</span><span class="cx"> index = numCells-1;
</span><span class="cx"> if (index >= 0 && index < numCells) {
</span><span class="lines">@@ -154,7 +154,7 @@
</span><span class="cx"> ec = INDEX_SIZE_ERR;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLTableRowElement::cells()
</del><ins>+Ref<HTMLCollection> HTMLTableRowElement::cells()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(TRCells);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableRowElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableRowElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableRowElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableRowElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> RefPtr<HTMLElement> insertCell(int index, ExceptionCode&);
</span><span class="cx"> void deleteCell(int index, ExceptionCode&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> cells();
</del><ins>+ Ref<HTMLCollection> cells();
</ins><span class="cx"> void setCells(HTMLCollection *, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableSectionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableSectionElement.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableSectionElement.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableSectionElement.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -59,8 +59,8 @@
</span><span class="cx"> RefPtr<HTMLElement> HTMLTableSectionElement::insertRow(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<HTMLTableRowElement> row;
</span><del>- RefPtr<HTMLCollection> children = rows();
- int numRows = children ? (int)children->length() : 0;
</del><ins>+ Ref<HTMLCollection> children = rows();
+ int numRows = children->length();
</ins><span class="cx"> if (index < -1 || index > numRows)
</span><span class="cx"> ec = INDEX_SIZE_ERR; // per the DOM
</span><span class="cx"> else {
</span><span class="lines">@@ -81,8 +81,8 @@
</span><span class="cx">
</span><span class="cx"> void HTMLTableSectionElement::deleteRow(int index, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- RefPtr<HTMLCollection> children = rows();
- int numRows = children ? (int)children->length() : 0;
</del><ins>+ Ref<HTMLCollection> children = rows();
+ int numRows = children->length();
</ins><span class="cx"> if (index == -1)
</span><span class="cx"> index = numRows - 1;
</span><span class="cx"> if (index >= 0 && index < numRows) {
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx"> setAttribute(valignAttr, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<HTMLCollection> HTMLTableSectionElement::rows()
</del><ins>+Ref<HTMLCollection> HTMLTableSectionElement::rows()
</ins><span class="cx"> {
</span><span class="cx"> return ensureCachedHTMLCollection(TSectionRows);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableSectionElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableSectionElement.h (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableSectionElement.h 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/HTMLTableSectionElement.h 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> const AtomicString& vAlign() const;
</span><span class="cx"> void setVAlign(const AtomicString&);
</span><span class="cx">
</span><del>- RefPtr<HTMLCollection> rows();
</del><ins>+ Ref<HTMLCollection> rows();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> HTMLTableSectionElement(const QualifiedName& tagName, Document&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRangeInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RangeInputType.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RangeInputType.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -368,7 +368,7 @@
</span><span class="cx"> HTMLDataListElement* dataList = element().dataList();
</span><span class="cx"> if (!dataList)
</span><span class="cx"> return;
</span><del>- RefPtr<HTMLCollection> options = dataList->options();
</del><ins>+ Ref<HTMLCollection> options = dataList->options();
</ins><span class="cx"> m_tickMarkValues.reserveCapacity(options->length());
</span><span class="cx"> for (unsigned i = 0; i < options->length(); ++i) {
</span><span class="cx"> Node* node = options->item(i);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -1030,7 +1030,7 @@
</span><span class="cx"> tickRegionSideMargin = trackBounds.y() + (thumbSize.width() - tickSize.width() * zoomFactor) / 2.0;
</span><span class="cx"> tickRegionWidth = trackBounds.height() - thumbSize.width();
</span><span class="cx"> }
</span><del>- RefPtr<HTMLCollection> options = dataList->options();
</del><ins>+ Ref<HTMLCollection> options = dataList->options();
</ins><span class="cx"> GraphicsContextStateSaver stateSaver(*paintInfo.context);
</span><span class="cx"> paintInfo.context->setFillColor(o.style().visitedDependentColor(CSSPropertyColor), ColorSpaceDeviceRGB);
</span><span class="cx"> for (unsigned i = 0; Node* node = options->item(i); i++) {
</span></span></pre></div>
<a id="trunkSourceWebKitwinDOMHTMLClassescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (179769 => 179770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2015-02-07 00:45:50 UTC (rev 179769)
+++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2015-02-07 01:08:52 UTC (rev 179770)
</span><span class="lines">@@ -703,9 +703,6 @@
</span><span class="cx"> ASSERT(m_element);
</span><span class="cx"> HTMLSelectElement& selectElement = downcast<HTMLSelectElement>(*m_element);
</span><span class="cx">
</span><del>- if (!selectElement.options())
- return E_FAIL;
-
</del><span class="cx"> *result = nullptr;
</span><span class="cx"> RefPtr<HTMLOptionsCollection> options = selectElement.options();
</span><span class="cx"> *result = DOMHTMLOptionsCollection::createInstance(options.get());
</span></span></pre>
</div>
</div>
</body>
</html>