<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179729] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179729">179729</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-05 17:14:40 -0800 (Thu, 05 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
Reviewed by Andreas Kling.
Improved the way list of commits are shown per kling's request.
* public/v2/app.js:
(App.PaneController._updateDetails): Always show the old value even when a single point is selected.
* public/v2/chart-pane.css: Updated the style for the commits viewer.
* public/v2/commits-viewer.js:
(App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
(App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
* public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
moved the commits viewers out of the details tables so that they don't interleave revision data.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2appjs">trunk/Websites/perf.webkit.org/public/v2/app.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2chartpanecss">trunk/Websites/perf.webkit.org/public/v2/chart-pane.css</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2commitsviewerjs">trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2indexhtml">trunk/Websites/perf.webkit.org/public/v2/index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (179728 => 179729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-06 01:14:40 UTC (rev 179729)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Move commits viewer to the end of details view
+ https://bugs.webkit.org/show_bug.cgi?id=141315
+
+ Reviewed by Andreas Kling.
+
+ Improved the way list of commits are shown per kling's request.
+
+ * public/v2/app.js:
+ (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
+
+ * public/v2/chart-pane.css: Updated the style for the commits viewer.
+
+ * public/v2/commits-viewer.js:
+ (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
+ (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
+
+ * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
+ moved the commits viewers out of the details tables so that they don't interleave revision data.
+
+2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> New perf dashboard should compare results to baseline and target
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=141286
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2appjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (179728 => 179729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-02-06 01:14:40 UTC (rev 179729)
</span><span class="lines">@@ -766,7 +766,7 @@
</span><span class="cx"> this.set('details', Ember.Object.create({
</span><span class="cx"> status: this._computeStatus(currentPoint),
</span><span class="cx"> currentValue: chartData.formatter(currentMeasurement.mean()),
</span><del>- oldValue: oldMeasurement && selectedPoints ? chartData.formatter(oldMeasurement.mean()) : null,
</del><ins>+ oldValue: oldMeasurement ? chartData.formatter(oldMeasurement.mean()) : null,
</ins><span class="cx"> buildNumber: buildNumber,
</span><span class="cx"> buildURL: buildURL,
</span><span class="cx"> buildTime: currentMeasurement.formattedBuildTime(),
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2chartpanecss"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (179728 => 179729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-02-06 01:14:40 UTC (rev 179729)
</span><span class="lines">@@ -175,7 +175,7 @@
</span><span class="cx"> overflow: scroll;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.analysis-chart-pane .details table {
</del><ins>+.analysis-chart-pane table {
</ins><span class="cx"> margin: 0.5rem;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -192,7 +192,8 @@
</span><span class="cx"> overflow: scroll;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.chart-pane .details-table {
</del><ins>+.chart-pane .details-table,
+.chart-pane .commits-viewer {
</ins><span class="cx"> font-size: 0.8rem;
</span><span class="cx"> width: 100%;
</span><span class="cx"> table-layout: fixed;
</span><span class="lines">@@ -203,28 +204,17 @@
</span><span class="cx"> padding-right: 1px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.chart-pane .details-table td table {
- border-collapse: collapse;
-}
-
-.chart-pane .details-table td table td {
- word-break: break-word;
- border-top: solid 1px #ccc;
- border-bottom: solid 1px #ccc;
- padding: 0.2rem;
-}
-
-.chart-pane .details-table td table td a {
- text-decoration: none;
-}
-
</del><span class="cx"> .chart-pane .details-table th {
</span><del>- width: 7rem;
</del><ins>+ width: 30%;
</ins><span class="cx"> text-align: right;
</span><span class="cx"> font-weight: normal;
</span><span class="cx"> padding: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.chart-pane .details-table td {
+ width: 70%;
+}
+
</ins><span class="cx"> .chart-pane .details-table .bugs th {
</span><span class="cx"> font-weight: bold;
</span><span class="cx"> }
</span><span class="lines">@@ -241,6 +231,52 @@
</span><span class="cx"> font-size: 1rem;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.chart-pane .commits-viewer caption {
+ border-top: solid 1px #ccc;
+ font-weight: normal;
+ text-align: left;
+ padding: 0.2rem;
+ padding-left: 0.5rem;
+ cursor: pointer;
+}
+
+.chart-pane .commits-viewer caption:before {
+ display: inline-block;
+ width: 0.8rem;
+ content: "\25BE"; /* Down arrow */
+}
+
+.chart-pane .commits-viewer.hidden caption:before {
+ display: inline-block;
+ width: 0.8rem;
+ content: "\25B8"; /* Right arrow */
+}
+
+.chart-pane .commits {
+ border-bottom: solid 1px #ccc;
+ margin-bottom: 0.2rem;
+}
+
+.chart-pane .commits-viewer {
+ border-collapse: collapse;
+}
+
+.chart-pane .commits-viewer td,
+.chart-pane .commits-viewer th {
+ word-break: break-word;
+ border-top: solid 1px #ccc;
+ padding: 0.2rem;
+}
+
+.chart-pane .commits-viewer th {
+ width: 20%;
+ font-weight: normal;
+}
+
+.chart-pane .commits-viewer td {
+ width: 60%;
+}
+
</ins><span class="cx"> .chart-pane .chart {
</span><span class="cx"> height: 100%;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2commitsviewerjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js (179728 => 179729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/commits-viewer.js 2015-02-06 01:14:40 UTC (rev 179729)
</span><span class="lines">@@ -2,6 +2,7 @@
</span><span class="cx"> repository: null,
</span><span class="cx"> revisionInfo: null,
</span><span class="cx"> commits: null,
</span><ins>+ visible: true,
</ins><span class="cx"> commitsChanged: function ()
</span><span class="cx"> {
</span><span class="cx"> var revisionInfo = this.get('revisionInfo');
</span><span class="lines">@@ -30,4 +31,10 @@
</span><span class="cx"> self.set('commits', []);
</span><span class="cx"> })
</span><span class="cx"> }.observes('repository').observes('revisionInfo').on('init'),
</span><ins>+ actions: {
+ toggleVisibility: function ()
+ {
+ this.toggleProperty('visible');
+ }
+ }
</ins><span class="cx"> });
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2indexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (179728 => 179729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:12:00 UTC (rev 179728)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2015-02-06 01:14:40 UTC (rev 179729)
</span><span class="lines">@@ -269,6 +269,7 @@
</span><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><span class="cx"> </tbody>
</span><ins>+ <tbody>
</ins><span class="cx"> {{#if details.buildNumber}}
</span><span class="cx"> <tr>
</span><span class="cx"> <th>Build</th>
</span><span class="lines">@@ -293,31 +294,40 @@
</span><span class="cx"> {{/if}}
</span><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><del>- <tr>
- <td colspan="2">{{commits-viewer repository=repository revisionInfo=this}}</td>
- </tr>
</del><span class="cx"> {{/each}}
</span><ins>+ </tbody>
</ins><span class="cx"> </table>
</span><ins>+ <div class="commits">
+ {{#each details.revisions}}
+ {{commits-viewer repository=repository revisionInfo=this caption=name}}
+ {{/each}}
+ </div>
</ins><span class="cx"> </div>
</span><span class="cx"> </script>
</span><span class="cx">
</span><span class="cx"> <script type="text/x-handlebars" data-template-name="components/commits-viewer">
</span><span class="cx"> {{#if commits}}
</span><del>- <table>
- <tbody>
- {{#each commits}}
- <tr>
- <td>
- {{#if url}}
- <a {{bind-attr href=url}} target="_blank">{{author}}</a>
- {{else}}
- {{author}}
- {{/if}}
- </td>
- <td>{{message}}</td>
- </tr>
- {{/each}}
- </tbody>
</del><ins>+ <table {{bind-attr class=":commits-viewer visible::hidden"}}>
+ {{#if caption}}
+ <caption {{action toggleVisibility}}>{{caption}} commits</caption>
+ {{/if}}
+ {{#if visible}}
+ <tbody>
+ {{#each commits}}
+ <tr>
+ <th>
+ {{#if url}}
+ <a {{bind-attr href=url}} target="_blank">{{revision}}</a>
+ {{else}}
+ {{revision}}
+ {{/if}}
+ </th>
+ <th>{{author}}</th>
+ <td>{{message}}</td>
+ </tr>
+ {{/each}}
+ </tbody>
+ {{/if}}
</ins><span class="cx"> </table>
</span><span class="cx"> {{/if}}
</span><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>