<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179650] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179650">179650</a></dd>
<dt>Author</dt> <dd>dburkart@apple.com</dd>
<dt>Date</dt> <dd>2015-02-04 16:37:36 -0800 (Wed, 04 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Botwatcher's Dashboard is cramped
https://bugs.webkit.org/show_bug.cgi?id=140273
Reviewed by Alexey Proskuryakov.
Add a heading key which will allow for arbitrary headings in builder queues.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotLeaksQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotPerformanceQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTestResultsjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTesterQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx"> var status = new StatusLineView(message, StatusLineView.Status.Good, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build", null, url);
</span><span class="cx"> this.element.appendChild(status.element);
</span><span class="cx"> } else {
</span><del>- var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build");
</del><ins>+ var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, firstRecentUnsuccessfulIteration ? "last successful build" : "latest build");
</ins><span class="cx"> this.element.appendChild(status.element);
</span><span class="cx">
</span><span class="cx"> if (firstRecentUnsuccessfulIteration) {
</span><span class="lines">@@ -113,27 +113,13 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function appendBuildArchitecture(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = label;
- releaseLabel.href = queue.overviewURL;
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
</del><ins>+ this.appendBuildStyle.call(this, this.universalReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (Universal)" : "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.sixtyFourBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (64-bit)" : "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.thirtyTwoBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (32-bit)" : "Release", appendBuilderQueueStatus);
</ins><span class="cx">
</span><del>- appendBuilderQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuildArchitecture.call(this, this.universalReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (Universal)" : "Release");
- appendBuildArchitecture.call(this, this.sixtyFourBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (64-bit)" : "Release");
- appendBuildArchitecture.call(this, this.thirtyTwoBitReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (32-bit)" : "Release");
-
- appendBuildArchitecture.call(this, this.universalDebugQueues, this.hasMultipleDebugBuilds ? "Debug (Universal)" : "Debug");
- appendBuildArchitecture.call(this, this.sixtyFourBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (64-bit)" : "Debug");
- appendBuildArchitecture.call(this, this.thirtyTwoBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (32-bit)" : "Debug");
</del><ins>+ this.appendBuildStyle.call(this, this.universalDebugQueues, this.hasMultipleDebugBuilds ? "Debug (Universal)" : "Debug", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.sixtyFourBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (64-bit)" : "Debug", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.thirtyTwoBitDebugQueues, this.hasMultipleDebugBuilds ? "Debug (32-bit)" : "Debug", appendBuilderQueueStatus);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _presentPopoverFailureLogs: function(element, popover, iteration)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -227,6 +227,7 @@
</span><span class="cx"> testResults.uniqueLeakCount = testStep.results[1].reduce(resultSummarizer.bind(null, "unique leak"), undefined);
</span><span class="cx"> testResults.newPassesCount = testStep.results[1].reduce(resultSummarizer.bind(null, "new pass"), undefined);
</span><span class="cx"> testResults.missingCount = testStep.results[1].reduce(resultSummarizer.bind(null, "missing"), undefined);
</span><ins>+ testResults.crashCount = testStep.results[1].reduce(resultSummarizer.bind(null, "crash"), undefined);
</ins><span class="cx">
</span><span class="cx"> if (!testResults.failureCount && !testResults.flakyCount && !testResults.totalLeakCount && !testResults.uniqueLeakCount && !testResults.newPassesCount && !testResults.missingCount) {
</span><span class="cx"> // This step exited with a non-zero exit status, but we didn't find any output about the number of failed tests.
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotLeaksQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -84,21 +84,7 @@
</span><span class="cx"> new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLeaksQueue.bind(this), iteration);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = queue.LeaksTestName ? queue.LeaksTestName : label;
- releaseLabel.href = queue.overviewURL;
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendLeaksQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, "Leaks");
</del><ins>+ this.appendBuildStyle.call(this, this.releaseQueues, "Leaks", appendLeaksQueueStatus);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> addLinkToRow: function(rowElement, className, text, url)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotPerformanceQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -82,21 +82,7 @@
</span><span class="cx"> new PopoverTracker(status.statusBubbleElement, this._presentPopoverForPerformanceQueue.bind(this), queue);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = queue.performanceTestName ? queue.performanceTestName : label;
- releaseLabel.href = queue.overviewURL;
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendPerformanceQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, 'Release');
</del><ins>+ this.appendBuildStyle.call(this, this.releaseQueues, 'Release', appendPerformanceQueueStatus);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> addLinkToRow: function(rowElement, className, text, url)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -42,7 +42,8 @@
</span><span class="cx"> this.leaks = info.leaks || false;
</span><span class="cx"> this.architecture = info.architecture || null;
</span><span class="cx"> this.testCategory = info.testCategory || null;
</span><del>- this.performanceTestName = info.performanceTestName || null;
</del><ins>+ this.heading = info.heading || null;
+ this.crashesOnly = info.crashesOnly || false;
</ins><span class="cx">
</span><span class="cx"> this.iterations = [];
</span><span class="cx"> this._knownIterations = {};
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -286,6 +286,20 @@
</span><span class="cx"> return fragment;
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ appendBuildStyle: function(queues, defaultLabel, appendFunction)
+ {
+ queues.forEach(function(queue) {
+ var releaseLabel = document.createElement("a");
+ releaseLabel.classList.add("queueLabel");
+ releaseLabel.textContent = queue.heading ? queue.heading : defaultLabel;
+ releaseLabel.href = queue.overviewURL;
+ releaseLabel.target = "_blank";
+ this.element.appendChild(releaseLabel);
+
+ appendFunction.call(this, queue);
+ }.bind(this));
+ },
+
</ins><span class="cx"> _updateQueues: function()
</span><span class="cx"> {
</span><span class="cx"> this.releaseQueues.forEach(function(queue) { queue.update(); });
</span><span class="lines">@@ -316,4 +330,5 @@
</span><span class="cx"> {
</span><span class="cx"> this.updateSoon();
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTestResultsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> this.uniqueLeakCount = info.uniqueLeakCount || 0;
</span><span class="cx"> this.newPassesCount = info.newPassesCount || 0;
</span><span class="cx"> this.missingCount = info.missingCount || 0;
</span><ins>+ this.crashCount = info.crashCount || 0;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> BaseObject.addConstructorFunctions(BuildbotTestResults);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotTesterQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -79,6 +79,13 @@
</span><span class="cx"> } else if (!iteration.productive) {
</span><span class="cx"> var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
</span><span class="cx"> var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
</span><ins>+ } else if (queue.crashesOnly && !iteration.crashCount) {
+ var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Good, "no crashes found", undefined, url);
+ } else if (queue.crashesOnly && iteration.crashCount) {
+ var url = iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration);
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "crash found" : "crashes found", undefined, url);
+ new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
</ins><span class="cx"> } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.errorOccurred && !bindingTestResults.errorOccurred) {
</span><span class="cx"> // Something wrong happened, but it was not a test failure.
</span><span class="cx"> var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
</span><span class="lines">@@ -122,22 +129,8 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function appendBuild(queues, label)
- {
- queues.forEach(function(queue) {
- var releaseLabel = document.createElement("a");
- releaseLabel.classList.add("queueLabel");
- releaseLabel.textContent = label;
- releaseLabel.href = queue.overviewURL;
- releaseLabel.target = "_blank";
- this.element.appendChild(releaseLabel);
-
- appendBuilderQueueStatus.call(this, queue);
- }.bind(this));
- }
-
- appendBuild.call(this, this.releaseQueues, "Release");
- appendBuild.call(this, this.debugQueues, "Debug");
</del><ins>+ this.appendBuildStyle.call(this, this.releaseQueues, "Release", appendBuilderQueueStatus);
+ this.appendBuildStyle.call(this, this.debugQueues, "Debug", appendBuilderQueueStatus);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _popoverContentForLayoutTestRegressions: function(iteration)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (179649 => 179650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2015-02-05 00:36:37 UTC (rev 179649)
+++ trunk/Tools/ChangeLog 2015-02-05 00:37:36 UTC (rev 179650)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2015-02-04 Dana Burkart <dburkart@apple.com>
+
+ Botwatcher's Dashboard is cramped
+ https://bugs.webkit.org/show_bug.cgi?id=140273
+
+ Reviewed by Alexey Proskuryakov.
+
+ Add a heading key which will allow for arbitrary headings in builder queues.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotBuilderQueueView.prototype.update):
+ (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype._parseData):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
+ (BuildbotLeaksQueueView.prototype.update):
+ (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
+ (BuildbotPerformanceQueueView.prototype.update):
+ (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype._unauthorizedAccess):
+ (BuildbotQueueView.prototype._appendBuild):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+ (BuildbotTestResults):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotTesterQueueView.prototype.update):
+ (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
+
</ins><span class="cx"> 2015-02-04 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> WKTR should not use -mainScreen to pick a color profile
</span></span></pre>
</div>
</div>
</body>
</html>