<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179613] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179613">179613</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-04 10:16:39 -0800 (Wed, 04 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Perf dashboard doesn’t show the right unit for Safari UI tests
https://bugs.webkit.org/show_bug.cgi?id=141238
Reviewed by Darin Adler.
Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
between metrics and their units.
* public/js/helper-classes.js:
(PerfTestRuns): Use the suffix of the metric name to compute the unit.
* public/v2/manifest.js:
(App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
(App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicjshelperclassesjs">trunk/Websites/perf.webkit.org/public/js/helper-classes.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2interactivechartjs">trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv2manifestjs">trunk/Websites/perf.webkit.org/public/v2/manifest.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (179612 => 179613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2015-02-04 18:16:06 UTC (rev 179612)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-02-04 18:16:39 UTC (rev 179613)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Perf dashboard doesn’t show the right unit for Safari UI tests
+ https://bugs.webkit.org/show_bug.cgi?id=141238
+
+ Reviewed by Darin Adler.
+
+ Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
+ get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
+ between metrics and their units.
+
+ * public/js/helper-classes.js:
+ (PerfTestRuns): Use the suffix of the metric name to compute the unit.
+ * public/v2/manifest.js:
+ (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
+ * public/v2/interactive-chart.js:
+ (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
+ (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
+
+2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Interactive chart component provides two duplicate API for highlighting points
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=141234
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicjshelperclassesjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (179612 => 179613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2015-02-04 18:16:06 UTC (rev 179612)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2015-02-04 18:16:39 UTC (rev 179613)
</span><span class="lines">@@ -151,16 +151,14 @@
</span><span class="cx"> var cachedUnit = null;
</span><span class="cx"> var cachedScalingFactor = null;
</span><span class="cx"> var baselines = {};
</span><ins>+ var suffix = metric.name.match('([A-z][a-z]+|FrameRate)$')[0];
</ins><span class="cx"> var unit = {'Combined': '', // Assume smaller is better for now.
</span><span class="cx"> 'FrameRate': 'fps',
</span><span class="cx"> 'Runs': '/s',
</span><span class="cx"> 'Time': 'ms',
</span><span class="cx"> 'Malloc': 'B',
</span><del>- 'JSHeap': 'B',
- 'Allocations': 'B',
- 'EndAllocations': 'B',
- 'MaxAllocations': 'B',
- 'MeanAllocations': 'B'}[metric.name];
</del><ins>+ 'Heap': 'B',
+ 'Allocations': 'B'}[suffix];
</ins><span class="cx">
</span><span class="cx"> // We can't do this in PerfTestResult because all results for each metric need to share the same unit and the same scaling factor.
</span><span class="cx"> function computeScalingFactorIfNeeded() {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2interactivechartjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js (179612 => 179613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js 2015-02-04 18:16:06 UTC (rev 179612)
+++ trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js 2015-02-04 18:16:39 UTC (rev 179613)
</span><span class="lines">@@ -66,7 +66,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this.get('showYAxis')) {
</span><del>- this._yAxis = d3.svg.axis().scale(this._y).orient("left").ticks(6).tickFormat(d3.format("s"));
</del><ins>+ this._yAxis = d3.svg.axis().scale(this._y).orient("left").ticks(6).tickFormat(
+ chartData.useSI ? d3.format("s") : d3.format(".3g"));
</ins><span class="cx"> this._yAxisLabels = svg.append("g")
</span><span class="cx"> .attr("class", "y axis");
</span><span class="cx"> }
</span><span class="lines">@@ -295,12 +296,11 @@
</span><span class="cx"> this._yAxisLabels.call(this._yAxis);
</span><span class="cx"> if (this._yAxisUnitContainer)
</span><span class="cx"> this._yAxisUnitContainer.remove();
</span><ins>+ var x = - 3 * this._rem;
+ var y = this._contentHeight / 2;
</ins><span class="cx"> this._yAxisUnitContainer = this._yAxisLabels.append("text")
</span><del>- .attr("x", 0.5 * this._rem)
- .attr("y", 0.2 * this._rem)
- .attr("dy", 0.8 * this._rem)
- .style("text-anchor", "start")
- .style("z-index", "100")
</del><ins>+ .attr("transform", "rotate(90 0 0) translate(" + y + ", " + (-x) + ")")
+ .style("text-anchor", "middle")
</ins><span class="cx"> .text(this._yAxisUnit);
</span><span class="cx"> },
</span><span class="cx"> _updateHighlightPositions: function () {
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv2manifestjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v2/manifest.js (179612 => 179613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-02-04 18:16:06 UTC (rev 179612)
+++ trunk/Websites/perf.webkit.org/public/v2/manifest.js 2015-02-04 18:16:39 UTC (rev 179613)
</span><span class="lines">@@ -272,18 +272,19 @@
</span><span class="cx"> var platform = App.Manifest.platform(platformId);
</span><span class="cx"> var metric = App.Manifest.metric(metricId);
</span><span class="cx">
</span><del>- // FIXME: Include this information in JSON and process it in RunsData.fetchRuns
- var unit = {'Combined': '', // Assume smaller is better for now.
</del><ins>+ var suffix = metric.get('name').match('([A-z][a-z]+|FrameRate)$')[0];
+ var unit = {
</ins><span class="cx"> 'FrameRate': 'fps',
</span><del>- 'Runs': 'runs/s',
</del><ins>+ 'Runs': '/s',
</ins><span class="cx"> 'Time': 'ms',
</span><span class="cx"> 'Malloc': 'bytes',
</span><del>- 'JSHeap': 'bytes',
- 'Allocations': 'bytes',
- 'EndAllocations': 'bytes',
- 'MaxAllocations': 'bytes',
- 'MeanAllocations': 'bytes'}[metric.get('name')];
</del><ins>+ 'Heap': 'bytes',
+ 'Allocations': 'bytes'
+ }[suffix];
+
+ // FIXME: Include this information in JSON and process it in RunsData.fetchRuns
</ins><span class="cx"> runs.unit = unit;
</span><ins>+ runs.useSI = unit == 'bytes';
</ins><span class="cx">
</span><span class="cx"> return {platform: platform, metric: metric, runs: runs};
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>