<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179501] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179501">179501</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2015-02-02 14:44:51 -0800 (Mon, 02 Feb 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: CSS Autocompletion: Autodetect many color supporting properties
https://bugs.webkit.org/show_bug.cgi?id=141166
Reviewed by Timothy Hatcher.
* UserInterface/Base/Utilities.js:
Add String.prototype.endsWith. Group String extensions together.
* UserInterface/Models/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
If a property name ends in "color", provide CSS color completions.
(WebInspector.CSSKeywordCompletions.isColorAwareProperty): Deleted.
This was unused and disagrees slightly with the implementation above.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseUtilitiesjs">trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsCSSKeywordCompletionsjs">trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (179500 => 179501)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2015-02-02 22:27:18 UTC (rev 179500)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-02-02 22:44:51 UTC (rev 179501)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2015-02-02 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: CSS Autocompletion: Autodetect many color supporting properties
+ https://bugs.webkit.org/show_bug.cgi?id=141166
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Utilities.js:
+ Add String.prototype.endsWith. Group String extensions together.
+
+ * UserInterface/Models/CSSKeywordCompletions.js:
+ (WebInspector.CSSKeywordCompletions.forProperty):
+ If a property name ends in "color", provide CSS color completions.
+
+ (WebInspector.CSSKeywordCompletions.isColorAwareProperty): Deleted.
+ This was unused and disagrees slightly with the implementation above.
+
+2015-02-02 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Support console.table
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=141058
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseUtilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (179500 => 179501)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2015-02-02 22:27:18 UTC (rev 179500)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2015-02-02 22:44:51 UTC (rev 179501)
</span><span class="lines">@@ -393,14 +393,6 @@
</span><span class="cx"> value: Element.prototype.createChild
</span><span class="cx"> });
</span><span class="cx">
</span><del>-Object.defineProperty(String.prototype, "contains",
-{
- value: function(value)
- {
- return this.indexOf(value) !== -1;
- }
-});
-
</del><span class="cx"> Object.defineProperty(Array.prototype, "contains",
</span><span class="cx"> {
</span><span class="cx"> value: function(value)
</span><span class="lines">@@ -444,6 +436,14 @@
</span><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+Object.defineProperty(String.prototype, "contains",
+{
+ value: function(value)
+ {
+ return this.indexOf(value) !== -1;
+ }
+});
+
</ins><span class="cx"> Object.defineProperty(String.prototype, "trimMiddle",
</span><span class="cx"> {
</span><span class="cx"> value: function(maxLength)
</span><span class="lines">@@ -592,6 +592,17 @@
</span><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+Object.defineProperty(String.prototype, "endsWith",
+{
+ value: function(string)
+ {
+ var position = this.length - string.length;
+ if (position < 0)
+ return false;
+ return this.indexOf(string, position) === position;
+ }
+});
+
</ins><span class="cx"> Object.defineProperty(String.prototype, "hash",
</span><span class="cx"> {
</span><span class="cx"> get: function()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsCSSKeywordCompletionsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (179500 => 179501)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2015-02-02 22:27:18 UTC (rev 179500)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2015-02-02 22:44:51 UTC (rev 179501)
</span><span class="lines">@@ -45,6 +45,8 @@
</span><span class="cx"> acceptedKeywords = acceptedKeywords.concat(WebInspector.CSSKeywordCompletions._colors);
</span><span class="cx"> else if (isNotPrefixed && ("-webkit-" + propertyName) in WebInspector.CSSKeywordCompletions._colorAwareProperties)
</span><span class="cx"> acceptedKeywords = acceptedKeywords.concat(WebInspector.CSSKeywordCompletions._colors);
</span><ins>+ else if (propertyName.endsWith("color"))
+ acceptedKeywords = acceptedKeywords.concat(WebInspector.CSSKeywordCompletions._colors);
</ins><span class="cx">
</span><span class="cx"> // Only suggest "inherit" on inheritable properties even though it is valid on all properties.
</span><span class="cx"> if (propertyName in WebInspector.CSSKeywordCompletions.InheritedProperties)
</span><span class="lines">@@ -60,11 +62,6 @@
</span><span class="cx"> return new WebInspector.CSSCompletions(acceptedKeywords, true);
</span><span class="cx"> };
</span><span class="cx">
</span><del>-WebInspector.CSSKeywordCompletions.isColorAwareProperty = function(propertyName)
-{
- return WebInspector.CSSKeywordCompletions._colorAwareProperties[propertyName] === true;
-};
-
</del><span class="cx"> WebInspector.CSSKeywordCompletions.addCustomCompletions = function(properties)
</span><span class="cx"> {
</span><span class="cx"> // COMPATIBILITY (iOS 6): This used to be an array of strings. They won't have custom values.
</span></span></pre>
</div>
</div>
</body>
</html>