<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179406] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179406">179406</a></dd>
<dt>Author</dt> <dd>mmirman@apple.com</dd>
<dt>Date</dt> <dd>2015-01-30 11:09:14 -0800 (Fri, 30 Jan 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Source/WebCore:
Added ClientRect as an interface that requires attributes
on instance for compatibility.
https://bugs.webkit.org/show_bug.cgi?id=141063
&lt;rdar://problem/18437653&gt;

Reviewed by Oliver Hunt.

Added a new test to LayoutTests/js/resources/JSON-stringify.js

* bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility):

LayoutTests:
Added a test for JSON.stringify on ClientRect.
https://bugs.webkit.org/show_bug.cgi?id=141063
&lt;rdar://problem/18437653&gt;

Reviewed by Oliver Hunt.

* js/resources/JSON-stringify.js:
(createTests.var):
(createTests.result):
* js/resources/JSON-stringify-expected.txt:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsdomJSONstringifyexpectedtxt">trunk/LayoutTests/js/dom/JSON-stringify-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsresourcesJSONstringifyjs">trunk/LayoutTests/js/resources/JSON-stringify.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (179405 => 179406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2015-01-30 18:26:36 UTC (rev 179405)
+++ trunk/LayoutTests/ChangeLog        2015-01-30 19:09:14 UTC (rev 179406)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2015-01-30  Matthew Mirman  &lt;mmirman@apple.com&gt;
+
+        Added a test for JSON.stringify on ClientRect.
+        https://bugs.webkit.org/show_bug.cgi?id=141063
+        &lt;rdar://problem/18437653&gt;
+
+        Reviewed by Oliver Hunt.
+
+        * js/resources/JSON-stringify.js:
+        (createTests.var):
+        (createTests.result):
+        * js/resources/JSON-stringify-expected.txt:
+
</ins><span class="cx"> 2015-01-30  Brent Fulgham  &lt;bfulgham@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [Win] Switch to Apache on Windows
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomJSONstringifyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/JSON-stringify-expected.txt (179405 => 179406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/JSON-stringify-expected.txt        2015-01-30 18:26:36 UTC (rev 179405)
+++ trunk/LayoutTests/js/dom/JSON-stringify-expected.txt        2015-01-30 19:09:14 UTC (rev 179406)
</span><span class="lines">@@ -353,14 +353,26 @@
</span><span class="cx">     }
</span><span class="cx"> PASS tests[i](nativeJSON) is tests[i](JSON)
</span><span class="cx"> function (jsonObject) {
</span><ins>+            return jsonObject.stringify(clientRect);
+    }
+PASS tests[i](nativeJSON) is tests[i].expected
+function (jsonObject) {
</ins><span class="cx">         return jsonObject.stringify(objectWithSideEffectGetter);
</span><span class="cx">     }
</span><del>-FAIL tests[i](nativeJSON) should be {&quot;foo&quot;:1}. Was {}.
</del><ins>+PASS tests[i](nativeJSON) is tests[i].expected
</ins><span class="cx"> function (jsonObject) {
</span><ins>+        return jsonObject.stringify(objectWithSideEffectGetter);
+    }
+PASS tests[i](nativeJSON) is tests[i](JSON)
+function (jsonObject) {
</ins><span class="cx">         return jsonObject.stringify(objectWithSideEffectGetterAndProto);
</span><span class="cx">     }
</span><del>-FAIL tests[i](nativeJSON) should be {&quot;foo&quot;:1}. Was {}.
</del><ins>+PASS tests[i](nativeJSON) is tests[i].expected
</ins><span class="cx"> function (jsonObject) {
</span><ins>+        return jsonObject.stringify(objectWithSideEffectGetterAndProto);
+    }
+PASS tests[i](nativeJSON) is tests[i](JSON)
+function (jsonObject) {
</ins><span class="cx">         return jsonObject.stringify(arrayWithSideEffectGetter);
</span><span class="cx">     }
</span><span class="cx"> PASS tests[i](nativeJSON) is tests[i](JSON)
</span></span></pre></div>
<a id="trunkLayoutTestsjsresourcesJSONstringifyjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/resources/JSON-stringify.js (179405 => 179406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/resources/JSON-stringify.js        2015-01-30 18:26:36 UTC (rev 179405)
+++ trunk/LayoutTests/js/resources/JSON-stringify.js        2015-01-30 19:09:14 UTC (rev 179406)
</span><span class="lines">@@ -57,6 +57,7 @@
</span><span class="cx">     result.push(function(jsonObject){
</span><span class="cx">         return jsonObject.stringify(new Boolean(true));
</span><span class="cx">     });
</span><ins>+
</ins><span class="cx">     result.push(function(jsonObject){
</span><span class="cx">         var value = new Number(1);
</span><span class="cx">         value.valueOf = function() { return 2; }
</span><span class="lines">@@ -306,13 +307,26 @@
</span><span class="cx">     result.push(function(jsonObject){
</span><span class="cx">         return jsonObject.stringify(complexObjectWithProto, null, 4);
</span><span class="cx">     });
</span><ins>+    var clientRect = document.body.getBoundingClientRect();
</ins><span class="cx">     result.push(function(jsonObject){
</span><ins>+            return jsonObject.stringify(clientRect);
+    });
+    result[result.length - 1].expected = JSON.stringify({top : clientRect.top, right : clientRect.right, bottom: clientRect.bottom, left : clientRect.left, width : clientRect.width, height : clientRect.height });
+    result.push(function(jsonObject){
</ins><span class="cx">         return jsonObject.stringify(objectWithSideEffectGetter);
</span><span class="cx">     });
</span><ins>+    result[result.length - 1].expected = JSON.stringify({});
</ins><span class="cx">     result.push(function(jsonObject){
</span><ins>+        return jsonObject.stringify(objectWithSideEffectGetter);
+    });
+    result.push(function(jsonObject){
</ins><span class="cx">         return jsonObject.stringify(objectWithSideEffectGetterAndProto);
</span><span class="cx">     });
</span><ins>+    result[result.length - 1].expected = JSON.stringify({});
</ins><span class="cx">     result.push(function(jsonObject){
</span><ins>+        return jsonObject.stringify(objectWithSideEffectGetterAndProto);
+    });
+    result.push(function(jsonObject){
</ins><span class="cx">         return jsonObject.stringify(arrayWithSideEffectGetter);
</span><span class="cx">     });
</span><span class="cx">     result.push(function(jsonObject){
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179405 => 179406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-01-30 18:26:36 UTC (rev 179405)
+++ trunk/Source/WebCore/ChangeLog        2015-01-30 19:09:14 UTC (rev 179406)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-01-30  Matthew Mirman  &lt;mmirman@apple.com&gt;
+
+        Added ClientRect as an interface that requires attributes 
+        on instance for compatibility.
+        https://bugs.webkit.org/show_bug.cgi?id=141063
+        &lt;rdar://problem/18437653&gt;
+
+        Reviewed by Oliver Hunt.
+
+        Added a new test to LayoutTests/js/resources/JSON-stringify.js
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (InterfaceRequiresAttributesOnInstanceForCompatibility):
+
</ins><span class="cx"> 2015-01-30  Chris Dumez  &lt;cdumez@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Optimize MemoryCache::getSessionMap() a bit
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (179405 => 179406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2015-01-30 18:26:36 UTC (rev 179405)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2015-01-30 19:09:14 UTC (rev 179406)
</span><span class="lines">@@ -555,6 +555,7 @@
</span><span class="cx">     # Needed for compatibility with existing content
</span><span class="cx">     return 1 if $interfaceName =~ &quot;Touch&quot;;
</span><span class="cx">     return 1 if $interfaceName =~ &quot;Navigator&quot;;
</span><ins>+    return 1 if $interfaceName =~ &quot;ClientRect&quot;;
</ins><span class="cx">     # FIXME: Once https://bugs.webkit.org/show_bug.cgi?id=134364 is fixed, we can remove this.
</span><span class="cx">     return 1 if $interfaceName =~ &quot;XMLHttpRequest&quot;;
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>