<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179377] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179377">179377</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2015-01-29 16:02:41 -0800 (Thu, 29 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (OS X 10.10.2): media/track/track-in-band-style.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=140974
Reviewed by Brent Fulgham.
* media/track/track-in-band-style-expected.txt: Updated.
* media/track/track-in-band-style.html: Introduce a brief pause between receiving the 'seeked'
event and checking caption style to allow for media engine latency. Add additional logging
when the test fails to make future failure diagnosis easier.
* platform/mac/TestExpectations: Remove track-in-band-style.html.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsmediatracktrackinbandstyleexpectedtxt">trunk/LayoutTests/media/track/track-in-band-style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmediatracktrackinbandstylehtml">trunk/LayoutTests/media/track/track-in-band-style.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (179376 => 179377)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2015-01-30 00:02:02 UTC (rev 179376)
+++ trunk/LayoutTests/ChangeLog 2015-01-30 00:02:41 UTC (rev 179377)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-01-29 Eric Carlson <eric.carlson@apple.com>
+
+ REGRESSION (OS X 10.10.2): media/track/track-in-band-style.html frequently times out
+ https://bugs.webkit.org/show_bug.cgi?id=140974
+
+ Reviewed by Brent Fulgham.
+
+ * media/track/track-in-band-style-expected.txt: Updated.
+ * media/track/track-in-band-style.html: Introduce a brief pause between receiving the 'seeked'
+ event and checking caption style to allow for media engine latency. Add additional logging
+ when the test fails to make future failure diagnosis easier.
+
+ * platform/mac/TestExpectations: Remove track-in-band-style.html.
+
</ins><span class="cx"> 2015-01-29 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Implement ES6 class syntax without inheritance support
</span></span></pre></div>
<a id="trunkLayoutTestsmediatracktrackinbandstyleexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/track/track-in-band-style-expected.txt (179376 => 179377)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/track/track-in-band-style-expected.txt 2015-01-30 00:02:02 UTC (rev 179376)
+++ trunk/LayoutTests/media/track/track-in-band-style-expected.txt 2015-01-30 00:02:41 UTC (rev 179377)
</span><span class="lines">@@ -7,6 +7,8 @@
</span><span class="cx"> EXPECTED (video.textTracks.length == '1') OK
</span><span class="cx"> EXPECTED (inbandTrack1.language == 'en') OK
</span><span class="cx"> EXPECTED (inbandTrack1.kind == 'captions') OK
</span><ins>+RUN(inbandTrack1.mode = 'showing')
+EVENT(change)
</ins><span class="cx"> RUN(video.play())
</span><span class="cx"> EVENT(seeked)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsmediatracktrackinbandstylehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/track/track-in-band-style.html (179376 => 179377)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/track/track-in-band-style.html 2015-01-30 00:02:02 UTC (rev 179376)
+++ trunk/LayoutTests/media/track/track-in-band-style.html 2015-01-30 00:02:41 UTC (rev 179377)
</span><span class="lines">@@ -9,29 +9,44 @@
</span><span class="cx">
</span><span class="cx"> <script>
</span><span class="cx">
</span><del>- function seeked()
</del><ins>+ function testCues()
</ins><span class="cx"> {
</span><ins>+ cueDisplayElement = null;
+ cueNode = null;
+ try {
+ cueDisplayElement = textTrackDisplayElement(video, 'display', 0);
+ cueNode = textTrackDisplayElement(video, 'cue');
+ } catch (ex) {
+ consoleWrite('<br>Text track cue at time 0.3s not visible. Track cues are:');
+ for (var i = 0; i < inbandTrack1.cues.length; i++)
+ consoleWrite(" cue " + i + ": start time = " + inbandTrack1.cues[i].startTime.toFixed(2) + ", text = " + inbandTrack1.cues[i].text);
+ failTest("<br>");
+ return;
+ }
+
</ins><span class="cx"> consoleWrite("<br><i>** Test current cue colors<" + "/i>");
</span><del>-
- cueDisplayElement = textTrackDisplayElement(video, 'display', 0);
</del><span class="cx"> testExpected("getComputedStyle(cueDisplayElement).color", "rgb(255, 255, 255)");
</span><del>-
- cueNode = textTrackDisplayElement(video, 'cue');
</del><span class="cx"> testExpected("getComputedStyle(cueNode).backgroundColor", "rgb(0, 0, 0)");
</span><del>-
</del><ins>+
</ins><span class="cx"> endTest();
</span><span class="cx"> }
</span><del>-
</del><ins>+
+ function tracksChanged()
+ {
+ run("video.play()");
+ setTimeout(function() { video.pause(); video.currentTime = 0.3; }, 1000);
+ waitForEvent('seeked', function() { setTimeout(testCues, 200) });
+ }
+
</ins><span class="cx"> function canplaythrough()
</span><span class="cx"> {
</span><span class="cx"> consoleWrite("<br><i>** Check initial in-band track states<" + "/i>");
</span><ins>+ waitForEventOn(video.textTracks, 'change', tracksChanged);
</ins><span class="cx"> run("inbandTrack1 = video.textTracks[0]");
</span><span class="cx"> testExpected("video.textTracks.length", 1);
</span><span class="cx"> testExpected("inbandTrack1.language", "en");
</span><span class="cx"> testExpected("inbandTrack1.kind", "captions");
</span><del>- inbandTrack1.mode = 'showing';
- run("video.play()");
- setTimeout(function() { video.pause(); video.currentTime = 0.3; }, 1500);
</del><ins>+ run("inbandTrack1.mode = 'showing'");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function loaded()
</span><span class="lines">@@ -39,7 +54,6 @@
</span><span class="cx"> consoleWrite("Test that style to all cues is applied correctly.");
</span><span class="cx"> findMediaElement();
</span><span class="cx"> video.src = '../content/counting-captioned.mov';
</span><del>- waitForEvent('seeked', seeked);
</del><span class="cx"> waitForEvent('canplaythrough', canplaythrough);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (179376 => 179377)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2015-01-30 00:02:02 UTC (rev 179376)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-01-30 00:02:41 UTC (rev 179377)
</span><span class="lines">@@ -1054,7 +1054,6 @@
</span><span class="cx"> webkit.org/b/138798 [ MountainLion ] media/track/track-cues-sorted-before-dispatch.html [ Pass Failure Timeout ]
</span><span class="cx"> webkit.org/b/139789 media/media-controls-timeline-updates.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/139825 media/video-seek-past-end-paused.html [ Pass Timeout ]
</span><del>-webkit.org/b/140974 [ Debug Yosemite+ ] media/track/track-in-band-style.html [ Pass Timeout ]
</del><span class="cx"> ## --- End flaky media tests
</span><span class="cx">
</span><span class="cx"> # Skipped while Eric Carlson works on a fix.
</span></span></pre>
</div>
</div>
</body>
</html>