<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179228] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179228">179228</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2015-01-27 16:13:37 -0800 (Tue, 27 Jan 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Some NSAccessibility methods we use are deprecated on 10.10
https://bugs.webkit.org/show_bug.cgi?id=140966

Reviewed by Anders Carlsson.

* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper roleDescription]):
Silence the warnings for now.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacAccessibilityObjectMacmm">trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179227 => 179228)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-01-28 00:02:45 UTC (rev 179227)
+++ trunk/Source/WebCore/ChangeLog        2015-01-28 00:13:37 UTC (rev 179228)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2015-01-27  Alexey Proskuryakov  &lt;ap@apple.com&gt;
+
+        Some NSAccessibility methods we use are deprecated on 10.10
+        https://bugs.webkit.org/show_bug.cgi?id=140966
+
+        Reviewed by Anders Carlsson.
+
+        * accessibility/mac/AccessibilityObjectMac.mm:
+        (WebCore::AccessibilityObject::overrideAttachmentParent):
+        (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper role]):
+        (-[WebAccessibilityObjectWrapper roleDescription]):
+        Silence the warnings for now.
+
</ins><span class="cx"> 2015-01-27  Chris Dumez  &lt;cdumez@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Rename isExpandedShorthand() to isShorthandCSSProperty() for clarity
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacAccessibilityObjectMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm (179227 => 179228)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm        2015-01-28 00:02:45 UTC (rev 179227)
+++ trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm        2015-01-28 00:13:37 UTC (rev 179228)
</span><span class="lines">@@ -53,8 +53,11 @@
</span><span class="cx">             parent = parent-&gt;parentObjectUnignored();
</span><span class="cx">         parentWrapper = parent-&gt;wrapper();
</span><span class="cx">     }
</span><del>-    
</del><ins>+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored &quot;-Wdeprecated-declarations&quot;
</ins><span class="cx">     [[wrapper() attachmentView] accessibilitySetOverrideValue:parentWrapper forAttribute:NSAccessibilityParentAttribute];
</span><ins>+#pragma clang diagnostic pop
</ins><span class="cx"> }
</span><span class="cx">     
</span><span class="cx"> bool AccessibilityObject::accessibilityIgnoreAttachment() const
</span><span class="lines">@@ -65,9 +68,12 @@
</span><span class="cx">     if (isAttachment() &amp;&amp; (widget = widgetForAttachmentView()) &amp;&amp; widget-&gt;isFrameView())
</span><span class="cx">         return true;
</span><span class="cx"> 
</span><ins>+#pragma clang diagnostic push
+#pragma clang diagnostic ignored &quot;-Wdeprecated-declarations&quot;
</ins><span class="cx">     if ([wrapper() attachmentView])
</span><span class="cx">         return [[wrapper() attachmentView] accessibilityIsIgnored];
</span><del>-    
</del><ins>+#pragma clang diagnostic pop
+
</ins><span class="cx">     // Attachments are ignored by default (unless we determine that we should expose them).
</span><span class="cx">     return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (179227 => 179228)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm        2015-01-28 00:02:45 UTC (rev 179227)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm        2015-01-28 00:13:37 UTC (rev 179228)
</span><span class="lines">@@ -1969,8 +1969,11 @@
</span><span class="cx"> 
</span><span class="cx"> - (NSString*)role
</span><span class="cx"> {
</span><ins>+#pragma clang diagnostic push
+#pragma clang diagnostic ignored &quot;-Wdeprecated-declarations&quot;
</ins><span class="cx">     if (m_object-&gt;isAttachment())
</span><span class="cx">         return [[self attachmentView] accessibilityAttributeValue:NSAccessibilityRoleAttribute];
</span><ins>+#pragma clang diagnostic pop
</ins><span class="cx">     AccessibilityRole role = m_object-&gt;roleValue();
</span><span class="cx">     if (role == CanvasRole &amp;&amp; m_object-&gt;canvasHasFallbackContent())
</span><span class="cx">         role = GroupRole;
</span><span class="lines">@@ -2135,11 +2138,14 @@
</span><span class="cx"> {
</span><span class="cx">     if (!m_object)
</span><span class="cx">         return nil;
</span><del>-    
</del><ins>+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored &quot;-Wdeprecated-declarations&quot;
</ins><span class="cx">     // attachments have the AXImage role, but a different subrole
</span><span class="cx">     if (m_object-&gt;isAttachment())
</span><span class="cx">         return [[self attachmentView] accessibilityAttributeValue:NSAccessibilityRoleDescriptionAttribute];
</span><del>-    
</del><ins>+#pragma clang diagnostic pop
+
</ins><span class="cx">     NSString* axRole = [self role];
</span><span class="cx">     
</span><span class="cx">     if ([axRole isEqualToString:NSAccessibilityGroupRole]) {
</span><span class="lines">@@ -3150,6 +3156,9 @@
</span><span class="cx">     return paramAttrs;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+#pragma clang diagnostic push
+#pragma clang diagnostic ignored &quot;-Wdeprecated-declarations&quot;
+
</ins><span class="cx"> - (void)accessibilityPerformPressAction
</span><span class="cx"> {
</span><span class="cx">     if (![self updateObjectBackingStore])
</span><span class="lines">@@ -3183,6 +3192,8 @@
</span><span class="cx">         m_object-&gt;decrement();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+#pragma clang diagnostic pop
+
</ins><span class="cx"> - (void)accessibilityPerformShowMenuAction
</span><span class="cx"> {
</span><span class="cx">     if (m_object-&gt;roleValue() == ComboBoxRole)
</span></span></pre>
</div>
</div>

</body>
</html>