<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[179143] trunk/Source</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179143">179143</a></dd>

<dt>Author</dt> <dd>cdumez@apple.com</dd>

<dt>Date</dt> <dd>2015-01-26 14:36:36 -0800 (Mon, 26 Jan 2015)</dd>

</dl>

<h3>Log Message</h3>

<pre>First argument to DOM traversal functions should be a reference

https://bugs.webkit.org/show_bug.cgi?id=140895

Reviewed by Antti Koivisto.

First argument to DOM traversal functions should be a reference instead

of a pointer as it is dereferenced without null-check.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>

<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>

<li><a href="#trunkSourceWebCorebindingsjsJSDocumentCustomcpp">trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp</a></li>

<li><a href="#trunkSourceWebCorecssSelectorCheckercpp">trunk/Source/WebCore/css/SelectorChecker.cpp</a></li>

<li><a href="#trunkSourceWebCoredomAttrcpp">trunk/Source/WebCore/dom/Attr.cpp</a></li>

<li><a href="#trunkSourceWebCoredomCharacterDatacpp">trunk/Source/WebCore/dom/CharacterData.cpp</a></li>

<li><a href="#trunkSourceWebCoredomContainerNodecpp">trunk/Source/WebCore/dom/ContainerNode.cpp</a></li>

<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>

<li><a href="#trunkSourceWebCoredomDocumentMarkerControllercpp">trunk/Source/WebCore/dom/DocumentMarkerController.cpp</a></li>

<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>

<li><a href="#trunkSourceWebCoredomElementChildIteratorh">trunk/Source/WebCore/dom/ElementChildIterator.h</a></li>

<li><a href="#trunkSourceWebCoredomElementDescendantIteratorh">trunk/Source/WebCore/dom/ElementDescendantIterator.h</a></li>

<li><a href="#trunkSourceWebCoredomElementIteratorh">trunk/Source/WebCore/dom/ElementIterator.h</a></li>

<li><a href="#trunkSourceWebCoredomElementTraversalh">trunk/Source/WebCore/dom/ElementTraversal.h</a></li>

<li><a href="#trunkSourceWebCoredomInlineStyleSheetOwnercpp">trunk/Source/WebCore/dom/InlineStyleSheetOwner.cpp</a></li>

<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>

<li><a href="#trunkSourceWebCoredomNodeIteratorcpp">trunk/Source/WebCore/dom/NodeIterator.cpp</a></li>

<li><a href="#trunkSourceWebCoredomNodeTraversalcpp">trunk/Source/WebCore/dom/NodeTraversal.cpp</a></li>

<li><a href="#trunkSourceWebCoredomNodeTraversalh">trunk/Source/WebCore/dom/NodeTraversal.h</a></li>

<li><a href="#trunkSourceWebCoredomRangecpp">trunk/Source/WebCore/dom/Range.cpp</a></li>

<li><a href="#trunkSourceWebCoredomScriptElementcpp">trunk/Source/WebCore/dom/ScriptElement.cpp</a></li>

<li><a href="#trunkSourceWebCoredomShadowRootcpp">trunk/Source/WebCore/dom/ShadowRoot.cpp</a></li>

<li><a href="#trunkSourceWebCoredomTextcpp">trunk/Source/WebCore/dom/Text.cpp</a></li>

<li><a href="#trunkSourceWebCoredomTextNodeTraversalcpp">trunk/Source/WebCore/dom/TextNodeTraversal.cpp</a></li>

<li><a href="#trunkSourceWebCoredomTextNodeTraversalh">trunk/Source/WebCore/dom/TextNodeTraversal.h</a></li>

<li><a href="#trunkSourceWebCoredomTreeScopeAdoptercpp">trunk/Source/WebCore/dom/TreeScopeAdopter.cpp</a></li>

<li><a href="#trunkSourceWebCoredomTreeWalkercpp">trunk/Source/WebCore/dom/TreeWalker.cpp</a></li>

<li><a href="#trunkSourceWebCoredomTypedElementDescendantIteratorh">trunk/Source/WebCore/dom/TypedElementDescendantIterator.h</a></li>

<li><a href="#trunkSourceWebCoreeditingApplyStyleCommandcpp">trunk/Source/WebCore/editing/ApplyStyleCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingBreakBlockquoteCommandcpp">trunk/Source/WebCore/editing/BreakBlockquoteCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingCompositeEditCommandcpp">trunk/Source/WebCore/editing/CompositeEditCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingDeleteSelectionCommandcpp">trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingEditCommandcpp">trunk/Source/WebCore/editing/EditCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingEditingStylecpp">trunk/Source/WebCore/editing/EditingStyle.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingIndentOutdentCommandcpp">trunk/Source/WebCore/editing/IndentOutdentCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingInsertListCommandcpp">trunk/Source/WebCore/editing/InsertListCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingInsertParagraphSeparatorCommandcpp">trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingReplaceSelectionCommandcpp">trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingReplaceSelectionCommandh">trunk/Source/WebCore/editing/ReplaceSelectionCommand.h</a></li>

<li><a href="#trunkSourceWebCoreeditingSimplifyMarkupCommandcpp">trunk/Source/WebCore/editing/SimplifyMarkupCommand.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingTextIteratorcpp">trunk/Source/WebCore/editing/TextIterator.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingVisibleUnitscpp">trunk/Source/WebCore/editing/VisibleUnits.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingcocoaHTMLConvertermm">trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm</a></li>

<li><a href="#trunkSourceWebCoreeditinghtmleditingcpp">trunk/Source/WebCore/editing/htmlediting.cpp</a></li>

<li><a href="#trunkSourceWebCoreeditingiosEditorIOSmm">trunk/Source/WebCore/editing/ios/EditorIOS.mm</a></li>

<li><a href="#trunkSourceWebCoreeditingmacEditorMacmm">trunk/Source/WebCore/editing/mac/EditorMac.mm</a></li>

<li><a href="#trunkSourceWebCoreeditingmarkupcpp">trunk/Source/WebCore/editing/markup.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLCollectioncpp">trunk/Source/WebCore/html/HTMLCollection.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLFieldSetElementcpp">trunk/Source/WebCore/html/HTMLFieldSetElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementcpp">trunk/Source/WebCore/html/HTMLOptionElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTableElementcpp">trunk/Source/WebCore/html/HTMLTableElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTableRowsCollectioncpp">trunk/Source/WebCore/html/HTMLTableRowsCollection.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTableRowsCollectionh">trunk/Source/WebCore/html/HTMLTableRowsCollection.h</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTextFormControlElementcpp">trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTitleElementcpp">trunk/Source/WebCore/html/HTMLTitleElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlRadioInputTypecpp">trunk/Source/WebCore/html/RadioInputType.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlTextFieldInputTypecpp">trunk/Source/WebCore/html/TextFieldInputType.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmltrackVTTCuecpp">trunk/Source/WebCore/html/track/VTTCue.cpp</a></li>

<li><a href="#trunkSourceWebCoreinspectorInspectorNodeFindercpp">trunk/Source/WebCore/inspector/InspectorNodeFinder.cpp</a></li>

<li><a href="#trunkSourceWebCorepageFocusControllercpp">trunk/Source/WebCore/page/FocusController.cpp</a></li>

<li><a href="#trunkSourceWebCorepageFocusControllerh">trunk/Source/WebCore/page/FocusController.h</a></li>

<li><a href="#trunkSourceWebCorepageFramecpp">trunk/Source/WebCore/page/Frame.cpp</a></li>

<li><a href="#trunkSourceWebCorepageiosFrameIOSmm">trunk/Source/WebCore/page/ios/FrameIOS.mm</a></li>

<li><a href="#trunkSourceWebCorerenderingRenderCountercpp">trunk/Source/WebCore/rendering/RenderCounter.cpp</a></li>

<li><a href="#trunkSourceWebCorerenderingRenderListItemcpp">trunk/Source/WebCore/rendering/RenderListItem.cpp</a></li>

<li><a href="#trunkSourceWebCorerenderingRenderNamedFlowThreadcpp">trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp</a></li>

<li><a href="#trunkSourceWebCorerenderingRenderViewcpp">trunk/Source/WebCore/rendering/RenderView.cpp</a></li>

<li><a href="#trunkSourceWebCorexmlXPathNodeSetcpp">trunk/Source/WebCore/xml/XPathNodeSet.cpp</a></li>

<li><a href="#trunkSourceWebCorexmlXPathStepcpp">trunk/Source/WebCore/xml/XPathStep.cpp</a></li>

<li><a href="#trunkSourceWebCorexmlXPathUtilcpp">trunk/Source/WebCore/xml/XPathUtil.cpp</a></li>

<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>

<li><a href="#trunkSourceWebKitmacWebViewWebFramemm">trunk/Source/WebKit/mac/WebView/WebFrame.mm</a></li>

<li><a href="#trunkSourceWebKitmacWebViewWebHTMLRepresentationmm">trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm</a></li>

<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>

<li><a href="#trunkSourceWebKit2WebProcessWebPageWebFramecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/ChangeLog        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -1,3 +1,13 @@

</span><ins>+2015-01-26  Chris Dumez  &lt;cdumez@apple.com&gt;

+

+        First argument to DOM traversal functions should be a reference

+        https://bugs.webkit.org/show_bug.cgi?id=140895

+

+        Reviewed by Antti Koivisto.

+

+        First argument to DOM traversal functions should be a reference instead

+        of a pointer as it is dereferenced without null-check.

+

</ins><span class="cx"> 2015-01-26  Roger Fong  &lt;roger_fong@apple.com&gt;

</span><span class="cx"> 

<span class="cx">         [WebGL2] Update IDL for WebGL2.

</span></span></pre></div>

<a id="trunkSourceWebCoreWebCoreexpin"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/WebCore.exp.in        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/WebCore.exp.in        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -339,9 +339,9 @@

</span><span class="cx"> __ZN7WebCore13MachSendRight6createEj

</span><span class="cx"> __ZN7WebCore13MachSendRightD1Ev

</span><span class="cx"> __ZN7WebCore13MachSendRightaSEOS0_

</span><del>-__ZN7WebCore13NodeTraversal13deepLastChildEPNS_4NodeE

-__ZN7WebCore13NodeTraversal19nextAncestorSiblingEPKNS_4NodeE

-__ZN7WebCore13NodeTraversal19nextAncestorSiblingEPKNS_4NodeES3_

</del><ins>+__ZN7WebCore13NodeTraversal13deepLastChildERNS_4NodeE

+__ZN7WebCore13NodeTraversal19nextAncestorSiblingERKNS_4NodeE

+__ZN7WebCore13NodeTraversal19nextAncestorSiblingERKNS_4NodeEPS2_

</ins><span class="cx"> __ZN7WebCore13ResourceErrorC1EP7NSError

</span><span class="cx"> __ZN7WebCore13ResourceErrorC1EP9__CFError

</span><span class="cx"> __ZN7WebCore13SQLResultDoneE

</span></span></pre></div>

<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -467,10 +467,10 @@

</span><span class="cx">     

</span><span class="cx">     AccessibilityObject* accessibleObject = cache-&gt;getOrCreate(node-&gt;renderer());

</span><span class="cx">     while (accessibleObject &amp;&amp; accessibleObject-&gt;accessibilityIsIgnored()) {

</span><del>-        node = NodeTraversal::next(node);

</del><ins>+        node = NodeTraversal::next(*node);

</ins><span class="cx"> 

</span><span class="cx">         while (node &amp;&amp; !node-&gt;renderer())

</span><del>-            node = NodeTraversal::nextSkippingChildren(node);

</del><ins>+            node = NodeTraversal::nextSkippingChildren(*node);

</ins><span class="cx"> 

</span><span class="cx">         if (!node)

</span><span class="cx">             return nullptr;

</span></span></pre></div>

<a id="trunkSourceWebCorebindingsjsJSDocumentCustomcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -106,7 +106,7 @@

<span class="cx">     // back/forward cache.

</span><span class="cx">     if (!document-&gt;frame()) {

</span><span class="cx">         size_t nodeCount = 0;

</span><del>-        for (Node* n = document; n; n = NodeTraversal::next(n))

</del><ins>+        for (Node* n = document; n; n = NodeTraversal::next(*n))

</ins><span class="cx">             nodeCount++;

</span><span class="cx">         

</span><span class="cx">         exec-&gt;heap()-&gt;reportExtraMemoryCost(nodeCount * sizeof(Node));

</span></span></pre></div>

<a id="trunkSourceWebCorecssSelectorCheckercpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/css/SelectorChecker.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -87,19 +87,19 @@

</span><span class="cx">     bool hasSelectionPseudo;

</span><span class="cx"> };

</span><span class="cx"> 

</span><del>-static inline bool isFirstChildElement(const Element* element)

</del><ins>+static inline bool isFirstChildElement(const Element&amp; element)

</ins><span class="cx"> {

</span><span class="cx">     return !ElementTraversal::previousSibling(element);

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline bool isLastChildElement(const Element* element)

</del><ins>+static inline bool isLastChildElement(const Element&amp; element)

</ins><span class="cx"> {

</span><span class="cx">     return !ElementTraversal::nextSibling(element);

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline bool isFirstOfType(Element* element, const QualifiedName&amp; type, bool isResolvingStyle)

</del><ins>+static inline bool isFirstOfType(Element&amp; element, const QualifiedName&amp; type, bool isResolvingStyle)

</ins><span class="cx"> {

</span><del>-    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(sibling)) {

</del><ins>+    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(*sibling)) {

</ins><span class="cx">         if (isResolvingStyle)

</span><span class="cx">             sibling-&gt;setAffectsNextSiblingElementStyle();

</span><span class="cx">         if (sibling-&gt;hasTagName(type))

</span><span class="lines">@@ -108,19 +108,19 @@

</span><span class="cx">     return true;

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline bool isLastOfType(const Element* element, const QualifiedName&amp; type)

</del><ins>+static inline bool isLastOfType(const Element&amp; element, const QualifiedName&amp; type)

</ins><span class="cx"> {

</span><del>-    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(sibling)) {

</del><ins>+    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(*sibling)) {

</ins><span class="cx">         if (sibling-&gt;hasTagName(type))

</span><span class="cx">             return false;

</span><span class="cx">     }

</span><span class="cx">     return true;

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline int countElementsBefore(Element* element, bool isResolvingStyle)

</del><ins>+static inline int countElementsBefore(Element&amp; element, bool isResolvingStyle)

</ins><span class="cx"> {

</span><span class="cx">     int count = 0;

</span><del>-    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(sibling)) {

</del><ins>+    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(*sibling)) {

</ins><span class="cx">         if (isResolvingStyle)

</span><span class="cx">             sibling-&gt;setAffectsNextSiblingElementStyle();

</span><span class="cx"> 

</span><span class="lines">@@ -134,10 +134,10 @@

</span><span class="cx">     return count;

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline int countElementsOfTypeBefore(Element* element, const QualifiedName&amp; type, bool isResolvingStyle)

</del><ins>+static inline int countElementsOfTypeBefore(Element&amp; element, const QualifiedName&amp; type, bool isResolvingStyle)

</ins><span class="cx"> {

</span><span class="cx">     int count = 0;

</span><del>-    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(sibling)) {

</del><ins>+    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(*sibling)) {

</ins><span class="cx">         if (isResolvingStyle)

</span><span class="cx">             sibling-&gt;setAffectsNextSiblingElementStyle();

</span><span class="cx"> 

</span><span class="lines">@@ -147,18 +147,18 @@

</span><span class="cx">     return count;

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline int countElementsAfter(const Element* element)

</del><ins>+static inline int countElementsAfter(const Element&amp; element)

</ins><span class="cx"> {

</span><span class="cx">     int count = 0;

</span><del>-    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(sibling))

</del><ins>+    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(*sibling))

</ins><span class="cx">         ++count;

</span><span class="cx">     return count;

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-static inline int countElementsOfTypeAfter(const Element* element, const QualifiedName&amp; type)

</del><ins>+static inline int countElementsOfTypeAfter(const Element&amp; element, const QualifiedName&amp; type)

</ins><span class="cx"> {

</span><span class="cx">     int count = 0;

</span><del>-    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(sibling)) {

</del><ins>+    for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(*sibling)) {

</ins><span class="cx">         if (sibling-&gt;hasTagName(type))

</span><span class="cx">             ++count;

</span><span class="cx">     }

</span><span class="lines">@@ -643,7 +643,7 @@

</span><span class="cx">         case CSSSelector::PseudoClassFirstChild:

</span><span class="cx">             // first-child matches the first child that is an element

</span><span class="cx">             if (Element* parentElement = element-&gt;parentElement()) {

</span><del>-                bool result = isFirstChildElement(element);

</del><ins>+                bool result = isFirstChildElement(*element);

</ins><span class="cx">                 if (context.resolvingMode == Mode::ResolvingStyle) {

</span><span class="cx">                     RenderStyle* childStyle = context.elementStyle ? context.elementStyle : element-&gt;renderStyle();

</span><span class="cx">                     parentElement-&gt;setChildrenAffectedByFirstChildRules();

</span><span class="lines">@@ -659,13 +659,13 @@

</span><span class="cx">                 if (context.resolvingMode == Mode::ResolvingStyle)

</span><span class="cx">                     element-&gt;setStyleIsAffectedByPreviousSibling();

</span><span class="cx"> 

</span><del>-                return isFirstOfType(element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle);

</del><ins>+                return isFirstOfType(*element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle);

</ins><span class="cx">             }

</span><span class="cx">             break;

</span><span class="cx">         case CSSSelector::PseudoClassLastChild:

</span><span class="cx">             // last-child matches the last child that is an element

</span><span class="cx">             if (Element* parentElement = element-&gt;parentElement()) {

</span><del>-                bool result = parentElement-&gt;isFinishedParsingChildren() &amp;&amp; isLastChildElement(element);

</del><ins>+                bool result = parentElement-&gt;isFinishedParsingChildren() &amp;&amp; isLastChildElement(*element);

</ins><span class="cx">                 if (context.resolvingMode == Mode::ResolvingStyle) {

</span><span class="cx">                     RenderStyle* childStyle = context.elementStyle ? context.elementStyle : element-&gt;renderStyle();

</span><span class="cx">                     parentElement-&gt;setChildrenAffectedByLastChildRules();

</span><span class="lines">@@ -682,13 +682,13 @@

</span><span class="cx">                     parentElement-&gt;setChildrenAffectedByBackwardPositionalRules();

</span><span class="cx">                 if (!parentElement-&gt;isFinishedParsingChildren())

</span><span class="cx">                     return false;

</span><del>-                return isLastOfType(element, element-&gt;tagQName());

</del><ins>+                return isLastOfType(*element, element-&gt;tagQName());

</ins><span class="cx">             }

</span><span class="cx">             break;

</span><span class="cx">         case CSSSelector::PseudoClassOnlyChild:

</span><span class="cx">             if (Element* parentElement = element-&gt;parentElement()) {

</span><del>-                bool firstChild = isFirstChildElement(element);

-                bool onlyChild = firstChild &amp;&amp; parentElement-&gt;isFinishedParsingChildren() &amp;&amp; isLastChildElement(element);

</del><ins>+                bool firstChild = isFirstChildElement(*element);

+                bool onlyChild = firstChild &amp;&amp; parentElement-&gt;isFinishedParsingChildren() &amp;&amp; isLastChildElement(*element);

</ins><span class="cx">                 if (context.resolvingMode == Mode::ResolvingStyle) {

</span><span class="cx">                     RenderStyle* childStyle = context.elementStyle ? context.elementStyle : element-&gt;renderStyle();

</span><span class="cx">                     parentElement-&gt;setChildrenAffectedByFirstChildRules();

</span><span class="lines">@@ -710,7 +710,7 @@

</span><span class="cx">                 }

</span><span class="cx">                 if (!parentElement-&gt;isFinishedParsingChildren())

</span><span class="cx">                     return false;

</span><del>-                return isFirstOfType(element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle) &amp;&amp; isLastOfType(element, element-&gt;tagQName());

</del><ins>+                return isFirstOfType(*element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle) &amp;&amp; isLastOfType(*element, element-&gt;tagQName());

</ins><span class="cx">             }

</span><span class="cx">             break;

</span><span class="cx">         case CSSSelector::PseudoClassMatches:

</span><span class="lines">@@ -770,7 +770,7 @@

</span><span class="cx"> 

</span><span class="cx">                 int count = 1;

</span><span class="cx">                 if (const CSSSelectorList* selectorList = selector-&gt;selectorList()) {

</span><del>-                    for (Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(sibling)) {

</del><ins>+                    for (Element* sibling = ElementTraversal::previousSibling(*element); sibling; sibling = ElementTraversal::previousSibling(*sibling)) {

</ins><span class="cx">                         if (context.resolvingMode == Mode::ResolvingStyle)

</span><span class="cx">                             sibling-&gt;setAffectsNextSiblingElementStyle();

</span><span class="cx"> 

</span><span class="lines">@@ -779,7 +779,7 @@

</span><span class="cx">                             ++count;

</span><span class="cx">                     }

</span><span class="cx">                 } else {

</span><del>-                    count += countElementsBefore(element, context.resolvingMode == Mode::ResolvingStyle);

</del><ins>+                    count += countElementsBefore(*element, context.resolvingMode == Mode::ResolvingStyle);

</ins><span class="cx">                     if (context.resolvingMode == Mode::ResolvingStyle)

</span><span class="cx">                         element-&gt;setChildIndex(count);

</span><span class="cx">                 }

</span><span class="lines">@@ -796,7 +796,7 @@

</span><span class="cx">                 if (context.resolvingMode == Mode::ResolvingStyle)

</span><span class="cx">                     element-&gt;setStyleIsAffectedByPreviousSibling();

</span><span class="cx"> 

</span><del>-                int count = 1 + countElementsOfTypeBefore(element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle);

</del><ins>+                int count = 1 + countElementsOfTypeBefore(*element, element-&gt;tagQName(), context.resolvingMode == Mode::ResolvingStyle);

</ins><span class="cx">                 if (selector-&gt;matchNth(count))

</span><span class="cx">                     return true;

</span><span class="cx">             }

</span><span class="lines">@@ -824,13 +824,13 @@

</span><span class="cx"> 

</span><span class="cx">                 int count = 1;

</span><span class="cx">                 if (const CSSSelectorList* selectorList = selector-&gt;selectorList()) {

</span><del>-                    for (Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(sibling)) {

</del><ins>+                    for (Element* sibling = ElementTraversal::nextSibling(*element); sibling; sibling = ElementTraversal::nextSibling(*sibling)) {

</ins><span class="cx">                         unsigned ignoredSpecificity;

</span><span class="cx">                         if (matchSelectorList(context, *sibling, *selectorList, ignoredSpecificity))

</span><span class="cx">                             ++count;

</span><span class="cx">                     }

</span><span class="cx">                 } else

</span><del>-                    count += countElementsAfter(element);

</del><ins>+                    count += countElementsAfter(*element);

</ins><span class="cx"> 

</span><span class="cx">                 if (selector-&gt;matchNth(count))

</span><span class="cx">                     return true;

</span><span class="lines">@@ -845,7 +845,7 @@

</span><span class="cx">                 if (!parentElement-&gt;isFinishedParsingChildren())

</span><span class="cx">                     return false;

</span><span class="cx"> 

</span><del>-                int count = 1 + countElementsOfTypeAfter(element, element-&gt;tagQName());

</del><ins>+                int count = 1 + countElementsOfTypeAfter(*element, element-&gt;tagQName());

</ins><span class="cx">                 if (selector-&gt;matchNth(count))

</span><span class="cx">                     return true;

</span><span class="cx">             }

</span></span></pre></div>

<a id="trunkSourceWebCoredomAttrcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/Attr.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/Attr.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -164,7 +164,7 @@

</span><span class="cx">     invalidateNodeListAndCollectionCachesInAncestors(&amp;qualifiedName(), m_element);

</span><span class="cx"> 

</span><span class="cx">     StringBuilder valueBuilder;

</span><del>-    TextNodeTraversal::appendContents(this, valueBuilder);

</del><ins>+    TextNodeTraversal::appendContents(*this, valueBuilder);

</ins><span class="cx"> 

</span><span class="cx">     AtomicString oldValue = value();

</span><span class="cx">     AtomicString newValue = valueBuilder.toAtomicString();

</span></span></pre></div>

<a id="trunkSourceWebCoredomCharacterDatacpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CharacterData.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/CharacterData.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/CharacterData.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -97,8 +97,8 @@

</span><span class="cx">     if (parentNode()) {

</span><span class="cx">         ContainerNode::ChildChange change = {

</span><span class="cx">             ContainerNode::TextChanged,

</span><del>-            ElementTraversal::previousSibling(this),

-            ElementTraversal::nextSibling(this),

</del><ins>+            ElementTraversal::previousSibling(*this),

+            ElementTraversal::nextSibling(*this),

</ins><span class="cx">             ContainerNode::ChildChangeSourceParser

</span><span class="cx">         };

</span><span class="cx">         parentNode()-&gt;childrenChanged(change);

</span><span class="lines">@@ -217,14 +217,14 @@

</span><span class="cx">         if (parentNode()) {

</span><span class="cx">             ContainerNode::ChildChange change = {

</span><span class="cx">                 ContainerNode::TextChanged,

</span><del>-                ElementTraversal::previousSibling(this),

-                ElementTraversal::nextSibling(this),

</del><ins>+                ElementTraversal::previousSibling(*this),

+                ElementTraversal::nextSibling(*this),

</ins><span class="cx">                 ContainerNode::ChildChangeSourceAPI

</span><span class="cx">             };

</span><span class="cx">             parentNode()-&gt;childrenChanged(change);

</span><span class="cx">         }

</span><span class="cx">         if (document().hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))

</span><del>-            dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));

</del><ins>+            dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, nullptr, oldData, m_data));

</ins><span class="cx">         dispatchSubtreeModifiedEvent();

</span><span class="cx">     }

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkSourceWebCoredomContainerNodecpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/ContainerNode.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -331,8 +331,8 @@

</span><span class="cx"> {

</span><span class="cx">     ChildChange change;

</span><span class="cx">     change.type = child.isElementNode() ? ElementInserted : child.isTextNode() ? TextInserted : NonContentsChildChanged;

</span><del>-    change.previousSiblingElement = ElementTraversal::previousSibling(&amp;child);

-    change.nextSiblingElement = ElementTraversal::nextSibling(&amp;child);

</del><ins>+    change.previousSiblingElement = ElementTraversal::previousSibling(child);

+    change.nextSiblingElement = ElementTraversal::nextSibling(child);

</ins><span class="cx">     change.source = source;

</span><span class="cx"> 

</span><span class="cx">     childrenChanged(change);

</span><span class="lines">@@ -342,8 +342,8 @@

</span><span class="cx"> {

</span><span class="cx">     ChildChange change;

</span><span class="cx">     change.type = is&lt;Element&gt;(child) ? ElementRemoved : is&lt;Text&gt;(child) ? TextRemoved : NonContentsChildChanged;

</span><del>-    change.previousSiblingElement = (!previousSibling || is&lt;Element&gt;(*previousSibling)) ? downcast&lt;Element&gt;(previousSibling) : ElementTraversal::previousSibling(previousSibling);

-    change.nextSiblingElement = (!nextSibling || is&lt;Element&gt;(*nextSibling)) ? downcast&lt;Element&gt;(nextSibling) : ElementTraversal::nextSibling(nextSibling);

</del><ins>+    change.previousSiblingElement = (!previousSibling || is&lt;Element&gt;(*previousSibling)) ? downcast&lt;Element&gt;(previousSibling) : ElementTraversal::previousSibling(*previousSibling);

+    change.nextSiblingElement = (!nextSibling || is&lt;Element&gt;(*nextSibling)) ? downcast&lt;Element&gt;(nextSibling) : ElementTraversal::nextSibling(*nextSibling);

</ins><span class="cx">     change.source = source;

</span><span class="cx"> 

</span><span class="cx">     childrenChanged(change);

</span><span class="lines">@@ -809,7 +809,7 @@

</span><span class="cx"> 

</span><span class="cx">     // dispatch the DOMNodeInsertedIntoDocument event to all descendants

</span><span class="cx">     if (c-&gt;inDocument() &amp;&amp; document-&gt;hasListenerType(Document::DOMNODEINSERTEDINTODOCUMENT_LISTENER)) {

</span><del>-        for (; c; c = NodeTraversal::next(c.get(), &amp;child))

</del><ins>+        for (; c; c = NodeTraversal::next(*c, &amp;child))

</ins><span class="cx">             c-&gt;dispatchScopedEvent(MutationEvent::create(eventNames().DOMNodeInsertedIntoDocumentEvent, false));

</span><span class="cx">     }

</span><span class="cx"> }

</span><span class="lines">@@ -835,7 +835,7 @@

</span><span class="cx"> 

</span><span class="cx">     // dispatch the DOMNodeRemovedFromDocument event to all descendants

</span><span class="cx">     if (c-&gt;inDocument() &amp;&amp; document-&gt;hasListenerType(Document::DOMNODEREMOVEDFROMDOCUMENT_LISTENER)) {

</span><del>-        for (; c; c = NodeTraversal::next(c.get(), &amp;child))

</del><ins>+        for (; c; c = NodeTraversal::next(*c, &amp;child))

</ins><span class="cx">             c-&gt;dispatchScopedEvent(MutationEvent::create(eventNames().DOMNodeRemovedFromDocumentEvent, false));

</span><span class="cx">     }

</span><span class="cx"> }

</span></span></pre></div>

<a id="trunkSourceWebCoredomDocumentcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/Document.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -2155,7 +2155,7 @@

</span><span class="cx"> #if ENABLE(IOS_TOUCH_EVENTS)

</span><span class="cx">     clearTouchEventListeners();

</span><span class="cx"> #endif

</span><del>-    for (Node* node = firstChild(); node; node = NodeTraversal::next(node))

</del><ins>+    for (Node* node = firstChild(); node; node = NodeTraversal::next(*node))

</ins><span class="cx">         node-&gt;removeAllEventListeners();

</span><span class="cx"> }

</span><span class="cx"> 

</span><span class="lines">@@ -3272,7 +3272,7 @@

</span><span class="cx">     ensureStyleResolver().clearCachedPropertiesAffectedByViewportUnits();

</span><span class="cx"> 

<span class="cx">     // FIXME: Ideally, we should save the list of elements that have viewport units and only iterate over those.

</span><del>-    for (Element* element = ElementTraversal::firstWithin(&amp;rootNode()); element; element = ElementTraversal::nextIncludingPseudo(element)) {

</del><ins>+    for (Element* element = ElementTraversal::firstWithin(rootNode()); element; element = ElementTraversal::nextIncludingPseudo(*element)) {

</ins><span class="cx">         auto* renderer = element-&gt;renderer();

</span><span class="cx">         if (renderer &amp;&amp; renderer-&gt;style().hasViewportUnits())

</span><span class="cx">             element-&gt;setNeedsStyleRecalc(InlineStyleChange);

</span></span></pre></div>

<a id="trunkSourceWebCoredomDocumentMarkerControllercpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -404,7 +404,7 @@

</span><span class="cx">     ASSERT(endContainer);

</span><span class="cx"> 

</span><span class="cx">     Node* pastLastNode = range-&gt;pastLastNode();

</span><del>-    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(node)) {

</del><ins>+    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(*node)) {

</ins><span class="cx">         for (auto* marker : markersFor(node)) {

</span><span class="cx">             if (!markerTypes.contains(marker-&gt;type()))

</span><span class="cx">                 continue;

</span><span class="lines">@@ -629,7 +629,7 @@

</span><span class="cx"> 

</span><span class="cx">     Node* pastLastNode = range-&gt;pastLastNode();

</span><span class="cx"> 

</span><del>-    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(node)) {

</del><ins>+    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(*node)) {

</ins><span class="cx">         int startOffset = node == startContainer ? range-&gt;startOffset() : 0;

</span><span class="cx">         int endOffset = node == endContainer ? range-&gt;endOffset() : INT_MAX;

</span><span class="cx">         setMarkersActive(node, startOffset, endOffset, active);

</span><span class="lines">@@ -675,7 +675,7 @@

</span><span class="cx">     ASSERT(endContainer);

</span><span class="cx"> 

</span><span class="cx">     Node* pastLastNode = range-&gt;pastLastNode();

</span><del>-    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(node)) {

</del><ins>+    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(*node)) {

</ins><span class="cx">         for (auto* marker : markersFor(node)) {

</span><span class="cx">             if (!markerTypes.contains(marker-&gt;type()))

</span><span class="cx">                 continue;

</span><span class="lines">@@ -699,7 +699,7 @@

</span><span class="cx">     Node* endContainer = range-&gt;endContainer();

</span><span class="cx"> 

</span><span class="cx">     Node* pastLastNode = range-&gt;pastLastNode();

</span><del>-    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(node)) {

</del><ins>+    for (Node* node = range-&gt;firstNode(); node != pastLastNode; node = NodeTraversal::next(*node)) {

</ins><span class="cx">         unsigned startOffset = node == startContainer ? range-&gt;startOffset() : 0;

</span><span class="cx">         unsigned endOffset = node == endContainer ? static_cast&lt;unsigned&gt;(range-&gt;endOffset()) : std::numeric_limits&lt;unsigned&gt;::max();

</span><span class="cx">         MarkerList* list = m_markers.get(node);

</span></span></pre></div>

<a id="trunkSourceWebCoredomElementcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/Element.cpp        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/Element.cpp        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -1558,18 +1558,18 @@

</span><span class="cx"> 

</span><span class="cx"> enum SiblingCheckType { FinishedParsingChildren, SiblingElementRemoved, Other };

</span><span class="cx"> 

</span><del>-static void checkForSiblingStyleChanges(Element* parent, SiblingCheckType checkType, Element* elementBeforeChange, Element* elementAfterChange)

</del><ins>+static void checkForSiblingStyleChanges(Element&amp; parent, SiblingCheckType checkType, Element* elementBeforeChange, Element* elementAfterChange)

</ins><span class="cx"> {

<span class="cx">     // :empty selector.

</span><del>-    checkForEmptyStyleChange(*parent);

</del><ins>+    checkForEmptyStyleChange(parent);

</ins><span class="cx"> 

</span><del>-    if (parent-&gt;styleChangeType() &gt;= FullStyleChange)

</del><ins>+    if (parent.styleChangeType() &gt;= FullStyleChange)

</ins><span class="cx">         return;

</span><span class="cx"> 

<span class="cx">     // :first-child.  In the parser callback case, we don't have to check anything, since we were right the first time.

<span class="cx">     // In the DOM case, we only need to do something if |afterChange| is not 0.

<span class="cx">     // |afterChange| is 0 in the parser case, so it works out that we'll skip this block.

</span><del>-    if (parent-&gt;childrenAffectedByFirstChildRules() &amp;&amp; elementAfterChange) {

</del><ins>+    if (parent.childrenAffectedByFirstChildRules() &amp;&amp; elementAfterChange) {

</ins><span class="cx">         // Find our new first child.

</span><span class="cx">         Element* newFirstElement = ElementTraversal::firstChild(parent);

</span><span class="cx">         // Find the first element node following |afterChange|

</span><span class="lines">@@ -1591,7 +1591,7 @@

</span><span class="cx"> 

<span class="cx">     // :last-child.  In the parser callback case, we don't have to check anything, since we were right the first time.

<span class="cx">     // In the DOM case, we only need to do something if |afterChange| is not 0.

</span><del>-    if (parent-&gt;childrenAffectedByLastChildRules() &amp;&amp; elementBeforeChange) {

</del><ins>+    if (parent.childrenAffectedByLastChildRules() &amp;&amp; elementBeforeChange) {

</ins><span class="cx">         // Find our new last child.

</span><span class="cx">         Element* newLastElement = ElementTraversal::lastChild(parent);

</span><span class="cx"> 

</span><span class="lines">@@ -1630,8 +1630,8 @@

<span class="cx">     // |afterChange| is 0 in the parser callback case, so we won't do any work for the forward case if we don't have to.

</span><span class="cx">     // For performance reasons we just mark the parent node as changed, since we don't want to make childrenChanged O(n^2) by crawling all our kids

<span class="cx">     // here.  recalcStyle will then force a walk of the children when it sees that this has happened.

</span><del>-    if (parent-&gt;childrenAffectedByBackwardPositionalRules() &amp;&amp; elementBeforeChange)

-        parent-&gt;setNeedsStyleRecalc();

</del><ins>+    if (parent.childrenAffectedByBackwardPositionalRules() &amp;&amp; elementBeforeChange)

+        parent.setNeedsStyleRecalc();

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> void Element::childrenChanged(const ChildChange&amp; change)

</span><span class="lines">@@ -1641,7 +1641,7 @@

</span><span class="cx">         checkForEmptyStyleChange(*this);

</span><span class="cx">     else {

</span><span class="cx">         SiblingCheckType checkType = change.type == ElementRemoved ? SiblingElementRemoved : Other;

</span><del>-        checkForSiblingStyleChanges(this, checkType, change.previousSiblingElement, change.nextSiblingElement);

</del><ins>+        checkForSiblingStyleChanges(*this, checkType, change.previousSiblingElement, change.nextSiblingElement);

</ins><span class="cx">     }

</span><span class="cx"> 

</span><span class="cx">     if (ShadowRoot* shadowRoot = this-&gt;shadowRoot())

</span><span class="lines">@@ -1666,7 +1666,7 @@

</span><span class="cx"> {

</span><span class="cx">     ContainerNode::finishParsingChildren();

</span><span class="cx">     setIsParsingChildrenFinished();

</span><del>-    checkForSiblingStyleChanges(this, FinishedParsingChildren, ElementTraversal::lastChild(this), nullptr);

</del><ins>+    checkForSiblingStyleChanges(*this, FinishedParsingChildren, ElementTraversal::lastChild(*this), nullptr);

</ins><span class="cx">     if (auto styleResolver = document().styleResolverIfExists())

</span><span class="cx">         styleResolver-&gt;popParentElement(this);

</span><span class="cx"> }

</span><span class="lines">@@ -2375,22 +2375,22 @@

</span><span class="cx"> // ElementTraversal API

</span><span class="cx"> Element* Element::firstElementChild() const

</span><span class="cx"> {

</span><del>-    return ElementTraversal::firstChild(this);

</del><ins>+    return ElementTraversal::firstChild(*this);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> Element* Element::lastElementChild() const

</span><span class="cx"> {

</span><del>-    return ElementTraversal::lastChild(this);

</del><ins>+    return ElementTraversal::lastChild(*this);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> Element* Element::previousElementSibling() const

</span><span class="cx"> {

</span><del>-    return ElementTraversal::previousSibling(this);

</del><ins>+    return ElementTraversal::previousSibling(*this);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> Element* Element::nextElementSibling() const

</span><span class="cx"> {

</span><del>-    return ElementTraversal::nextSibling(this);

</del><ins>+    return ElementTraversal::nextSibling(*this);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> unsigned Element::childElementCount() const

</span></span></pre></div>

<a id="trunkSourceWebCoredomElementChildIteratorh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ElementChildIterator.h (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/ElementChildIterator.h        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/ElementChildIterator.h        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -132,7 +132,7 @@

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline ElementChildIterator&lt;ElementType&gt; ElementChildIteratorAdapter&lt;ElementType&gt;::begin()

</span><span class="cx"> {

</span><del>-    return ElementChildIterator&lt;ElementType&gt;(m_parent, Traversal&lt;ElementType&gt;::firstChild(&amp;m_parent));

</del><ins>+    return ElementChildIterator&lt;ElementType&gt;(m_parent, Traversal&lt;ElementType&gt;::firstChild(m_parent));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="lines">@@ -144,13 +144,13 @@

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline ElementType* ElementChildIteratorAdapter&lt;ElementType&gt;::first()

</span><span class="cx"> {

</span><del>-    return Traversal&lt;ElementType&gt;::firstChild(&amp;m_parent);

</del><ins>+    return Traversal&lt;ElementType&gt;::firstChild(m_parent);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline ElementType* ElementChildIteratorAdapter&lt;ElementType&gt;::last()

</span><span class="cx"> {

</span><del>-    return Traversal&lt;ElementType&gt;::lastChild(&amp;m_parent);

</del><ins>+    return Traversal&lt;ElementType&gt;::lastChild(m_parent);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="lines">@@ -171,7 +171,7 @@

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline ElementChildConstIterator&lt;ElementType&gt; ElementChildConstIteratorAdapter&lt;ElementType&gt;::begin() const

</span><span class="cx"> {

</span><del>-    return ElementChildConstIterator&lt;ElementType&gt;(m_parent, Traversal&lt;ElementType&gt;::firstChild(&amp;m_parent));

</del><ins>+    return ElementChildConstIterator&lt;ElementType&gt;(m_parent, Traversal&lt;ElementType&gt;::firstChild(m_parent));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="lines">@@ -183,13 +183,13 @@

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline const ElementType* ElementChildConstIteratorAdapter&lt;ElementType&gt;::first() const

</span><span class="cx"> {

</span><del>-    return Traversal&lt;ElementType&gt;::firstChild(&amp;m_parent);

</del><ins>+    return Traversal&lt;ElementType&gt;::firstChild(m_parent);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span><span class="cx"> inline const ElementType* ElementChildConstIteratorAdapter&lt;ElementType&gt;::last() const

</span><span class="cx"> {

</span><del>-    return Traversal&lt;ElementType&gt;::lastChild(&amp;m_parent);

</del><ins>+    return Traversal&lt;ElementType&gt;::lastChild(m_parent);

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> template &lt;typename ElementType&gt;

</span></span></pre></div>

<a id="trunkSourceWebCoredomElementDescendantIteratorh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ElementDescendantIterator.h (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/ElementDescendantIterator.h        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/ElementDescendantIterator.h        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -121,8 +121,8 @@

</span><span class="cx">     ASSERT(m_current);

</span><span class="cx">     ASSERT(!m_assertions.domTreeHasMutated());

</span><span class="cx"> 

</span><del>-    Element* firstChild = ElementTraversal::firstChild(m_current);

-    Element* nextSibling = ElementTraversal::nextSibling(m_current);

</del><ins>+    Element* firstChild = ElementTraversal::firstChild(*m_current);

+    Element* nextSibling = ElementTraversal::nextSibling(*m_current);

</ins><span class="cx"> 

</span><span class="cx">     if (firstChild) {

</span><span class="cx">         if (nextSibling)

</span><span class="lines">@@ -152,7 +152,7 @@

</span><span class="cx">     ASSERT(m_current);

</span><span class="cx">     ASSERT(!m_assertions.domTreeHasMutated());

</span><span class="cx"> 

</span><del>-    Element* previousSibling = ElementTraversal::previousSibling(m_current);

</del><ins>+    Element* previousSibling = ElementTraversal::previousSibling(*m_current);

</ins><span class="cx"> 

</span><span class="cx">     if (!previousSibling) {

</span><span class="cx">         m_current = m_current-&gt;parentElement();

</span><span class="lines">@@ -163,7 +163,7 @@

</span><span class="cx">     }

</span><span class="cx"> 

</span><span class="cx">     Element* deepestSibling = previousSibling;

</span><del>-    while (Element* lastChild = ElementTraversal::lastChild(deepestSibling))

</del><ins>+    while (Element* lastChild = ElementTraversal::lastChild(*deepestSibling))

</ins><span class="cx">         deepestSibling = lastChild;

</span><span class="cx">     ASSERT(deepestSibling);

</span><span class="cx"> 

</span><span class="lines">@@ -224,8 +224,8 @@

</span><span class="cx">     ASSERT(m_current);

</span><span class="cx">     ASSERT(!m_assertions.domTreeHasMutated());

</span><span class="cx"> 

</span><del>-    Element* firstChild = ElementTraversal::firstChild(m_current);

-    Element* nextSibling = ElementTraversal::nextSibling(m_current);

</del><ins>+    Element* firstChild = ElementTraversal::firstChild(*m_current);

+    Element* nextSibling = ElementTraversal::nextSibling(*m_current);

</ins><span class="cx"> 

</span><span class="cx">     if (firstChild) {

</span><span class="cx">         if (nextSibling)

</span><span class="lines">@@ -284,7 +284,7 @@

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantIterator ElementDescendantIteratorAdapter::begin()

</span><span class="cx"> {

</span><del>-    return ElementDescendantIterator(ElementTraversal::firstChild(&amp;m_root));

</del><ins>+    return ElementDescendantIterator(ElementTraversal::firstChild(m_root));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantIterator ElementDescendantIteratorAdapter::end()

</span><span class="lines">@@ -294,7 +294,7 @@

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantIterator ElementDescendantIteratorAdapter::last()

</span><span class="cx"> {

</span><del>-    return ElementDescendantIterator(ElementTraversal::lastWithin(&amp;m_root));

</del><ins>+    return ElementDescendantIterator(ElementTraversal::lastWithin(m_root));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> // ElementDescendantConstIteratorAdapter

</span><span class="lines">@@ -306,7 +306,7 @@

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantConstIterator ElementDescendantConstIteratorAdapter::begin() const

</span><span class="cx"> {

</span><del>-    return ElementDescendantConstIterator(ElementTraversal::firstChild(&amp;m_root));

</del><ins>+    return ElementDescendantConstIterator(ElementTraversal::firstChild(m_root));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantConstIterator ElementDescendantConstIteratorAdapter::end() const

</span><span class="lines">@@ -316,7 +316,7 @@

</span><span class="cx"> 

</span><span class="cx"> inline ElementDescendantConstIterator ElementDescendantConstIteratorAdapter::last() const

</span><span class="cx"> {

</span><del>-    return ElementDescendantConstIterator(ElementTraversal::lastWithin(&amp;m_root));

</del><ins>+    return ElementDescendantConstIterator(ElementTraversal::lastWithin(m_root));

</ins><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> // Standalone functions

</span></span></pre></div>

<a id="trunkSourceWebCoredomElementIteratorh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ElementIterator.h (179142 => 179143)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/dom/ElementIterator.h        2015-01-26 22:03:00 UTC (rev 179142)

+++ trunk/Source/WebCore/dom/ElementIterator.h        2015-01-26 22:36:36 UTC (rev 179143)

</span><span class="lines">@@ -114,7 +114,7 @@

</span><span class="cx"> {

</span><span class="cx">     ASSERT(m_current);

</span><span class="cx">     ASSERT(!m_assertions.domTreeHasMutated());

</span><del>-    m_current = Traversal&lt;ElementType&gt;::next(m_current, m_root);

</del><ins>+    m_current = Traversal&lt;ElementType&gt;::next(*m_current, m_root);

</ins><span class="cx"> #if !ASSERT_DISABLED