<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[179006] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/179006">179006</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2015-01-23 02:33:33 -0800 (Fri, 23 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Initialization for some member variable of FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=136327
Patch by Byeongha Cho <byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.
No new tests. There's no functional change.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfreetypeFontPlatformDataFreeTypecpp">trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (179005 => 179006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2015-01-23 10:05:05 UTC (rev 179005)
+++ trunk/Source/WebCore/ChangeLog 2015-01-23 10:33:33 UTC (rev 179006)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2015-01-23 Byeongha Cho <byeongha.cho@samsung.com>
+
+ Initialization for some member variable of FontPlatformData
+ https://bugs.webkit.org/show_bug.cgi?id=136327
+
+ Reviewed by Myles C. Maxfield.
+
+ No new tests. There's no functional change.
+
+ * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::operator=):
+ (WebCore::FontPlatformData::~FontPlatformData):
+
</ins><span class="cx"> 2015-01-23 Grzegorz Czajkowski <g.czajkowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfreetypeFontPlatformDataFreeTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp (179005 => 179006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2015-01-23 10:05:05 UTC (rev 179005)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2015-01-23 10:33:33 UTC (rev 179006)
</span><span class="lines">@@ -127,12 +127,12 @@
</span><span class="cx">
</span><span class="cx"> FontPlatformData::FontPlatformData(FcPattern* pattern, const FontDescription& fontDescription)
</span><span class="cx"> : m_pattern(pattern)
</span><del>- , m_fallbacks(0)
</del><ins>+ , m_fallbacks(nullptr)
</ins><span class="cx"> , m_size(fontDescription.computedPixelSize())
</span><span class="cx"> , m_syntheticBold(false)
</span><span class="cx"> , m_syntheticOblique(false)
</span><span class="cx"> , m_fixedWidth(false)
</span><del>- , m_scaledFont(0)
</del><ins>+ , m_scaledFont(nullptr)
</ins><span class="cx"> , m_orientation(fontDescription.orientation())
</span><span class="cx"> {
</span><span class="cx"> RefPtr<cairo_font_face_t> fontFace = adoptRef(cairo_ft_font_face_create_for_pattern(m_pattern.get()));
</span><span class="lines">@@ -156,24 +156,24 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FontPlatformData::FontPlatformData(float size, bool bold, bool italic)
</span><del>- : m_fallbacks(0)
</del><ins>+ : m_fallbacks(nullptr)
</ins><span class="cx"> , m_size(size)
</span><span class="cx"> , m_syntheticBold(bold)
</span><span class="cx"> , m_syntheticOblique(italic)
</span><span class="cx"> , m_fixedWidth(false)
</span><del>- , m_scaledFont(0)
</del><ins>+ , m_scaledFont(nullptr)
</ins><span class="cx"> , m_orientation(Horizontal)
</span><span class="cx"> {
</span><span class="cx"> // We cannot create a scaled font here.
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FontPlatformData::FontPlatformData(cairo_font_face_t* fontFace, float size, bool bold, bool italic, FontOrientation orientation)
</span><del>- : m_fallbacks(0)
</del><ins>+ : m_fallbacks(nullptr)
</ins><span class="cx"> , m_size(size)
</span><span class="cx"> , m_syntheticBold(bold)
</span><span class="cx"> , m_syntheticOblique(italic)
</span><span class="cx"> , m_fixedWidth(false)
</span><del>- , m_scaledFont(0)
</del><ins>+ , m_scaledFont(nullptr)
</ins><span class="cx"> , m_orientation(orientation)
</span><span class="cx"> {
</span><span class="cx"> initializeWithFontFace(fontFace);
</span><span class="lines">@@ -202,7 +202,7 @@
</span><span class="cx"> if (m_fallbacks) {
</span><span class="cx"> FcFontSetDestroy(m_fallbacks);
</span><span class="cx"> // This will be re-created on demand.
</span><del>- m_fallbacks = 0;
</del><ins>+ m_fallbacks = nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_scaledFont && m_scaledFont != hashTableDeletedFontValue())
</span><span class="lines">@@ -215,15 +215,17 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FontPlatformData::FontPlatformData(const FontPlatformData& other)
</span><del>- : m_fallbacks(0)
- , m_scaledFont(0)
</del><ins>+ : m_fallbacks(nullptr)
+ , m_scaledFont(nullptr)
</ins><span class="cx"> , m_harfBuzzFace(other.m_harfBuzzFace)
</span><span class="cx"> {
</span><span class="cx"> *this = other;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> FontPlatformData::FontPlatformData(const FontPlatformData& other, float size)
</span><del>- : m_harfBuzzFace(other.m_harfBuzzFace)
</del><ins>+ : m_fallbacks(nullptr)
+ , m_scaledFont(nullptr)
+ , m_harfBuzzFace(other.m_harfBuzzFace)
</ins><span class="cx"> {
</span><span class="cx"> *this = other;
</span><span class="cx">
</span><span class="lines">@@ -237,7 +239,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (m_fallbacks) {
</span><span class="cx"> FcFontSetDestroy(m_fallbacks);
</span><del>- m_fallbacks = 0;
</del><ins>+ m_fallbacks = nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_scaledFont && m_scaledFont != hashTableDeletedFontValue())
</span></span></pre>
</div>
</div>
</body>
</html>