<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[178908] branches/safari-600.5-branch/Source/WTF</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/178908">178908</a></dd>
<dt>Author</dt> <dd>matthew_hanson@apple.com</dd>
<dt>Date</dt> <dd>2015-01-22 02:08:58 -0800 (Thu, 22 Jan 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/174377">r174377</a>. rdar://problem/19451247</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari6005branchSourceWTFChangeLog">branches/safari-600.5-branch/Source/WTF/ChangeLog</a></li>
<li><a href="#branchessafari6005branchSourceWTFwtfDateMathcpp">branches/safari-600.5-branch/Source/WTF/wtf/DateMath.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari6005branchSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-600.5-branch/Source/WTF/ChangeLog (178907 => 178908)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-600.5-branch/Source/WTF/ChangeLog 2015-01-22 10:08:56 UTC (rev 178907)
+++ branches/safari-600.5-branch/Source/WTF/ChangeLog 2015-01-22 10:08:58 UTC (rev 178908)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2015-01-22 Matthew Hanson <matthew_hanson@apple.com>
+
+ Merge r174377. rdar://problem/19451247
+
+ 2014-10-06 Brent Fulgham <bfulgham@apple.com>
+
+ [Win] DateMath's calculateUTFOffset does not account for DST.
+ https://bugs.webkit.org/show_bug.cgi?id=137458
+ <rdar://problem/18559172>
+
+ Reviewed by Geoffrey Garen.
+
+ Check the return value of GetTimeZoneInformation and use the
+ proper bias against UTC (depending on whether we are in daylight
+ savings time, or standard time).
+
+ Also, handle possible error cases in the FileTimeToSystemTime
+ and SystemTimeToTzSpecificLocalTime, rather than using potentially
+ uninitialized values.
+
+ * wtf/DateMath.cpp:
+ (WTF::calculateUTCOffset): Use proper daylight-savings-time state.
+ (WTF::calculateDSTOffset): Avoid uninitialized data due to failing
+ API calls.
+
</ins><span class="cx"> 2015-01-15 Matthew Hanson <matthew_hanson@apple.com>
</span><span class="cx">
</span><span class="cx"> Merge r177448. rdar://problem/19451944
</span></span></pre></div>
<a id="branchessafari6005branchSourceWTFwtfDateMathcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-600.5-branch/Source/WTF/wtf/DateMath.cpp (178907 => 178908)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-600.5-branch/Source/WTF/wtf/DateMath.cpp 2015-01-22 10:08:56 UTC (rev 178907)
+++ branches/safari-600.5-branch/Source/WTF/wtf/DateMath.cpp 2015-01-22 10:08:58 UTC (rev 178908)
</span><span class="lines">@@ -369,8 +369,16 @@
</span><span class="cx"> {
</span><span class="cx"> #if OS(WINDOWS)
</span><span class="cx"> TIME_ZONE_INFORMATION timeZoneInformation;
</span><del>- GetTimeZoneInformation(&timeZoneInformation);
- int32_t bias = timeZoneInformation.Bias + timeZoneInformation.StandardBias;
</del><ins>+ DWORD rc = ::GetTimeZoneInformation(&timeZoneInformation);
+ if (rc == TIME_ZONE_ID_INVALID)
+ return 0;
+
+ int32_t bias = 0;
+ if (rc == TIME_ZONE_ID_DAYLIGHT)
+ bias = timeZoneInformation.Bias + timeZoneInformation.DaylightBias;
+ else if (rc == TIME_ZONE_ID_STANDARD || rc == TIME_ZONE_ID_UNKNOWN)
+ bias = timeZoneInformation.Bias + timeZoneInformation.StandardBias;
+
</ins><span class="cx"> return -bias * 60 * 1000;
</span><span class="cx"> #else
</span><span class="cx"> time_t localTime = time(0);
</span><span class="lines">@@ -432,8 +440,10 @@
</span><span class="cx"> FILETIME utcFileTime;
</span><span class="cx"> UnixTimeToFileTime(localTime, &utcFileTime);
</span><span class="cx"> SYSTEMTIME utcSystemTime, localSystemTime;
</span><del>- FileTimeToSystemTime(&utcFileTime, &utcSystemTime);
- SystemTimeToTzSpecificLocalTime(0, &utcSystemTime, &localSystemTime);
</del><ins>+ if (!::FileTimeToSystemTime(&utcFileTime, &utcSystemTime))
+ return 0;
+ if (!::SystemTimeToTzSpecificLocalTime(nullptr, &utcSystemTime, &localSystemTime))
+ return 0;
</ins><span class="cx">
</span><span class="cx"> double offsetTime = (localTime * msPerSecond) + utcOffset;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>